Kevin Veen-Birkenbach
a42930a699
test-e2e drove Cypress through act, which fails to start where it cannot resolve a host address for its artifact server. It now starts Flask and Cypress in one shell via scripts/run-e2e.sh, so both share a network namespace; the act path stays available as test-e2e-act. The script guards the cases that made the old target lie: it aborts when something already serves the port instead of testing that server, checks that its own Flask is alive before trusting a response, pins Cypress to the same origin Flask binds, and drops ELECTRON_RUN_AS_NODE, which VS Code exports and which makes Cypress' bundled Electron reject its own flags. 30 YAML and 18 JavaScript files had no linter. yamllint runs correctness rules only, because the repository predates it and its cosmetic findings would be noise; key-duplicates is the one that earns its keep, since PyYAML keeps the last of two identical keys without complaining. eslint runs the recommended set and already found a dead getBoundingClientRect() call in navigation.js. Both get a CI job so make lint and the workflows stop diverging. flask>=3.1 because app.config["TRUSTED_HOSTS"] arrived in 3.1 and an older Flask accepts the key and ignores it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
133 lines
3.0 KiB
YAML
133 lines
3.0 KiB
YAML
name: Lint
|
|
|
|
on:
|
|
workflow_call:
|
|
workflow_dispatch:
|
|
|
|
permissions:
|
|
contents: read
|
|
|
|
jobs:
|
|
lint-actions:
|
|
name: Lint GitHub Actions
|
|
runs-on: ubuntu-latest
|
|
|
|
steps:
|
|
- name: Checkout repository
|
|
uses: actions/checkout@v6
|
|
|
|
- name: Run actionlint
|
|
run: docker run --rm -v "$PWD:/repo" -w /repo rhysd/actionlint:latest
|
|
|
|
lint-yaml:
|
|
name: Lint YAML
|
|
runs-on: ubuntu-latest
|
|
|
|
steps:
|
|
- name: Checkout repository
|
|
uses: actions/checkout@v6
|
|
|
|
- name: Set up Python
|
|
uses: actions/setup-python@v6
|
|
with:
|
|
python-version: "3.12"
|
|
|
|
- name: Install lint dependencies
|
|
run: |
|
|
python -m pip install --upgrade pip
|
|
pip install ".[dev]"
|
|
|
|
- name: Run yamllint
|
|
run: yamllint --strict .
|
|
|
|
lint-js:
|
|
name: Lint JavaScript
|
|
runs-on: ubuntu-latest
|
|
|
|
steps:
|
|
- name: Checkout repository
|
|
uses: actions/checkout@v6
|
|
|
|
- name: Set up Node.js
|
|
uses: actions/setup-node@v4
|
|
with:
|
|
node-version: "20"
|
|
cache: npm
|
|
cache-dependency-path: app/package.json
|
|
|
|
- name: Install Node dependencies
|
|
working-directory: app
|
|
run: npm install
|
|
|
|
- name: Run eslint
|
|
working-directory: app
|
|
run: npx eslint .
|
|
|
|
lint-shell:
|
|
name: Lint shell scripts
|
|
runs-on: ubuntu-latest
|
|
|
|
steps:
|
|
- name: Checkout repository
|
|
uses: actions/checkout@v6
|
|
|
|
- name: Run shellcheck
|
|
run: docker run --rm -v "$PWD:/mnt" -w /mnt koalaman/shellcheck:stable scripts/*.sh
|
|
|
|
lint-python:
|
|
name: Lint Python
|
|
runs-on: ubuntu-latest
|
|
|
|
steps:
|
|
- name: Checkout repository
|
|
uses: actions/checkout@v6
|
|
|
|
- name: Set up Python
|
|
uses: actions/setup-python@v6
|
|
with:
|
|
python-version: "3.12"
|
|
|
|
- name: Install lint dependencies
|
|
run: |
|
|
python -m pip install --upgrade pip
|
|
pip install ".[dev]"
|
|
|
|
- name: Ruff lint
|
|
run: ruff check .
|
|
|
|
- name: Ruff format check
|
|
run: ruff format --check .
|
|
|
|
lint-docker:
|
|
name: Lint Dockerfile
|
|
runs-on: ubuntu-latest
|
|
permissions:
|
|
contents: read
|
|
security-events: write
|
|
|
|
steps:
|
|
- name: Checkout repository
|
|
uses: actions/checkout@v6
|
|
|
|
- name: Run hadolint
|
|
id: hadolint
|
|
continue-on-error: true
|
|
uses: hadolint/hadolint-action@2332a7b74a6de0dda2e2221d575162eba76ba5e5
|
|
with:
|
|
dockerfile: ./Dockerfile
|
|
format: sarif
|
|
output-file: hadolint-results.sarif
|
|
failure-threshold: warning
|
|
|
|
- name: Upload hadolint SARIF
|
|
if: always() && github.event_name == 'push'
|
|
uses: github/codeql-action/upload-sarif@v4
|
|
with:
|
|
sarif_file: hadolint-results.sarif
|
|
wait-for-processing: true
|
|
category: hadolint
|
|
|
|
- name: Fail on hadolint warnings
|
|
if: always()
|
|
run: python3 utils/check_hadolint_sarif.py hadolint-results.sarif
|