Optimized CreateSourceAction

application/symfony/src/Domain/ActionManagement/Create/CreateSourceAction.php

@@ -60,6 +60,7 @@ final class CreateSourceAction extends AbstractCreateAction
         $this->setSourceClass();
         $this->setRequestedEntityClass();
         $this->setForm();
+        $this->handleRequest();
     }
 
     /**
@@ -84,6 +85,5 @@ final class CreateSourceAction extends AbstractCreateAction
      */
     protected function proccess()
     {
-        $this->prepare();
     }
 }

application/symfony/src/Form/Source/PureSourceCreateType.php

@@ -1,4 +1,5 @@
 <?php
+
 namespace App\Form\Source;
 
 use Symfony\Component\Form\FormBuilderInterface;
@@ -8,14 +9,11 @@ use App\Attribut\SlugAttributInterface;
 use App\Attribut\ClassAttributInterface;
 
 /**
- *
  * @author kevinfrantz
  */
 final class PureSourceCreateType extends SourceType
 {
-
     /**
-     *
      * {@inheritdoc}
      *
      * @see \Symfony\Component\Form\AbstractType::buildForm()
@@ -25,18 +23,19 @@ final class PureSourceCreateType extends SourceType
         $builder
         ->add(SlugAttributInterface::SLUG_ATTRIBUT_NAME)
         ->add(ClassAttributInterface::CLASS_ATTRIBUT_NAME, SourceType::class, [
-            'mapped' => false
+            'mapped' => false,
         ]);
     }
 
     /**
-     * {@inheritDoc}
+     * {@inheritdoc}
+     *
      * @see \Symfony\Component\Form\AbstractType::configureOptions()
      */
     public function configureOptions(OptionsResolver $resolver)
     {
         $resolver->setDefaults([
-            'data_class' => PureSource::class
+            'data_class' => PureSource::class,
         ]);
     }
 }

application/symfony/tests/Integration/Domain/ActionManagement/Create/CreateSourceActionIntegrationTest.php

@@ -7,8 +7,6 @@ use App\Domain\ActionManagement\ActionService;
 use App\Domain\ActionManagement\Create\CreateActionInterface;
 use App\Domain\ActionManagement\ActionServiceInterface;
 use Symfony\Component\HttpFoundation\RequestStack;
-use App\Domain\RepositoryManagement\LayerRepositoryFactoryServiceInterface;
-use App\Domain\SecureManagement\SecureRequestedRightCheckerInterface;
 use App\Entity\Source\PureSourceInterface;
 use App\Domain\RequestManagement\Action\RequestedActionService;
 use App\Domain\RequestManagement\Right\RequestedRightService;
@@ -24,6 +22,9 @@ use App\Domain\FormManagement\FormClassNameService;
 use App\Domain\RequestManagement\Entity\RequestedEntityService;
 use App\Entity\Source\PureSource;
 use App\Attribut\ClassAttributInterface;
+use App\Domain\RepositoryManagement\LayerRepositoryFactoryService;
+use App\Domain\SecureManagement\SecureRequestedRightChecker;
+use App\Domain\RightManagement\RightTransformerService;
 
 /**
  * @todo Implement test and logic!!!!!
@@ -52,6 +53,11 @@ class CreateSourceActionIntegrationTest extends KernelTestCase
      */
     private $request;
 
+    /**
+     * @var RequestStack
+     */
+    private $requestStack;
+
     public function setUp(): void
     {
         self::bootKernel();
@@ -69,16 +75,23 @@ class CreateSourceActionIntegrationTest extends KernelTestCase
         $formClassNameService = new FormClassNameService();
         $entityFormBuilderService = new RequestedActionFormBuilderService($formFactory, $formClassNameService, $this->requestedActionService);
         $this->request = new Request();
-        $requestStack = $this->createMock(RequestStack::class);
+        $this->requestStack = new RequestStack();
-        $requestStack->method('getCurrentRequest')->willReturn($this->request);
+        $this->requestStack->push($this->request);
-        $layerRepositoryFactoryService = $this->createMock(LayerRepositoryFactoryServiceInterface::class);
+        $layerRepositoryFactoryService = new LayerRepositoryFactoryService($entityManager);
-        $secureRequestedRightChecker = $this->createMock(SecureRequestedRightCheckerInterface::class);
+        $rightTransformerService = new RightTransformerService();
-        $this->actionService = new ActionService($this->requestedActionService, $secureRequestedRightChecker, $requestStack, $layerRepositoryFactoryService, $entityFormBuilderService, $entityManager);
+        $secureRequestedRightChecker = new SecureRequestedRightChecker($rightTransformerService);
+        $this->actionService = new ActionService($this->requestedActionService, $secureRequestedRightChecker, $this->requestStack, $layerRepositoryFactoryService, $entityFormBuilderService, $entityManager);
         $this->createSourceAction = new CreateSourceAction($this->actionService);
     }
 
+    public function testPreconditions(): void
+    {
+        $this->assertEquals($this->request, $this->requestStack->getCurrentRequest());
+    }
+
     public function testCreateWithGuestUser(): void
     {
+        $this->request->setMethod(Request::METHOD_POST);
         $this->request->attributes->set(ClassAttributInterface::CLASS_ATTRIBUT_NAME, PureSource::class);
         $this->assertInstanceOf(PureSourceInterface::class, $this->createSourceAction->execute());
     }