kevinveenbirkenbach/infinito
1
0
Fork 0
mirror of https://github.com/kevinveenbirkenbach/infinito.git synced 2024-12-04 23:17:19 +01:00
Code Issues Packages Projects Releases Wiki Activity

Optimized CreateSourceAction

Browse Source
This commit is contained in:
Kevin Frantz 2019-02-13 19:37:53 +01:00
parent d6999cb601
commit b0d57e41f3
3 changed files with 26 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
application/symfony/src/Domain/ActionManagement/Create/CreateSourceAction.php
View File

@ -60,6 +60,7 @@ final class CreateSourceAction extends AbstractCreateAction
$this->setSourceClass();
$this->setRequestedEntityClass();
$this->setForm();
$this->handleRequest();
}
/**
@ -84,6 +85,5 @@ final class CreateSourceAction extends AbstractCreateAction
*/
protected function proccess()
{
$this->prepare();
}
}

11
application/symfony/src/Form/Source/PureSourceCreateType.php
View File

@ -1,4 +1,5 @@
<?php
namespace App\Form\Source;
use Symfony\Component\Form\FormBuilderInterface;
@ -8,14 +9,11 @@ use App\Attribut\SlugAttributInterface;
use App\Attribut\ClassAttributInterface;
/**
*
* @author kevinfrantz
*/
final class PureSourceCreateType extends SourceType
{
/**
*
* {@inheritdoc}
*
* @see \Symfony\Component\Form\AbstractType::buildForm()
@ -25,18 +23,19 @@ final class PureSourceCreateType extends SourceType
$builder
->add(SlugAttributInterface::SLUG_ATTRIBUT_NAME)
->add(ClassAttributInterface::CLASS_ATTRIBUT_NAME, SourceType::class, [
'mapped' => false
'mapped' => false,
]);
}
/**
* {@inheritDoc}
* {@inheritdoc}
*
* @see \Symfony\Component\Form\AbstractType::configureOptions()
*/
public function configureOptions(OptionsResolver $resolver)
{
$resolver->setDefaults([
'data_class' => PureSource::class
'data_class' => PureSource::class,
]);
}
}

27
application/symfony/tests/Integration/Domain/ActionManagement/Create/CreateSourceActionIntegrationTest.php
View File

@ -7,8 +7,6 @@ use App\Domain\ActionManagement\ActionService;
use App\Domain\ActionManagement\Create\CreateActionInterface;
use App\Domain\ActionManagement\ActionServiceInterface;
use Symfony\Component\HttpFoundation\RequestStack;
use App\Domain\RepositoryManagement\LayerRepositoryFactoryServiceInterface;
use App\Domain\SecureManagement\SecureRequestedRightCheckerInterface;
use App\Entity\Source\PureSourceInterface;
use App\Domain\RequestManagement\Action\RequestedActionService;
use App\Domain\RequestManagement\Right\RequestedRightService;
@ -24,6 +22,9 @@ use App\Domain\FormManagement\FormClassNameService;
use App\Domain\RequestManagement\Entity\RequestedEntityService;
use App\Entity\Source\PureSource;
use App\Attribut\ClassAttributInterface;
use App\Domain\RepositoryManagement\LayerRepositoryFactoryService;
use App\Domain\SecureManagement\SecureRequestedRightChecker;
use App\Domain\RightManagement\RightTransformerService;
/**
* @todo Implement test and logic!!!!!
@ -52,6 +53,11 @@ class CreateSourceActionIntegrationTest extends KernelTestCase
*/
private $request;
/**
* @var RequestStack
*/
private $requestStack;
public function setUp(): void
{
self::bootKernel();
@ -69,16 +75,23 @@ class CreateSourceActionIntegrationTest extends KernelTestCase
$formClassNameService = new FormClassNameService();
$entityFormBuilderService = new RequestedActionFormBuilderService($formFactory, $formClassNameService, $this->requestedActionService);
$this->request = new Request();
$requestStack = $this->createMock(RequestStack::class);
$requestStack->method('getCurrentRequest')->willReturn($this->request);
$layerRepositoryFactoryService = $this->createMock(LayerRepositoryFactoryServiceInterface::class);
$secureRequestedRightChecker = $this->createMock(SecureRequestedRightCheckerInterface::class);
$this->actionService = new ActionService($this->requestedActionService, $secureRequestedRightChecker, $requestStack, $layerRepositoryFactoryService, $entityFormBuilderService, $entityManager);
$this->requestStack = new RequestStack();
$this->requestStack->push($this->request);
$layerRepositoryFactoryService = new LayerRepositoryFactoryService($entityManager);
$rightTransformerService = new RightTransformerService();
$secureRequestedRightChecker = new SecureRequestedRightChecker($rightTransformerService);
$this->actionService = new ActionService($this->requestedActionService, $secureRequestedRightChecker, $this->requestStack, $layerRepositoryFactoryService, $entityFormBuilderService, $entityManager);
$this->createSourceAction = new CreateSourceAction($this->actionService);
}
public function testPreconditions(): void
{
$this->assertEquals($this->request, $this->requestStack->getCurrentRequest());
}
public function testCreateWithGuestUser(): void
{
$this->request->setMethod(Request::METHOD_POST);
$this->request->attributes->set(ClassAttributInterface::CLASS_ATTRIBUT_NAME, PureSource::class);
$this->assertInstanceOf(PureSourceInterface::class, $this->createSourceAction->execute());
}