mirror of
https://github.com/kevinveenbirkenbach/docker-volume-backup.git
synced 2026-07-17 14:15:13 +00:00
Kevin Veen-Birkenbach
b9a8b391f0
Treating every failed swarm-task inspect as skippable opened a false-green window: a transient inspect failure on a still-running, non-whitelisted container skipped the stop and backed the volume up hot while the run reported success. Re-check whether the container is still listed; only a genuinely vanished container skips, an existing one re-raises so a broken daemon keeps failing the run loudly. Covered by unit tests for both paths. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
54 lines
2.1 KiB
Python
54 lines
2.1 KiB
Python
import unittest
|
|
from unittest.mock import patch
|
|
|
|
from baudolo.backup import docker as docker_mod
|
|
from baudolo.backup.shell import BackupException
|
|
|
|
|
|
class TestIsSwarmTask(unittest.TestCase):
|
|
@patch.object(docker_mod, "execute_shell_command", return_value=["task-id-123"])
|
|
def test_true_when_task_label_present(self, _mock) -> None:
|
|
self.assertTrue(docker_mod.is_swarm_task("c1"))
|
|
|
|
@patch.object(docker_mod, "execute_shell_command", return_value=[""])
|
|
def test_false_when_label_empty(self, _mock) -> None:
|
|
self.assertFalse(docker_mod.is_swarm_task("c1"))
|
|
|
|
@patch.object(docker_mod, "execute_shell_command", return_value=[])
|
|
def test_false_when_no_output(self, _mock) -> None:
|
|
self.assertFalse(docker_mod.is_swarm_task("c1"))
|
|
|
|
@patch.object(
|
|
docker_mod,
|
|
"execute_shell_command",
|
|
side_effect=[BackupException("gone"), []],
|
|
)
|
|
def test_vanished_container_counts_as_not_stoppable(self, _mock) -> None:
|
|
# A container removed between listing and inspect must not abort the
|
|
# whole backup run; treating it as a swarm task keeps it out of every
|
|
# stop/start and image-inspect path.
|
|
self.assertTrue(docker_mod.is_swarm_task("gone-container"))
|
|
|
|
@patch.object(
|
|
docker_mod,
|
|
"execute_shell_command",
|
|
side_effect=[BackupException("daemon hiccup"), ["still-here"]],
|
|
)
|
|
def test_inspect_failure_on_existing_container_still_fails(self, _mock) -> None:
|
|
# If the container still exists, an inspect failure must keep failing
|
|
# the run: silently skipping the stop would back up a hot volume and
|
|
# report green without the stop guarantee.
|
|
with self.assertRaises(BackupException):
|
|
docker_mod.is_swarm_task("still-here")
|
|
|
|
|
|
class TestFilterStoppable(unittest.TestCase):
|
|
@patch.object(docker_mod, "is_swarm_task", side_effect=[False, True, False])
|
|
def test_mixed_list_keeps_order_and_drops_tasks(self, _mock) -> None:
|
|
result = docker_mod.filter_stoppable(["plain-1", "swarm-task", "plain-2"])
|
|
self.assertEqual(result, ["plain-1", "plain-2"])
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|