mirror of
https://github.com/kevinveenbirkenbach/docker-volume-backup.git
synced 2026-08-20 21:22:54 +00:00
Kevin Veen-Birkenbach
57fc7c96bc
A run starting in the same wall-clock second as its predecessor reused that predecessor's generation directory: mkdir carried exist_ok=True, so rsync --delete overwrote a finished generation before create_stamp_file refused the already-stamped directory and exited 2. The guard fired after the damage. Claim the directory exclusively instead. create_version_directory is the first filesystem action of a run, so the abort now happens with zero writes. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
54 lines
2.0 KiB
Python
54 lines
2.0 KiB
Python
"""Contract of where a backup run puts its directories."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import tempfile
|
|
import unittest
|
|
from pathlib import Path
|
|
from unittest import mock
|
|
|
|
from baudolo.backup import layout as mod
|
|
from baudolo.backup.shell import BackupException
|
|
|
|
|
|
class TestVersionDirectory(unittest.TestCase):
|
|
def test_it_creates_the_generation_directory(self) -> None:
|
|
with tempfile.TemporaryDirectory() as tmp:
|
|
created = mod.create_version_directory(tmp, "20260731020304")
|
|
self.assertTrue(Path(created).is_dir())
|
|
self.assertEqual(Path(created).name, "20260731020304")
|
|
|
|
def test_it_refuses_a_generation_another_run_already_claimed(self) -> None:
|
|
with tempfile.TemporaryDirectory() as tmp:
|
|
mod.create_version_directory(tmp, "20260731")
|
|
with self.assertRaises(BackupException) as caught:
|
|
mod.create_version_directory(tmp, "20260731")
|
|
self.assertIn("20260731", str(caught.exception))
|
|
|
|
def test_it_creates_missing_parents(self) -> None:
|
|
with tempfile.TemporaryDirectory() as tmp:
|
|
nested = str(Path(tmp) / "machine" / "repo")
|
|
created = mod.create_version_directory(nested, "20260731")
|
|
self.assertTrue(Path(created).is_dir())
|
|
|
|
|
|
class TestVolumeDirectory(unittest.TestCase):
|
|
def test_it_nests_the_volume_under_the_generation(self) -> None:
|
|
with tempfile.TemporaryDirectory() as tmp:
|
|
created = mod.create_volume_directory(tmp, "postgres_data")
|
|
self.assertEqual(Path(created).parent, Path(tmp))
|
|
self.assertTrue(Path(created).is_dir())
|
|
|
|
|
|
class TestMachineId(unittest.TestCase):
|
|
def test_it_takes_the_hash_without_the_filename(self) -> None:
|
|
digest = "a" * 64
|
|
with mock.patch.object(
|
|
mod, "execute_shell_command", return_value=[f"{digest} /etc/machine-id"]
|
|
):
|
|
self.assertEqual(mod.get_machine_id(), digest)
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|