mirror of
https://github.com/kevinveenbirkenbach/docker-volume-backup.git
synced 2026-08-20 21:22:54 +00:00
Kevin Veen-Birkenbach
df1c65ccac
Two defaults could not be right. --repo-name fell back to the literal 'backup-docker-to-local' while its help promised the git repo folder name, which nothing ever derived. --databases-csv pointed inside the installed package directory, where credentials must not live; when it applied, load_databases_df read a missing file as empty and the run finished without a single dump and without an error. Both are required now, --repo-name in the restore CLI too. The file itself may still be absent - babadcb's tolerance is untouched, only the path must be named. --everything is withdrawn. Its one effect was to ignore --images-no-stop-required, which is what leaving that list empty already does, and its branch was the default path minus the requires_stop check. No caller, no test, and help and README described it differently. --dump-only-sql becomes --only-sql, and --only-files joins it as the opposite half: no dumps at all, every volume as files. They form a mutually exclusive group. A host that only copies files has no business holding database passwords, so --databases-csv is not required there and is never read. The smallest valid argv turned out to be written four times across the test tree; it now lives once. Withdrawn flags are listed in one place and proven to exit 2. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
46 lines
1.3 KiB
Python
46 lines
1.3 KiB
Python
from __future__ import annotations
|
|
|
|
import unittest
|
|
from unittest.mock import patch
|
|
|
|
from . import BASE_ARGV
|
|
|
|
|
|
class HardRestartArgTests(unittest.TestCase):
|
|
"""The hard-restart list defaults to empty (no compose down/up); callers
|
|
opt in per dir, e.g. compose hosts pass 'mailu' while swarm hosts, where
|
|
the dir is a stack whose overlay network collides with compose up, pass
|
|
nothing."""
|
|
|
|
def _parse(self, extra: list[str]):
|
|
import sys
|
|
|
|
from baudolo.backup import cli
|
|
|
|
argv = [
|
|
*BASE_ARGV,
|
|
"--database-containers",
|
|
"postgres",
|
|
"--images-no-stop-required",
|
|
"redis",
|
|
*extra,
|
|
]
|
|
with patch.object(sys, "argv", argv):
|
|
return cli.parse_args()
|
|
|
|
def test_default_is_empty(self) -> None:
|
|
args = self._parse([])
|
|
self.assertEqual(args.hard_restart_projects, [])
|
|
|
|
def test_empty_flag_stays_empty(self) -> None:
|
|
args = self._parse(["--hard-restart-projects"])
|
|
self.assertEqual(args.hard_restart_projects, [])
|
|
|
|
def test_explicit_names_preserved(self) -> None:
|
|
args = self._parse(["--hard-restart-projects", "mailu", "foo"])
|
|
self.assertEqual(args.hard_restart_projects, ["mailu", "foo"])
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main(verbosity=2)
|