mirror of
https://github.com/kevinveenbirkenbach/docker-volume-backup.git
synced 2026-08-20 13:12:48 +00:00
Kevin Veen-Birkenbach
2129c5e362
ruff was never wired into this repository: no target, no CI step, no pin. It reported 45 findings across sources and tests, so nothing enforced what the codebase already mostly followed. Adds `make ruff` (check + format --check), `make ruff-fix`, and `make lint` as its alias, and makes `make test` run lint as a fourth parallel spur. The CI workflow calls `make test`, so it is covered there too. The linter is pinned in a `lint` extra: a ruff minor bump changes which rules fire, and with the suite gating on a clean run an unpinned linter would fail it on an unrelated day. The 45 findings are fixed rather than configured away. Three needed a decision instead of the mechanical fix: - The generation timestamp keeps its local wall clock (DTZ005 waived). Generations sort by that name, and UTC would order new ones before the existing ones wherever the offset is positive - "newest generation" is what every restore path selects on. - The per-volume `copy` closure now binds volume_name and vol_dir as default arguments (B023). It only worked because it is called inside the same iteration. - The two CLI top-level handlers keep their blind except (BLE001 waived): turning any failure into exit 1 is what a CLI boundary is for. The two in run.py did not need it and were narrowed to what they actually catch. Also drops the comments that restate the code: the section banners in restore/__main__.py, the filename repeated as line 1 of nine test files, step narration above the statement it narrates, and a block in app.py documenting parameters that had moved to another module. What names a trip-wire stays - the snapshot destination rule, the mysql-binary absence in MariaDB 11 images, the session-scoped FOREIGN_KEY_CHECKS, the spooled temp file for multi-GB dumps, and the negative control that loses its discriminating power if it ever passes. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
65 lines
1.8 KiB
Python
65 lines
1.8 KiB
Python
from __future__ import annotations
|
|
|
|
import unittest
|
|
from unittest.mock import patch
|
|
|
|
|
|
class HardRestartArgTests(unittest.TestCase):
|
|
"""The hard-restart list defaults to empty (no compose down/up); callers
|
|
opt in per dir, e.g. compose hosts pass 'mailu' while swarm hosts, where
|
|
the dir is a stack whose overlay network collides with compose up, pass
|
|
nothing."""
|
|
|
|
def _parse(self, extra: list[str]):
|
|
import sys
|
|
|
|
from baudolo.backup import cli
|
|
|
|
argv = [
|
|
"baudolo",
|
|
"--compose-dir",
|
|
"/tmp",
|
|
"--backups-dir",
|
|
"/tmp/backup",
|
|
"--database-containers",
|
|
"postgres",
|
|
"--images-no-stop-required",
|
|
"redis",
|
|
*extra,
|
|
]
|
|
with patch.object(sys, "argv", argv):
|
|
return cli.parse_args()
|
|
|
|
def test_default_is_empty(self) -> None:
|
|
args = self._parse([])
|
|
self.assertEqual(args.hard_restart_projects, [])
|
|
|
|
def test_empty_flag_stays_empty(self) -> None:
|
|
args = self._parse(["--hard-restart-projects"])
|
|
self.assertEqual(args.hard_restart_projects, [])
|
|
|
|
def test_explicit_names_preserved(self) -> None:
|
|
args = self._parse(["--hard-restart-projects", "mailu", "foo"])
|
|
self.assertEqual(args.hard_restart_projects, ["mailu", "foo"])
|
|
|
|
def test_backups_dir_is_required(self) -> None:
|
|
import sys
|
|
|
|
from baudolo.backup import cli
|
|
|
|
argv = [
|
|
"baudolo",
|
|
"--compose-dir",
|
|
"/tmp",
|
|
"--database-containers",
|
|
"postgres",
|
|
"--images-no-stop-required",
|
|
"redis",
|
|
]
|
|
with patch.object(sys, "argv", argv), self.assertRaises(SystemExit):
|
|
cli.parse_args()
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main(verbosity=2)
|