Files
computer-playbook/tests/unit/plugins/lookup/test_compose_file_args.py
T
kevinveenbirkenbachandClaude Opus 4.8 238bc285c7 refactor(lookups): reach merged config via the lookup-loader SPOT
Consumer lookup plugins now reach the merged config through the Ansible
lookup loader instead of importing get_merged_applications /
get_merged_domains from utils.cache. The merge stays one cached
implementation surfaced via the applications/config/domains/users lookups;
consumers call lookup_loader.get(...).run() (the compose_networks idiom).

- get_merged_applications walks the whole meta/ tree recursively
  (meta/**/*.yml to applications.<app>.<path>, addons and any depth) and
  folds the raw meta/volumes.yml subtree onto applications.<app>.volumes
  after the templar render so the Jinja source: strings stay unrendered.
- 31 consumer lookups rerouted; providers (applications/config/
  applications_current_play/users/domains) and the raw-volume accessors
  (volume/nginx) keep the cache import behind # nocheck: lookup-cache-import.
- New lint test_no_cache_imports_in_lookups enforces the contract.
- nfs_flavor is now the flavor SPOT (svc-storage-nfs-server + nfs_client_src
  resolve via lookup('nfs_flavor')); removed the unused STORAGE_NFS_FLAVOR
  group_var. Extracted extract_default_credentials to
  utils/cache/schema_credentials.py to keep applications.py under the cap.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-28 18:35:06 +02:00

214 lines
7.6 KiB
Python

import importlib.util
import unittest
from unittest.mock import patch
from ansible.errors import AnsibleError
from . import PROJECT_ROOT
def _load_module(rel_path: str, name: str):
path = PROJECT_ROOT / rel_path
spec = importlib.util.spec_from_file_location(name, str(path))
mod = importlib.util.module_from_spec(spec)
assert spec and spec.loader
spec.loader.exec_module(mod)
return mod
class _TlsResolveStub:
def __init__(self, enabled: bool, mode: str):
self._enabled = enabled
self._mode = mode
def run(self, terms, variables=None, **kwargs):
return [{"enabled": self._enabled, "mode": self._mode}]
class _DomainsResolveStub:
def run(self, terms, variables=None, **kwargs):
return [(variables or {}).get("domains", {})]
class TestComposeFArgs(unittest.TestCase):
def setUp(self):
self.m = _load_module(
"plugins/lookup/compose_file_args.py",
"compose_file_args_mod",
)
self.lookup = self.m.LookupModule()
# In real Ansible, LookupBase gets _loader/_templar injected.
# For unit tests, set them to placeholders.
self.lookup._loader = object()
self.lookup._templar = object()
# compose_file_args no longer reads variables['compose'].
# It builds compose via get_docker_paths(application_id, DIR_COMPOSITIONS).
self.vars = {
"DIR_COMPOSITIONS": "/x/",
"domains": {
"web-app-a": "example.invalid",
},
}
def _loader_dispatch(self, tls_stub):
# "domains" resolves through variables['domains'] to keep tests hermetic;
# "tls" resolves through the per-test stub.
def _get(name, *args, **kwargs):
if name == "domains":
return _DomainsResolveStub()
if name == "tls":
return tls_stub
raise AssertionError(f"unexpected lookup name: {name}")
return _get
def _stub_get_docker_paths(self, application_id: str, base_dir: str) -> dict:
# Keep structure identical to utils.docker.paths_utils.get_docker_paths()
# but stable for unit tests.
self.assertEqual(application_id, "web-app-a")
self.assertEqual(base_dir, "/x/")
return {
"files": {
"compose": "/x/compose.yml",
"compose_override": "/x/compose.override.yml",
"compose_ca_override": "/x/compose.ca.override.yml",
}
}
def test_includes_base_and_override_when_role_provides_override_and_tls_off(self):
with (
patch.object(
self.m, "get_docker_paths", side_effect=self._stub_get_docker_paths
),
patch.object(self.m, "_role_provides_override", return_value=True),
patch.object(
self.m.lookup_loader,
"get",
side_effect=self._loader_dispatch(_TlsResolveStub(False, "off")),
),
):
out = self.lookup.run(["web-app-a"], variables=self.vars)[0]
self.assertEqual(out, "-f /x/compose.yml -f /x/compose.override.yml")
def test_flag_kwarg_emits_compose_file_for_stack_deploy(self):
with (
patch.object(
self.m, "get_docker_paths", side_effect=self._stub_get_docker_paths
),
patch.object(self.m, "_role_provides_override", return_value=True),
patch.object(
self.m.lookup_loader,
"get",
side_effect=self._loader_dispatch(_TlsResolveStub(False, "off")),
),
):
out = self.lookup.run(
["web-app-a"], variables=self.vars, flag="--compose-file"
)[0]
self.assertEqual(
out, "--compose-file /x/compose.yml --compose-file /x/compose.override.yml"
)
def test_invalid_flag_rejected(self):
with self.assertRaises(AnsibleError):
self.lookup.run(["web-app-a"], variables=self.vars, flag="-bad")
def test_includes_ca_override_when_self_signed_and_domain_exists(self):
with (
patch.object(
self.m, "get_docker_paths", side_effect=self._stub_get_docker_paths
),
patch.object(self.m, "_role_provides_override", return_value=True),
patch.object(
self.m.lookup_loader,
"get",
side_effect=self._loader_dispatch(_TlsResolveStub(True, "self_signed")),
),
):
out = self.lookup.run(["web-app-a"], variables=self.vars)[0]
self.assertEqual(
out,
"-f /x/compose.yml -f /x/compose.override.yml -f /x/compose.ca.override.yml",
)
def test_fails_when_ca_override_missing_but_required(self):
def stub_missing_ca(application_id: str, base_dir: str) -> dict:
return {
"files": {
"compose": "/x/compose.yml",
"compose_override": "/x/compose.override.yml",
"compose_ca_override": "",
}
}
with (
patch.object(self.m, "get_docker_paths", side_effect=stub_missing_ca),
patch.object(self.m, "_role_provides_override", return_value=True),
patch.object(
self.m.lookup_loader,
"get",
side_effect=self._loader_dispatch(_TlsResolveStub(True, "self_signed")),
),
self.assertRaises(AnsibleError),
):
self.lookup.run(["web-app-a"], variables=self.vars)
def test_includes_only_base_when_role_does_not_provide_override(self):
with (
patch.object(
self.m, "get_docker_paths", side_effect=self._stub_get_docker_paths
),
patch.object(self.m, "_role_provides_override", return_value=False),
patch.object(
self.m.lookup_loader,
"get",
side_effect=self._loader_dispatch(_TlsResolveStub(False, "off")),
),
):
out = self.lookup.run(["web-app-a"], variables=self.vars)[0]
self.assertEqual(out, "-f /x/compose.yml")
def test_requires_one_term(self):
with self.assertRaises(AnsibleError):
self.lookup.run([], variables=self.vars)
with self.assertRaises(AnsibleError):
self.lookup.run(["a", "b"], variables=self.vars)
def test_requires_path_docker_compose_instances(self):
with self.assertRaises(AnsibleError):
self.lookup.run(
["web-app-a"], variables={"domains": {"web-app-a": "example.invalid"}}
)
def test_requires_docker_compose_structure_from_get_docker_paths(self):
# get_docker_paths returns non-dict -> must fail
with (
patch.object(self.m, "get_docker_paths", return_value="nope"),
self.assertRaises(AnsibleError),
):
self.lookup.run(["web-app-a"], variables=self.vars)
# get_docker_paths returns dict but missing files -> must fail
with (
patch.object(self.m, "get_docker_paths", return_value={}),
self.assertRaises(AnsibleError),
):
self.lookup.run(["web-app-a"], variables=self.vars)
# get_docker_paths returns dict with non-dict files -> must fail
with (
patch.object(self.m, "get_docker_paths", return_value={"files": "nope"}),
self.assertRaises(AnsibleError),
):
self.lookup.run(["web-app-a"], variables=self.vars)
if __name__ == "__main__":
unittest.main()