Files
computer-playbook/cli/administration/deploy/dedicated/runner.py
T
kevinveenbirkenbachandClaude Opus 5 3cc0214c28 fix(deploy): stop the dedicated deploy from git-cleaning its own checkout
`MODE_CLEANUP` says what to tidy on the deployed system: prune unused Docker
resources, clear Mastodon caches, switch an LDAP user list from `present` to
`exact`. Eight roles read it that way. The dedicated runner read the same flag
and ran `make clean` in the control repository instead, which is
`git clean -fdX` over every ignored path there.

`inventories/production/` is one of those paths. The published host install
guide provisions into it and then deploys against `$INVENTORY/.password`, so
the deploy deleted the vault password it was about to use:

    Removing inventories/production/
    [ERROR] The vault password file .../inventories/production/.password was
    not found

Reproduced in CI on two unrelated rows, arm64/zfs/debian and
amd64/btrfs/centos, so it is neither architecture nor filesystem specific.

The coupling was a name collision, not a decision. 7e5990aa16 generated the
MODE_* flags from `01_modes.yml` and removed the legacy skip flags, and the
repository clean - which had had a flag of its own - was attached to the
generated `MODE_CLEANUP` because one now existed by that name. No other deploy
path does this; `container`, `development` and `swarm` never call `make` at
all.

`make clean` keeps its own entry points, `make setup-clean`, `make clean-sudo`
and `infinito --git-clean`, where a caller asks for it deliberately.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-10-23 10:59:05 +02:00

146 lines
4.5 KiB
Python

from __future__ import annotations
import datetime as dt
import json
import os
import subprocess
import sys
from pathlib import Path
from typing import Any
from cli.administration.inventory.provision.services_disabler import (
ServicesDisabledConflictError,
assert_services_disabled_inventory_consistency_from_env,
)
from cli.meta.roles.services.called import verify as verify_required_system_services
from .proc import run, run_make
def run_ansible_playbook(
*,
repo_root: str,
playbook_path: str,
inventory_validator_path: str,
inventory: str,
modes: dict[str, Any],
limit: str | None = None,
allowed_applications: list[str] | None = None,
password_file: str | None = None,
verbose: int = 0,
skip_build: bool = False,
diff: bool = False,
ansible_args: list[str] | None = None,
) -> None:
"""Run ansible-playbook with the given parameters and execution modes."""
start_time = dt.datetime.now(tz=dt.UTC)
print(f"\n▶️ Script started at: {start_time.isoformat()}\n", flush=True)
if not skip_build:
print("\n🛠️ Running project build (make setup)...\n", flush=True)
run_make(repo_root, "setup")
else:
print("\n🛠️ Build skipped (--skip-build)\n", flush=True)
try:
assert_services_disabled_inventory_consistency_from_env(
inventory_dir=Path(inventory).resolve().parent,
roles_dir=Path(repo_root).resolve() / "roles",
)
except ServicesDisabledConflictError as exc:
print(f"\n[ERROR] {exc}\n", file=sys.stderr)
sys.exit(1)
if modes.get("MODE_ASSERT") is False:
print(
"\n🔍 Inventory assertion explicitly disabled (MODE_ASSERT=false)\n",
flush=True,
)
else:
print("\n🔍 Validating inventory before deployment...\n", flush=True)
try:
run(
[sys.executable, inventory_validator_path, str(Path(inventory).parent)],
cwd=repo_root,
check=True,
)
except subprocess.CalledProcessError:
print(
"\n[ERROR] Inventory validation failed. Aborting deployment.\n",
file=sys.stderr,
)
sys.exit(1)
cmd: list[str] = ["ansible-playbook", "-i", inventory, playbook_path]
if limit:
cmd.extend(["-l", limit])
if allowed_applications:
joined = ",".join(allowed_applications)
cmd.extend(["-e", f"APPLICATIONS_WHITELIST={joined}"])
if modes:
cmd.extend(["-e", json.dumps(modes)])
if password_file:
cmd.extend(["--vault-password-file", password_file])
if diff:
cmd.append("--diff")
if modes.get("MODE_DEBUG", False):
verbose = max(verbose, 3)
if verbose:
cmd.append("-" + "v" * verbose)
if ansible_args:
cmd.extend(ansible_args)
ansible_log_path = (
os.environ.get("ANSIBLE_LOG_PATH") or "/tmp/infinito-deploy.log" # noqa: S108
)
os.environ["ANSIBLE_LOG_PATH"] = ansible_log_path
try:
log_offset_before = Path(ansible_log_path).stat().st_size
except OSError:
log_offset_before = 0
print("\n🚀 Launching Ansible Playbook...\n", flush=True)
result = subprocess.run(cmd, cwd=repo_root, check=False)
if result.returncode != 0:
print(
f"\n[ERROR] ansible-playbook exited with status {result.returncode}\n",
file=sys.stderr,
)
sys.exit(result.returncode)
if allowed_applications:
ok, missing = verify_required_system_services(
roles_dir=Path(repo_root) / "roles",
log_path=ansible_log_path,
log_byte_offset=log_offset_before,
deployed_role_ids=allowed_applications,
)
if not ok:
print(
f"\n[ERROR] required role(s) did not execute for deploy "
f"{allowed_applications}:",
file=sys.stderr,
)
for role in missing:
print(f" - {role}", file=sys.stderr)
print(
" See `required_by` declarations in roles/*/meta/services.yml — "
"the role(s) above must run on every deploy whose primaries match.",
file=sys.stderr,
)
sys.exit(2)
end_time = dt.datetime.now(tz=dt.UTC)
print(f"\n✅ Script ended at: {end_time.isoformat()}\n")
print(f"⏱️ Total execution time: {end_time - start_time}\n")