mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-06 10:59:59 +00:00
kevinveenbirkenbachandClaude Opus 5
575a5a87ac
Every script a role ships now lives under `files/<language>/`, and the unit
suite is split the same way: `tests/unit/python/` beside new sibling trees for
the other languages. `tests/lint/filesystem/test_role_files_layout.py` keeps it
that way; directories whose shape is dictated from outside carry a `.nocheck`
naming the constraint (Docker build contexts, WordPress mu-plugins, the Joomla
extension, Odoo addons, Playwright suites, the `files/test/test.sh` harness
that `test-e2e-cli` resolves generically).
This cannot be applied in halves. Moving a file and repointing what names it
are the same change: 14 references resolve only at deploy time, so the tree is
green either before or after, never between.
Those 14 were found by static resolution over every reference class, not by the
test suite -- a full `make quality-high` was green while all of them were
broken:
* 7 `src:` values built from a role variable holding a bare filename
(svc-bkp-remote-2-local, decidim, espocrm, friendica, joomla, pixelfed x2).
The variable doubles as the destination name inside the container, so the
language segment belongs at the call site, not in the variable.
* `sys-service/tasks/04_base.yml` resolved every consumer's systemd script
through `first_found(..., errors='strict')` over `files/script.{sh,py}`.
18 roles ship exactly that and have no template fallback: the play would
have died on each.
* `sys-front-inj-javascript` fell back to `<role>/files/javascript.js`; the
interface now reads `files/javascript/javascript.js`.
* `sys-front-inj-logout/templates/head_sub.j2` built the cache-busting mtime
path through `path_absolute(... 'files', ...)`.
* 4 `ansible.builtin.script:` invocations naming a bare command
(pull.py, prune.sh, set_postgres_superuser_password.sh, ganesha-serve.sh).
* `dev-python/files/shell/install.sh` pointed at a sibling role's script.
Depth-dependent paths inside the moved trees were bumped accordingly: 59
`parents[N]` computations, 12 relative climbs, and the per-role recover CLI,
whose path `cli/administration/recover/recoverers.py` still assembled from the
pre-move location.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
80 lines
2.7 KiB
Python
80 lines
2.7 KiB
Python
"""The distro SPOT loader resolves names, families, images and platforms."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import unittest
|
|
|
|
from utils.distros import (
|
|
UnknownDistroError,
|
|
dev_runtime_image,
|
|
dev_runtime_images,
|
|
distro_family,
|
|
distro_names,
|
|
distro_of_dev_runtime_image,
|
|
environment_image,
|
|
galaxy_platforms,
|
|
pkgmgr_image,
|
|
)
|
|
|
|
|
|
class TestDistroSpot(unittest.TestCase):
|
|
def test_names_are_the_build_matrix(self) -> None:
|
|
self.assertEqual(
|
|
distro_names(), ("arch", "debian", "ubuntu", "fedora", "centos")
|
|
)
|
|
|
|
def test_every_distro_maps_onto_an_os_family(self) -> None:
|
|
self.assertEqual(
|
|
distro_family(),
|
|
{
|
|
"arch": "Archlinux",
|
|
"debian": "Debian",
|
|
"ubuntu": "Debian",
|
|
"fedora": "RedHat",
|
|
"centos": "RedHat",
|
|
},
|
|
)
|
|
|
|
def test_dev_runtime_images_follow_declaration_order(self) -> None:
|
|
self.assertEqual(dev_runtime_images()[0], dev_runtime_image("arch"))
|
|
self.assertEqual(len(dev_runtime_images()), len(distro_names()))
|
|
|
|
def test_galaxy_platforms_are_sorted_by_name(self) -> None:
|
|
names = [entry["name"] for entry in galaxy_platforms()]
|
|
self.assertEqual(names, sorted(names))
|
|
self.assertEqual(names, ["ArchLinux", "Debian", "EL", "Fedora", "Ubuntu"])
|
|
self.assertTrue(all(e["versions"] == ["all"] for e in galaxy_platforms()))
|
|
|
|
def test_galaxy_platforms_are_not_shared_between_calls(self) -> None:
|
|
first = galaxy_platforms()
|
|
first[0]["versions"].append("mutated")
|
|
self.assertEqual(galaxy_platforms()[0]["versions"], ["all"])
|
|
|
|
def test_pkgmgr_image_renders_the_template(self) -> None:
|
|
self.assertEqual(
|
|
pkgmgr_image("arch", owner="acme", tag="stable"),
|
|
"ghcr.io/acme/pkgmgr-arch:stable",
|
|
)
|
|
|
|
def test_environment_image_renders_the_template(self) -> None:
|
|
self.assertEqual(
|
|
environment_image("centos", owner="acme", repository="nexus", tag="ci-1"),
|
|
"ghcr.io/acme/nexus/centos:ci-1",
|
|
)
|
|
|
|
def test_unknown_distro_is_rejected(self) -> None:
|
|
with self.assertRaises(UnknownDistroError):
|
|
pkgmgr_image("gentoo", owner="acme", tag="stable")
|
|
|
|
def test_dev_runtime_image_round_trips_to_its_distro(self) -> None:
|
|
for name in distro_names():
|
|
self.assertEqual(distro_of_dev_runtime_image(dev_runtime_image(name)), name)
|
|
|
|
def test_unknown_dev_runtime_image_is_rejected(self) -> None:
|
|
with self.assertRaises(UnknownDistroError):
|
|
distro_of_dev_runtime_image("gentoo:latest")
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|