mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-09 20:26:33 +00:00
95 lines
2.0 KiB
Markdown
95 lines
2.0 KiB
Markdown
## Summary
|
||
|
||
Briefly describe the purpose of this pull request.
|
||
|
||
Example:
|
||
|
||
* Add new role for application X
|
||
* Fix configuration issue in role Y
|
||
* Improve container startup logic
|
||
|
||
---
|
||
|
||
## Change Type
|
||
|
||
Select the semantic version impact of this change:
|
||
|
||
* [ ] **Major** – Breaking change (incompatible configuration or behaviour)
|
||
* [ ] **Minor** – New feature or new role (backwards compatible)
|
||
* [ ] **Patch** – Bugfix or internal improvement
|
||
|
||
---
|
||
|
||
## Impacted Areas
|
||
|
||
Select affected components.
|
||
|
||
* [ ] Role implementation
|
||
* [ ] Configuration variables
|
||
* [ ] Documentation
|
||
* [ ] CI/CD
|
||
* [ ] Security
|
||
|
||
---
|
||
|
||
## Description of Changes
|
||
|
||
Explain what was changed and why.
|
||
|
||
Key points:
|
||
|
||
* What problem does this solve?
|
||
* Why was this implementation chosen?
|
||
* Are there alternative approaches?
|
||
|
||
---
|
||
|
||
## Definition of Done (DoD)
|
||
|
||
Please ensure all items are completed before requesting review.
|
||
|
||
### Workflow
|
||
|
||
* [ ] Contributions follow the [collaboration workflow](https://hub.infinito.nexus/t/working-with-folks-in-infinito-nexus/436).
|
||
|
||
### Code Quality
|
||
|
||
* [ ] Code follows repository conventions
|
||
* [ ] Code and comments are written in English
|
||
|
||
### Functionality
|
||
|
||
* [ ] Feature works as expected
|
||
|
||
### Testing
|
||
|
||
* [ ] Changes tested locally
|
||
* [ ] CI pipeline passes
|
||
* [ ] E2E test introduced for web-* roles
|
||
* [ ] Unit test integrated for *.py files
|
||
* [ ] Integration test integrated for *.py files
|
||
|
||
### Documentation
|
||
|
||
* [ ] README.md's and other *.md updated
|
||
* [ ] Link from this request to the https://project.infinito.nexus/ workitem and backwards
|
||
* [ ] Workitem in https://project.infinito.nexus/ updated
|
||
* [ ] Attach a **screenshot of the running application** from the local deployment.([📕local environment setup guide](https://hub.infinito.nexus/t/local-test-environment-deploy/435))
|
||
|
||
---
|
||
|
||
## Checklist for Reviewer
|
||
|
||
Reviewer should verify:
|
||
|
||
* [ ] Code is understandable
|
||
* [ ] Changes follow project guidelines
|
||
* [ ] Documentation is adequate
|
||
* [ ] No obvious security issues
|
||
|
||
---
|
||
|
||
## Additional Notes
|
||
|
||
Add anything reviewers should know.
|