mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-06 10:59:59 +00:00
Every script a role ships now lives under `files/<language>/`, and the unit
suite is split the same way: `tests/unit/python/` beside new sibling trees for
the other languages. `tests/lint/filesystem/test_role_files_layout.py` keeps it
that way; directories whose shape is dictated from outside carry a `.nocheck`
naming the constraint (Docker build contexts, WordPress mu-plugins, the Joomla
extension, Odoo addons, Playwright suites, the `files/test/test.sh` harness
that `test-e2e-cli` resolves generically).
This cannot be applied in halves. Moving a file and repointing what names it
are the same change: 14 references resolve only at deploy time, so the tree is
green either before or after, never between.
Those 14 were found by static resolution over every reference class, not by the
test suite -- a full `make quality-high` was green while all of them were
broken:
* 7 `src:` values built from a role variable holding a bare filename
(svc-bkp-remote-2-local, decidim, espocrm, friendica, joomla, pixelfed x2).
The variable doubles as the destination name inside the container, so the
language segment belongs at the call site, not in the variable.
* `sys-service/tasks/04_base.yml` resolved every consumer's systemd script
through `first_found(..., errors='strict')` over `files/script.{sh,py}`.
18 roles ship exactly that and have no template fallback: the play would
have died on each.
* `sys-front-inj-javascript` fell back to `<role>/files/javascript.js`; the
interface now reads `files/javascript/javascript.js`.
* `sys-front-inj-logout/templates/head_sub.j2` built the cache-busting mtime
path through `path_absolute(... 'files', ...)`.
* 4 `ansible.builtin.script:` invocations naming a bare command
(pull.py, prune.sh, set_postgres_superuser_password.sh, ganesha-serve.sh).
* `dev-python/files/shell/install.sh` pointed at a sibling role's script.
Depth-dependent paths inside the moved trees were bumped accordingly: 59
`parents[N]` computations, 12 relative climbs, and the per-role recover CLI,
whose path `cli/administration/recover/recoverers.py` still assembled from the
pre-move location.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
195 lines
6.6 KiB
Python
195 lines
6.6 KiB
Python
from __future__ import annotations
|
|
|
|
import os
|
|
import sys
|
|
import tempfile
|
|
import unittest
|
|
import unittest.mock
|
|
from pathlib import Path
|
|
|
|
from utils.annotations.summarize import (
|
|
Annotation,
|
|
main,
|
|
parse_log,
|
|
parse_props,
|
|
render_markdown,
|
|
)
|
|
from utils.cache.files import read_text
|
|
|
|
|
|
class TestParseProps(unittest.TestCase):
|
|
def test_single_prop(self) -> None:
|
|
self.assertEqual(parse_props("title=Foo"), {"title": "Foo"})
|
|
|
|
def test_multiple_props(self) -> None:
|
|
result = parse_props("title=My Title,file=foo.py,line=42")
|
|
self.assertEqual(result, {"title": "My Title", "file": "foo.py", "line": "42"})
|
|
|
|
def test_empty_string(self) -> None:
|
|
self.assertEqual(parse_props(""), {})
|
|
|
|
def test_none_like_empty(self) -> None:
|
|
self.assertEqual(parse_props(""), {})
|
|
|
|
|
|
class TestParseLog(unittest.TestCase):
|
|
def _write_log(self, content: str) -> Path:
|
|
with tempfile.NamedTemporaryFile(mode="w", suffix=".txt", delete=False) as f:
|
|
f.write(content)
|
|
return Path(f.name)
|
|
|
|
def test_parses_warning(self) -> None:
|
|
p = self._write_log("::warning title=T,file=f.py,line=3::bad thing\n")
|
|
result = parse_log(p)
|
|
self.assertEqual(len(result), 1)
|
|
a = result[0]
|
|
self.assertEqual(a.level, "warning")
|
|
self.assertEqual(a.title, "T")
|
|
self.assertEqual(a.file, "f.py")
|
|
self.assertEqual(a.line, 3)
|
|
self.assertEqual(a.message, "bad thing")
|
|
|
|
def test_parses_error(self) -> None:
|
|
p = self._write_log("::error title=Oops::something broke\n")
|
|
result = parse_log(p)
|
|
self.assertEqual(len(result), 1)
|
|
self.assertEqual(result[0].level, "error")
|
|
self.assertEqual(result[0].title, "Oops")
|
|
|
|
def test_parses_notice(self) -> None:
|
|
p = self._write_log("::notice::just info\n")
|
|
result = parse_log(p)
|
|
self.assertEqual(len(result), 1)
|
|
self.assertEqual(result[0].level, "notice")
|
|
self.assertIsNone(result[0].title)
|
|
|
|
def test_ignores_non_annotation_lines(self) -> None:
|
|
p = self._write_log("regular output\nsome other line\n")
|
|
self.assertEqual(parse_log(p), [])
|
|
|
|
def test_mixed_log(self) -> None:
|
|
content = (
|
|
"build started\n"
|
|
"::warning title=W::warn msg\n"
|
|
"some output\n"
|
|
"::error::err msg\n"
|
|
)
|
|
p = self._write_log(content)
|
|
result = parse_log(p)
|
|
self.assertEqual(len(result), 2)
|
|
self.assertEqual(result[0].level, "warning")
|
|
self.assertEqual(result[1].level, "error")
|
|
|
|
def test_multiple_annotations(self) -> None:
|
|
lines = "\n".join(f"::warning::msg {i}" for i in range(15))
|
|
p = self._write_log(lines)
|
|
self.assertEqual(len(parse_log(p)), 15)
|
|
|
|
|
|
class TestRenderMarkdown(unittest.TestCase):
|
|
def test_empty_returns_no_annotations_message(self) -> None:
|
|
md = render_markdown([], "My Title")
|
|
self.assertIn("My Title", md)
|
|
self.assertIn("No annotations found", md)
|
|
|
|
def test_warning_section_present(self) -> None:
|
|
annotations = [Annotation(level="warning", message="watch out", title="T")]
|
|
md = render_markdown(annotations, "Summary")
|
|
self.assertIn("Warnings", md)
|
|
self.assertIn("watch out", md)
|
|
self.assertIn("🟡", md)
|
|
|
|
def test_error_section_present(self) -> None:
|
|
annotations = [Annotation(level="error", message="broken")]
|
|
md = render_markdown(annotations, "Summary")
|
|
self.assertIn("Errors", md)
|
|
self.assertIn("🔴", md)
|
|
|
|
def test_notice_section_present(self) -> None:
|
|
annotations = [Annotation(level="notice", message="fyi")]
|
|
md = render_markdown(annotations, "Summary")
|
|
self.assertIn("Notices", md)
|
|
self.assertIn("🔵", md)
|
|
|
|
def test_file_with_line_shown_as_colon_path(self) -> None:
|
|
annotations = [Annotation(level="warning", message="x", file="a.py", line=7)]
|
|
md = render_markdown(annotations, "S")
|
|
self.assertIn("a.py:7", md)
|
|
|
|
def test_pipe_in_message_escaped(self) -> None:
|
|
annotations = [Annotation(level="warning", message="a|b")]
|
|
md = render_markdown(annotations, "S")
|
|
self.assertIn("a\\|b", md)
|
|
|
|
def test_count_in_heading(self) -> None:
|
|
annotations = [
|
|
Annotation(level="warning", message="w1"),
|
|
Annotation(level="warning", message="w2"),
|
|
]
|
|
md = render_markdown(annotations, "S")
|
|
self.assertIn("Warnings (2)", md)
|
|
|
|
def test_warning_table_is_collapsed(self) -> None:
|
|
annotations = [Annotation(level="warning", message="w")]
|
|
md = render_markdown(annotations, "S")
|
|
self.assertIn("<details>\n<summary>🟡 Warnings (1)</summary>", md)
|
|
self.assertIn("</details>", md)
|
|
|
|
def test_error_table_stays_expanded(self) -> None:
|
|
annotations = [Annotation(level="error", message="e")]
|
|
md = render_markdown(annotations, "S")
|
|
self.assertIn("<details open>\n<summary>🔴 Errors (1)</summary>", md)
|
|
|
|
def test_order_error_warning_notice(self) -> None:
|
|
annotations = [
|
|
Annotation(level="notice", message="n"),
|
|
Annotation(level="warning", message="w"),
|
|
Annotation(level="error", message="e"),
|
|
]
|
|
md = render_markdown(annotations, "S")
|
|
error_pos = md.index("Errors")
|
|
warning_pos = md.index("Warnings")
|
|
notice_pos = md.index("Notices")
|
|
self.assertLess(error_pos, warning_pos)
|
|
self.assertLess(warning_pos, notice_pos)
|
|
|
|
|
|
class TestMain(unittest.TestCase):
|
|
def test_writes_to_github_step_summary(self) -> None:
|
|
with tempfile.NamedTemporaryFile(mode="w", suffix=".txt", delete=False) as log:
|
|
log.write("::warning title=T::msg\n")
|
|
log_path = log.name
|
|
|
|
with tempfile.NamedTemporaryFile(
|
|
mode="w", suffix=".md", delete=False
|
|
) as summary:
|
|
summary_path = summary.name
|
|
|
|
old_argv = sys.argv
|
|
try:
|
|
sys.argv = ["summarize", log_path, "Test Title"]
|
|
with unittest.mock.patch.dict(
|
|
os.environ, {"GITHUB_STEP_SUMMARY": summary_path}
|
|
):
|
|
main()
|
|
finally:
|
|
sys.argv = old_argv
|
|
|
|
content = read_text(summary_path)
|
|
self.assertIn("Test Title", content)
|
|
self.assertIn("msg", content)
|
|
|
|
def test_exits_without_args(self) -> None:
|
|
old_argv = sys.argv
|
|
sys.argv = ["summarize"]
|
|
try:
|
|
with self.assertRaises(SystemExit) as cm:
|
|
main()
|
|
self.assertEqual(cm.exception.code, 1)
|
|
finally:
|
|
sys.argv = old_argv
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|