mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-08 19:56:53 +00:00
kevinveenbirkenbachandClaude Opus 5
53c120aaac
Every desk- role becomes dsk-, and the three coding agents move to dsk-gnt- under a category of their own. The category carries a title, hanzi and icon but no invokable flag: an invokable child under an invokable parent is rejected outright, which is also why web itself is not invokable. Three things a search and replace would have broken without a sound. get_entity_name now strips dsk-gnt-, so the primary entity keys agnt-claude, agnt-cursor and agnt-pi no longer resolved and all three roles dropped out of the CI plan. Eighteen run_once guards carried the old name against a convention its own test enforces. DESKTOP_ROLE_PREFIX in the addon spec lint is a literal, so the desktop exemption it grants would have matched nothing and the lint would have moved to the wrong rule in silence. docs/requirements/035 is not a historical document but a register a lint holds to every role with an application_id, so its list carries the new ids. In 026 only the links move; the prose stays as a statement about the tree at the time it was written. Measured against the plan with the rename normalised, the deployed role#variant set is unchanged. A stale id in an inventory is caught before any deploy starts: the pre-flight validator reports Invalid group 'desk-firefox' (not in application_ids). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2.9 KiB
2.9 KiB
Pull Request 🔀
Templates 📋
You MUST pick the template that matches your change. The table below links the actual templates.
| Change type | Template |
|---|---|
Server and web-* changes |
server.md |
Workstation and dsk-* changes |
workstation.md |
Shared system changes such as sys-*, svc-*, dev-*, drv-*, pkgmgr, update-*, or user-* |
system.md |
| CI/CD and workflow changes | pipeline.md |
Documentation-only changes limited to .md or .rst files outside AGENTS.md and docs/agents/* |
documentation.md |
Agent-specific changes limited to AGENTS.md or docs/agents/* |
agents.md |
Branch Naming 🏷️
Branch names MUST follow the naming conventions defined in branch.md. The branch prefix MUST match the type of change and is used to classify the PR scope and select the CI pipeline.
The protection rules enforced on main are documented in branch.md.
Forking Flow 🍴
Before marking a PR as ready for review, CI in your fork MUST be green. The required scope depends on what you changed:
| Change type | Isolated? | Required CI |
|---|---|---|
| Single role | ✅ No dependencies | MAY use manual CI for that role only |
| Single role | ❌ Has dependencies | MUST run full pipeline |
| Multiple roles or shared code | N/A | MUST run full pipeline |
| CI/CD, tooling, systemic | N/A | MUST run full pipeline |
If you are unsure whether other roles are affected, you MUST run the full pipeline.
Drafts 📝
You SHOULD open a Pull Request as a draft while your change is still in progress. CI will not run and no reviewer time is spent until you mark it ready.
- You MUST mark the PR ready for review before requesting a review. CI starts automatically at that point.
- If you continue working on the PR after marking it ready, you MUST convert it back to a draft before pushing new commits. Otherwise CI triggers on every push to the main repository.
- You MAY convert it back to a draft at any time. Any running CI jobs will be cancelled immediately.
Checklist ✅
Before you open a Pull Request:
- CI in your fork MUST be green.
- Your branch MUST be up to date with
main. - Your change SHOULD be small and focused.
- Relevant documentation MUST be updated.
- The correct Pull Request template MUST be used.
- The Pull Request MUST be linked to the related work item in project.infinito.nexus and back.
- Screenshots, logs, traces, or migration notes SHOULD be attached when they help review the change.