mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-07 19:32:17 +00:00
kevinveenbirkenbachandClaude Opus 4.7
26ef3ff504
Adds ``[tool.ruff.lint]`` with ``select = ["E", "F", "I", "B", "UP"]``
and ``target-version = "py311"``. ``E501`` is ignored because
``ruff format`` already reflows what it can; the remaining long lines
are unsplittable string literals / URLs.
Auto-fixed (2753 issues, behavior-preserving):
- UP006/UP035: ``List[X]`` → ``list[X]``, ``Dict[X]`` → ``dict[X]``,
``from typing import …`` redirected where superseded by builtins.
- UP045: ``Optional[X]`` → ``X | None``.
- UP010/UP009/UP015: dropped Python-2-era pragmas (``from __future__
import absolute_import, division, print_function``,
``# -*- coding: utf-8 -*-``), redundant ``open(..., "r")`` mode.
- UP004: dropped implicit ``class X(object):``.
- UP022/UP008/UP032: stdlib idiom modernization (``capture_output``,
super-call simplification, etc.).
- B905: ``zip(...)`` → ``zip(..., strict=False)`` (preserves prior
behavior; switching to ``strict=True`` is a separate semantic
choice not made here).
- I001: import-block ordering.
Hand-fixed (66 issues):
- B904 × 54: appended ``from <bound>`` (when the enclosing ``except``
binds a name) or ``from None`` (when it doesn't) so chained
exceptions stay distinguishable from errors-during-exception-
handling. Applied via a small AST-aware script that walked back to
the enclosing ``except`` clause and matched the binding.
- B017 × 4: narrowed broad ``assertRaises(Exception)`` to the actual
``AnsibleError`` / ``AnsibleFilterError`` raised by the code under
test.
- B023 × 2: bound captured loop variables via default args
(``def _record(name, *, _path_real=path_real, ...)``) so each
closure gets its own snapshot.
- B007 × 2: unused loop control variables renamed to ``_`` /
rewritten to ``.values()``.
- UP007 × 2: ``Union[X, Y]`` → ``X | Y`` (plus dropping the now-unused
``from typing import Union``).
- B018 × 1: Odoo addon manifests are bare dict expressions at module
level by design — suppressed with an inline ``# noqa: B018`` and
rationale comment.
- UP031 × 1: printf-style format → f-string.
The 65 ``# noqa: …`` markers introduced by the auto-fixer all carry
real ruff codes (``B018``, ``E402``, ``F401``, etc.), so
``test_noqa_only_ruff_codes`` stays green.
Verification
============
- ``ruff check .`` → All checks passed
- ``ruff format --check .`` → 894 files already formatted
- ``tests.lint.repository.{test_project_root_import,
test_no_direct_yaml_calls, test_noqa_only_ruff_codes}`` and
``tests.unit.utils.annotations.test_suppress`` → 20 tests OK
- 1621 unit tests → all pass
- Integration suite: 44 failures (pre-existing baseline, none from
this change), 1 skipped.
Going forward, the new rules block regressions on E (style), F
(pyflakes), I (import order), B (likely-bug patterns), and UP
(modernization to py311) for any new code.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
79 lines
1.9 KiB
Python
79 lines
1.9 KiB
Python
from __future__ import annotations
|
|
|
|
import argparse
|
|
import importlib
|
|
import importlib.util
|
|
import sys
|
|
from collections.abc import Iterable
|
|
|
|
|
|
def _module_exists(fullname: str) -> bool:
|
|
return importlib.util.find_spec(fullname) is not None
|
|
|
|
|
|
def _try_import(fullname: str):
|
|
"""
|
|
Import module if it exists, else return None.
|
|
"""
|
|
if not _module_exists(fullname):
|
|
return None
|
|
return importlib.import_module(fullname)
|
|
|
|
|
|
def _iter_command_modules(base_pkg: str, names: Iterable[str]):
|
|
"""
|
|
Yield imported command modules that implement add_parser(sub).
|
|
"""
|
|
for name in names:
|
|
m = _try_import(f"{base_pkg}.{name}")
|
|
if m is None:
|
|
continue
|
|
if hasattr(m, "add_parser"):
|
|
yield name, m
|
|
|
|
|
|
def _build_parser(base_pkg: str) -> argparse.ArgumentParser:
|
|
p = argparse.ArgumentParser(
|
|
prog=f"python -m {base_pkg}",
|
|
description="Infinito.Nexus development compose stack helper.",
|
|
)
|
|
sub = p.add_subparsers(dest="command", required=True)
|
|
|
|
# Keep this list explicit (predictable UX), but tolerate missing modules.
|
|
command_names = [
|
|
"up",
|
|
"down",
|
|
"stop",
|
|
"restart",
|
|
"build",
|
|
"init",
|
|
"deploy",
|
|
"run",
|
|
"exec",
|
|
"logs",
|
|
]
|
|
|
|
for _, mod in _iter_command_modules(base_pkg, command_names):
|
|
mod.add_parser(sub)
|
|
|
|
return p
|
|
|
|
|
|
def main(argv: list[str] | None = None) -> int:
|
|
if argv is None:
|
|
argv = sys.argv[1:]
|
|
|
|
base_pkg = __package__ or "cli.deploy.development"
|
|
parser = _build_parser(base_pkg)
|
|
|
|
args = parser.parse_args(argv)
|
|
|
|
handler = getattr(args, "_handler", None)
|
|
if handler is None:
|
|
# This should not happen if each subparser sets _handler, but keep it safe.
|
|
raise SystemExit(
|
|
f"Command '{getattr(args, 'command', '<unknown>')}' has no handler"
|
|
)
|
|
|
|
return int(handler(args))
|