mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-06 10:59:59 +00:00
kevinveenbirkenbachandClaude Opus 4.7
85f1caccc7
Tighten the utils namespace so each subpackage owns one concern:
- utils/applications/* moves under utils/roles/applications/* (helpers
that operate on the runtime applications dict and meta/services.yml).
- utils/service_registry.py and utils/database_service.py move under
utils/roles/applications/services/ as registry.py and database.py.
- utils/entity_name_utils.py becomes utils/roles/entity_name.py.
- utils/invokable.py, utils/valid_deploy_id.py, and the existing
utils/roles/resource_validation.py group under utils/roles/validation/
as invokable.py, deploy_id.py, and resources.py.
- utils/templating.py and utils/jinja_strict.py split into
utils/templating/ansible.py (Templar + TrustedAsTemplate, lookup-env
shortcut) and utils/templating/jinja.py (vanilla Jinja2 Environment,
multi-pass strict render).
Every caller in utils, cli, plugins, roles/<role>/{filter,lookup}_plugins,
tests, and the docs that link to the moved files is updated to the new
import paths. Test files mirror the new source layout
(tests/unit/utils/{roles,templating}/...).
New READMEs at utils/cleanup/, utils/roles/, utils/roles/applications/services/,
utils/roles/validation/, and utils/templating/ follow the
documentation.md and readme_md.md guidelines.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
8 lines
1.1 KiB
Markdown
8 lines
1.1 KiB
Markdown
# Application Role Tests 📦
|
|
|
|
Integration tests that enforce rules about roles which represent deployable applications: `web-app-*` roles MUST ship a `README.md` (required for the Web App Dashboard), every literal name compared against `group_names` in playbooks/roles MUST resolve to a real `application_id`, every `applications['…']` / `applications.get('…')` / `applications.name` / `get_domain('…')` reference MUST name an existing application, and roles MUST NOT reach into `applications[...]` by subscript; they MUST use `lookup('applications', …)` or `utils.roles.applications.config.get` instead.
|
|
|
|
Tests in this directory MUST only cover application-level role rules. Identity checks tied to the `application_id` variable itself (presence, uniqueness, deprecation, folder-name prefix, ports/domain/run_after/dependency consistency) MUST live under [`id/`](id/). Generic structural role checks MUST live one level up under [`../`](../).
|
|
|
|
For framework, directory layout, and `make test-integration` usage see [integration.md](../../../../docs/contributing/actions/testing/integration.md).
|