mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-06 10:59:59 +00:00
kevinveenbirkenbachandClaude Opus 5
5137465c6f
3529 invalid comments in 528 files, grandfathered in while the linter only saw the working-tree diff. Removal ran through the linter's own collectors, so detection and deletion cannot drift: a comment whose opener line is blank before it and whose closer line is blank after it loses all its lines, anything else loses only the comment region, and a line left holding a bare delimiter goes with it. Five files keep their comments behind a nocheck marker instead. Four are upstream configs whose inline docs are upstream's own (mautrix, systemd journald, nextcloud-oidc-login, MediaWiki). In littlejs the commented-out entries ARE the deactivation mechanism for an example tile, so deleting them would delete configuration. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
58 lines
1.8 KiB
Python
58 lines
1.8 KiB
Python
import unittest
|
|
|
|
import yaml
|
|
|
|
from utils.cache.yaml import load_yaml_any
|
|
from utils.roles.mapping import ROLE_FILE_META_SERVICES, ROLE_FILE_VARS_MAIN
|
|
|
|
from . import PROJECT_ROOT
|
|
|
|
|
|
class TestDockerRoleServicesConfiguration(unittest.TestCase):
|
|
def test_services_keys_and_templates(self):
|
|
"""For each web-app-* role, check that ``meta/services.yml`` contains
|
|
a non-empty mapping at the file root (the services map)."""
|
|
roles_dir = PROJECT_ROOT / "roles"
|
|
errors = []
|
|
warnings = []
|
|
|
|
for role_path in roles_dir.iterdir():
|
|
if not (role_path.is_dir() and role_path.name.startswith("web-app-")):
|
|
continue
|
|
|
|
services_file = role_path / ROLE_FILE_META_SERVICES
|
|
if not services_file.exists():
|
|
continue
|
|
|
|
try:
|
|
services = load_yaml_any(services_file) or {}
|
|
main_file = role_path / ROLE_FILE_VARS_MAIN
|
|
load_yaml_any(main_file) or {}
|
|
except yaml.YAMLError as e:
|
|
errors.append(f"{role_path.name}: YAML parse error: {e}")
|
|
continue
|
|
|
|
if not services:
|
|
warnings.append(f"[WARNING] {role_path.name}: empty meta/services.yml")
|
|
continue
|
|
|
|
if not isinstance(services, dict):
|
|
errors.append(
|
|
f"{role_path.name}: meta/services.yml file root must be a "
|
|
"mapping (the services map;)"
|
|
)
|
|
continue
|
|
if warnings:
|
|
print(
|
|
"\nWarnings in docker role services configuration:\n"
|
|
+ "\n".join(warnings)
|
|
)
|
|
if errors:
|
|
self.fail(
|
|
"Errors in docker role services configuration:\n" + "\n".join(errors)
|
|
)
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|