3 Commits

Include renames

Author	SHA1	Message	Date
kevinveenbirkenbachandClaude Opus 5	5137465c6f	style: delete every comment the comments-valid policy rejects ... 3529 invalid comments in 528 files, grandfathered in while the linter only saw the working-tree diff. Removal ran through the linter's own collectors, so detection and deletion cannot drift: a comment whose opener line is blank before it and whose closer line is blank after it loses all its lines, anything else loses only the comment region, and a line left holding a bare delimiter goes with it. Five files keep their comments behind a nocheck marker instead. Four are upstream configs whose inline docs are upstream's own (mautrix, systemd journald, nextcloud-oidc-login, MediaWiki). In littlejs the commented-out entries ARE the deactivation mechanism for an example tile, so deleting them would delete configuration. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>	2026-08-18 03:22:02 +02:00
kevinveenbirkenbachandClaude Opus 4.7	fbecc09d24	refactor(tests): regroup meta tests, add native-metrics contract ... - New bidirectional contract test ensures `services.prometheus.native_metrics.enabled` and `roles/<role>/templates/prometheus.yml.j2` stay consistent across the roles tree, replacing per-role spot checks for gitea/mattermost/matrix. Document the `native-metrics` suppression rule and apply it to web-app-mattermost (prepared-but-default-off fragment). - Move every test in `tests/integration/meta/config/` into the per-domain layout under `tests/integration/roles/meta/{services,server}`. Group prometheus tests under `services/prometheus/`, repositories tests under `services/repositories/`, the `server.csp` shape test under `server/`. Move `test_non_empty.py` one level up (scans all meta/*.yml, not just services.yml). - Delete `tests/integration/meta/spots/` — both files were only `assertIn` over file contents (brittle, no behavioural coverage, knowledge belongs in code comments or proper integration tests). - Harden `test_project_root_import.py` to catch chained `Path(__file__)…parent.parent.…` walks (the attribute-access twin of `parents[N]` that previously slipped through). Refactor 6 surfaced sites to import canonical `PROJECT_ROOT` / `ROLES_DIR`, plus delete the now-redundant `_find_roles_dir` / `_find_project_root` helpers in `native_metrics_apps` lookup and `invokable_paths` filter plugin. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-17 12:50:35 +02:00
kevinveenbirkenbachandClaude Opus 4.7	4ac7a95ec6	refactor(tests): split overflowing folders into thematic subdirs ... Reorganises four folders that exceeded the 12-item readability limit: - tests/lint/repository/ (27 -> 11): structure/, naming/, documentation/, python/, dependencies/, shell/, yaml/, network/, settings/ - tests/integration/ (25 -> 7): ansible/, infrastructure/, iam/, meta/ (24 sibling dirs grouped under 4 super-categories) - tests/integration/roles/ (13 -> 10): naming/, playwright/, dashboard/ - tests/unit/utils/ (15 -> 12): certs/ for 3 cert/TLS test files Renames 7 test files whose name duplicated the new folder name (e.g. test_no_direct_yaml_calls.py -> yaml/test_no_direct_calls.py, test_dashboard_integration_scope.py -> dashboard/test_integration_scope.py). Adjusts parents[N] in moved __init__.py files, fixes __file__-based path resolution in 8 tests, updates self-path whitelists, and uses absolute imports for PROJECT_ROOT re-exports (ruff TID252). Adds README.md to each new subfolder following the existing scope template. Updates all docs links (suppression.md, base.md, email.md, playwright spec/parity docs, 005-/019- requirements) to new paths. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-15 14:23:32 +02:00