Files
computer-playbook/roles/web-app-checkmk/files/playwright/test-oidc-security.js
kevinveenbirkenbachandClaude Opus 4.8 4c91df5de7 test(e2e): forbid raw page.goto, migrate all specs to Tor-resilient gotoOnion
New lint test_no_raw_goto.py forbids raw `page.goto(...)` in role playwright specs + persona flows (the gotoOnion wrapper in personas/utils is exempt) so navigation retries transient Tor-transport errors over onion. Migrates every raw call across ~75 roles (343 sites) to `gotoOnion(page, ...)` and teaches gotoOnion to detect relative onion URLs (`isOnionCanonical`). gotoOnion is a behaviour-identical drop-in on clearnet (single attempt, same return). Verified: no-raw-goto lint green, eslint 0 errors, make test green.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-08 20:59:38 +02:00

45 lines
1.5 KiB
JavaScript

const { test, expect } = require("@playwright/test");
const { resolveTimeout } = require("./timeouts");
const { skipUnlessServiceEnabled } = require("./service-gating");
const { gotoOnion, normalizeBaseUrl } = require("./personas");
const baseUrl = normalizeBaseUrl(process.env.CHECKMK_BASE_URL || process.env.APP_BASE_URL || "");
const FORGED_IDENTITY_HEADERS = {
"X-Remote-User": "administrator",
"X-Forwarded-User": "administrator",
"X-Forwarded-Preferred-Username": "administrator",
};
test.use({ ignoreHTTPSErrors: true });
test("oidc-security: a forged X-Remote-User header cannot bypass the oauth2-proxy gate", async ({ browser }) => {
skipUnlessServiceEnabled("sso");
expect(baseUrl, "CHECKMK_BASE_URL must be set").toBeTruthy();
const expectedBase = baseUrl.replace(/\/$/, "");
const context = await browser.newContext({
ignoreHTTPSErrors: true,
extraHTTPHeaders: FORGED_IDENTITY_HEADERS,
});
try {
const page = await context.newPage();
await gotoOnion(page, `${expectedBase}/`, { waitUntil: "domcontentloaded" });
await expect
.poll(() => page.url(), {
timeout: resolveTimeout(60_000),
message: "a forged X-Remote-User must be bounced to Keycloak, never into Checkmk",
})
.toContain("openid-connect/auth");
const cookies = await context.cookies(expectedBase);
expect(
cookies.some((c) => c.name.startsWith("auth_")),
"no Checkmk session cookie may be minted from a forged header",
).toBe(false);
} finally {
await context.close();
}
});