mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-06 02:54:26 +00:00
kevinveenbirkenbachandClaude Opus 5
791eee7c9f
The contract check ran as an Ansible task in the middle of every provider deploy, and the two client checks ran the same way. A test that is part of the deploy cannot be run without deploying, cannot be re-run on its own, and reports its verdict as a deploy failure. Twenty-seven task files lose 491 lines to this.
It is now what it always was. Each provider ships files/test/test.sh, templates/test.env.j2 and meta/tests.yml, and test-e2e-cli stages one shared harness beside it: run.sh drives contract.sh in a throwaway container on the provider's own network, then isolation.sh for adapter-fronted providers. The read probe each provider offers moved from the calling task into meta/mcp.yml next to the allowlist it must satisfy, and the schema now rejects a read probe naming a tool outside that allowlist.
The bearer the test presents is the one a client resolves through mcp.credential, via the new mcp_client_bearer lookup over resolve_credential, which moved to utils.roles.applications.mcp so it is the same function mcp_servers renders every client connection with. The probe presented whatever the calling role passed, which for the fifteen adapter-fronted providers is a different secret than any client holds.
Sidecar isolation is read from the engine rather than measured inside the container, so it no longer needs a delegation to the node holding the task: attachment is compared by network name, which drops the gwbridge special case, and a swarm worker says it cannot measure instead of skipping silently.
Retrying is bounded by wall clock against MCP_DEADLINE_SECONDS, which scales through the same lookup('timeout') as the harness budget it has to stay under. A flag that is neither true nor false aborts rather than reading as off.
mcp-provider-probe becomes mcp-provider-cli-test: an enabled provider must ship the test rather than include the task. mcp-probe-bearer becomes mcp-adapter-bearer, tying ADAPTER_BEARER to the declared credential key now that no probe include carries it. A new integration test renders the shared env template for every provider through Ansible's own templar, so a later change to it breaks visibly instead of poisoning twenty deploys quietly.
Hermes and OpenClaw keep their client-side proof as CLI tests of their own.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
35 lines
1.1 KiB
Bash
35 lines
1.1 KiB
Bash
#!/usr/bin/env bash
|
|
# Drive the MCP contract checker for one role's endpoint.
|
|
#
|
|
# It runs in the provider's own network because the endpoint is `expose:`-only:
|
|
# the service name resolves there and nowhere else. Running it on the stack
|
|
# host would reach nothing.
|
|
#
|
|
# Variables sourced from test.env.j2 by test-e2e-cli.
|
|
set -euo pipefail
|
|
|
|
: "${MCP_TEST_NETWORK:?}"
|
|
: "${MCP_TEST_IMAGE:?}"
|
|
: "${MCP_URL:?}"
|
|
: "${MCP_TRANSPORT:?}"
|
|
: "${MCP_AUTH_HEADER:?}"
|
|
: "${MCP_EXPECTED_TOOLS:?}"
|
|
: "${MCP_UPSTREAM_SERVES:?}"
|
|
: "${MCP_READ_ARGUMENTS:?}"
|
|
|
|
here="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
|
|
|
|
container run --rm -i \
|
|
--network "${MCP_TEST_NETWORK}" \
|
|
-e "MCP_URL=${MCP_URL}" \
|
|
-e "MCP_TRANSPORT=${MCP_TRANSPORT}" \
|
|
-e "MCP_PATH_KEY=${MCP_PATH_KEY}" \
|
|
-e "MCP_AUTH_HEADER=${MCP_AUTH_HEADER}" \
|
|
-e "MCP_EXPECTED_TOOLS=${MCP_EXPECTED_TOOLS}" \
|
|
-e "MCP_UPSTREAM_SERVES=${MCP_UPSTREAM_SERVES}" \
|
|
-e "MCP_READ_TOOL=${MCP_READ_TOOL}" \
|
|
-e "MCP_READ_ARGUMENTS=${MCP_READ_ARGUMENTS}" \
|
|
-e "MCP_HOST_HEADER=${MCP_HOST_HEADER}" \
|
|
"${MCP_TEST_IMAGE}" \
|
|
python3 - <"${here}/contract.py"
|