Files
computer-playbook/roles/sys-svc-container/files/shell/install-cli.sh
kevinveenbirkenbachandClaude Opus 5 575a5a87ac refactor(layout): sort shipped scripts by language and split the unit suite
Every script a role ships now lives under `files/<language>/`, and the unit
suite is split the same way: `tests/unit/python/` beside new sibling trees for
the other languages. `tests/lint/filesystem/test_role_files_layout.py` keeps it
that way; directories whose shape is dictated from outside carry a `.nocheck`
naming the constraint (Docker build contexts, WordPress mu-plugins, the Joomla
extension, Odoo addons, Playwright suites, the `files/test/test.sh` harness
that `test-e2e-cli` resolves generically).

This cannot be applied in halves. Moving a file and repointing what names it
are the same change: 14 references resolve only at deploy time, so the tree is
green either before or after, never between.

Those 14 were found by static resolution over every reference class, not by the
test suite -- a full `make quality-high` was green while all of them were
broken:

  * 7 `src:` values built from a role variable holding a bare filename
    (svc-bkp-remote-2-local, decidim, espocrm, friendica, joomla, pixelfed x2).
    The variable doubles as the destination name inside the container, so the
    language segment belongs at the call site, not in the variable.
  * `sys-service/tasks/04_base.yml` resolved every consumer's systemd script
    through `first_found(..., errors='strict')` over `files/script.{sh,py}`.
    18 roles ship exactly that and have no template fallback: the play would
    have died on each.
  * `sys-front-inj-javascript` fell back to `<role>/files/javascript.js`; the
    interface now reads `files/javascript/javascript.js`.
  * `sys-front-inj-logout/templates/head_sub.j2` built the cache-busting mtime
    path through `path_absolute(... 'files', ...)`.
  * 4 `ansible.builtin.script:` invocations naming a bare command
    (pull.py, prune.sh, set_postgres_superuser_password.sh, ganesha-serve.sh).
  * `dev-python/files/shell/install.sh` pointed at a sibling role's script.

Depth-dependent paths inside the moved trees were bumped accordingly: 59
`parents[N]` computations, 12 relative climbs, and the per-role recover CLI,
whose path `cli/administration/recover/recoverers.py` still assembled from the
pre-move location.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-22 01:31:09 +02:00

119 lines
4.1 KiB
Bash
Executable File

#!/usr/bin/env bash
set -euo pipefail
# shellcheck disable=SC1091
. /etc/os-release
REPO_ONLY=0
if [[ "${1:-}" == "--repo-only" ]]; then
REPO_ONLY=1
shift
fi
echo ">>> Installing docker client on ID=${ID} ID_LIKE=${ID_LIKE:-}"
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
DOCKER_APT_SANITIZER="${SCRIPT_DIR}/apt_repo.sh"
sanitize_docker_apt_sources() {
local distro_id="$1"
local keep_canonical="${2:-1}"
bash "${DOCKER_APT_SANITIZER}" sanitize-sources "${distro_id}" "${keep_canonical}" >/dev/null
}
ensure_docker_apt_key_and_sources() {
local distro_id="$1"
local keep_canonical="${2:-1}"
bash "${DOCKER_APT_SANITIZER}" ensure-key-and-sanitize "${distro_id}" "${keep_canonical}" >/dev/null
}
add_repo_rpm_compatible() {
local pm="$1"
local repo_url="$2"
local repo_file
repo_file="/etc/yum.repos.d/$(basename "${repo_url}")"
if [[ -s "${repo_file}" ]]; then
return 0
fi
if "${pm}" config-manager --add-repo "${repo_url}" >/dev/null 2>&1; then
return 0
fi
if "${pm}" config-manager addrepo --from-repofile="${repo_url}" >/dev/null 2>&1; then
return 0
fi
echo "[ERROR] Failed to add repo ${repo_url} via ${pm} config-manager" >&2
return 1
}
# shellcheck disable=SC2031
if [[ "${ID}" == "arch" || "${ID_LIKE:-}" =~ arch ]]; then
if [[ "${REPO_ONLY}" != "1" ]]; then
pacman-key --init
pacman -Syu --noconfirm --needed docker
fi
elif [[ "${ID}" == "debian" || "${ID}" == "ubuntu" || "${ID_LIKE:-}" =~ debian ]]; then
export DEBIAN_FRONTEND=noninteractive
sanitize_docker_apt_sources "${ID}" 0
if [[ "${ID}" == "ubuntu" ]]; then
mkdir -p /etc/apt/preferences.d
cat >/etc/apt/preferences.d/00-block-ubuntu-docker-compose-v2 <<'EOF'
Package: docker-compose-v2
Pin: release o=Ubuntu
Pin-Priority: -1
EOF
apt-get -y purge docker-compose-v2 >/dev/null 2>&1 || true # nocheck: shell-or-true -- grandfathered: worked in practice; TODO: sharpen to catch only the exact tolerated error
fi
apt-get update
apt-get install -y --no-install-recommends \
ca-certificates \
curl \
gnupg \
lsb-release
ensure_docker_apt_key_and_sources "${ID}" 1
# shellcheck disable=SC1091
echo "deb [arch=$(dpkg --print-architecture) signed-by=/etc/apt/keyrings/docker.asc] https://download.docker.com/linux/${ID} $(. /etc/os-release && echo "${VERSION_CODENAME}") stable" \
> /etc/apt/sources.list.d/docker.list
apt-get update
if [[ "${REPO_ONLY}" != "1" ]]; then
apt-get install -y --no-install-recommends \
docker-buildx-plugin \
docker-ce-cli \
docker-compose-plugin
fi
elif [[ "${ID}" == "fedora" ]]; then
dnf -y install dnf-plugins-core
add_repo_rpm_compatible dnf "https://download.docker.com/linux/fedora/docker-ce.repo"
if [[ "${REPO_ONLY}" == "1" ]]; then
dnf -y makecache
else
dnf -y install --allowerasing docker-ce-cli docker-buildx-plugin docker-compose-plugin
fi
elif [[ "${ID}" == "centos" || "${ID}" == "rhel" || "${ID_LIKE:-}" =~ (rhel|centos) ]]; then
if command -v dnf >/dev/null 2>&1; then PM=dnf; else PM=yum; fi
${PM} -y install yum-utils || true # nocheck: shell-or-true -- grandfathered: worked in practice; TODO: sharpen to catch only the exact tolerated error
${PM} -y install dnf-plugins-core || true # nocheck: shell-or-true -- grandfathered: worked in practice; TODO: sharpen to catch only the exact tolerated error
add_repo_rpm_compatible "${PM}" "https://download.docker.com/linux/centos/docker-ce.repo" || true # nocheck: shell-or-true -- grandfathered: worked in practice; TODO: sharpen to catch only the exact tolerated error
if [[ "${REPO_ONLY}" == "1" ]]; then
${PM} -y makecache || true # nocheck: shell-or-true -- grandfathered: worked in practice; TODO: sharpen to catch only the exact tolerated error
else
(${PM} -y install docker-ce-cli docker-buildx-plugin docker-compose-plugin) || \
(${PM} -y install docker-ce-cli) || \
(${PM} -y install docker) || true # nocheck: shell-or-true -- grandfathered: worked in practice; TODO: sharpen to catch only the exact tolerated error
fi
else
echo "[ERROR] Unsupported distro for docker client install: ID=${ID} ID_LIKE=${ID_LIKE:-}" >&2
exit 1
fi