mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-06 19:01:54 +00:00
kevinveenbirkenbachandClaude Opus 5
b3ce43a596
At -vvv Ansible prints each module argument and result, so a password in a command line, a request body, a header or a fact lands in the deploy log. Nothing enforced masking outside the MCP task files, and no check looked at parents at all. A new lint, test_credential_tasks_are_masked, finds tasks whose printed parts (module arguments, environment, loop) reference an identifier ending in password, secret, token, api_key or private_key, or secrets.credentials. A task passes when it or an enclosing block sets no_log, when every file that pulls it in does so through include_tasks with apply.no_log or import_tasks with no_log (transitively), when the secret only reaches a parameter the module masks itself, or when the module masks its values. no_log on an include_tasks task itself does not count, because it does not reach the included tasks. The rule can be suppressed per task with `# nocheck: credential-masking`, now listed in the suppression catalog, and the lint tests its parent and suppression logic on synthetic cases. It found 39 unmasked tasks in 19 roles, all real: join tokens, client secrets, API tokens in Cloudflare headers, database passwords in command lines, the ChatGPT bot login body and more. Each now sets no_log from MASK_CREDENTIALS_IN_LOGS. The sys-dns-hetzner-rdns alias hetzner_no_log, which only restated that switch, is gone. Not covered yet: template and copy tasks whose rendered file carries a secret print it as a diff under --diff. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
38 lines
1.2 KiB
YAML
38 lines
1.2 KiB
YAML
---
|
|
# run_once_sys_dns_hetzner_rdns
|
|
|
|
# Decide flavor
|
|
- name: 🤔 Decide which Hetzner flavor to use
|
|
set_fact:
|
|
_use_cloud: "{{ (HETZNER_API_TOKEN | length) > 0 }}"
|
|
_use_robot: >-
|
|
{{
|
|
(HETZNER_ROBOT_USER | length) > 0
|
|
and (HETZNER_ROBOT_PASSWORD | length) > 0
|
|
}}
|
|
no_log: "{{ MASK_CREDENTIALS_IN_LOGS | bool }}"
|
|
|
|
- name: "🔑 Note: both Cloud token and Robot creds provided; using Cloud flavor"
|
|
debug:
|
|
msg: "Both HETZNER_API_TOKEN and Robot credentials present → proceeding with Cloud (hcloud) flavor."
|
|
when: _use_cloud | bool and _use_robot | bool
|
|
|
|
- name: 📂 Include Cloud flavor (hcloud)
|
|
include_tasks: flavors/cloud.yml
|
|
when: _use_cloud | bool
|
|
|
|
- name: 📂 Include Robot flavor (Robot Webservice)
|
|
ansible.builtin.include_tasks:
|
|
file: flavors/robot.yml
|
|
apply:
|
|
no_log: "{{ MASK_CREDENTIALS_IN_LOGS | bool }}"
|
|
when: (not _use_cloud) and _use_robot
|
|
|
|
- name: 🛑 Fail if no credentials provided
|
|
fail:
|
|
msg: >-
|
|
Neither Cloud nor Robot credentials provided.
|
|
Set either HETZNER_API_TOKEN for Cloud (hcloud) or
|
|
HETZNER_ROBOT_USER/HETZNER_ROBOT_PASSWORD for Robot.
|
|
when: (not _use_cloud) and (not _use_robot)
|