mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-06 02:54:26 +00:00
kevinveenbirkenbachandClaude Opus 5
5324eadd8b
LITELLM_BACKEND_ROLES read lookup('deployment').groups, which deployment.py
fills from group_names. That variable is host-scoped: it lists only the groups
the host currently being processed belongs to.
On a swarm round the manager carries svc-ai-ollama, svc-ai-lmstudio and
svc-ai-litellm while the workers carry three groups and none of them is an AI
backend. Both branches of LITELLM_CHAT_MODEL therefore missed on a worker and,
with OPENROUTER_API_KEY empty, the model resolved to the empty string.
Only one task made that visible. Every stateful task in the gateway include
carries delegate_to STACK_HOST plus run_once, so it templates in the manager's
scope and wrote the correct model into the database. The assert carries
neither, so it re-templated in each worker's own scope and failed there while
the manager passed.
The manager-only membership is not a placement decision. The swarm test
inventory is provisioned with a single --host MGR, so every role of the round's
closure gets that one host, and extend_inventory then widens only
svc-swarm-node, svc-storage-nfs-client, svc-storage-nfs-server and the round's
own application. The three AI roles declare no placement at all; they are
manager-only because nothing widened them.
Add an inventory selector next to the host-scoped one, built from the play-wide
groups magic var, skipping groups without hosts and Ansible's implicit all and
ungrouped, sorted so the cache key is stable. The key takes it too, or two
hosts with equal group_names but different inventories would share an entry.
The blast radius is two readers, both in 16_ai.yml, and both ask only whether
svc-ai-ollama or svc-ai-lmstudio is present. On the manager the new value gains
exactly svc-storage-nfs-server and svc-bkp-nfs-2-local, neither of which either
reader tests, so the manager's answer does not move and only the workers change,
to match it.
This is the third step on the same line. 46a16127fc set .running; b149ad0d22
corrected that to .groups because a targeted apps= round leaves only the
command-line roles in the whitelist. .groups solves the targeted round and not
the multi-host one, because group_names stays host-scoped either way.
Measured in a two-host play with a real group_vars file and the real lookup:
the worker resolves ollama false through group_names and true through the new
selector, the manager is true both ways, and the assert that failed in CI
passes on both hosts.
Requirement 036 named the host-scoped backend selection as the thing that has
to change and deferred it. That residual is closed, so the paragraph now
describes the selector in use and why the two rejected ones are wrong.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
64 lines
1.9 KiB
Python
64 lines
1.9 KiB
Python
from __future__ import annotations
|
|
|
|
from typing import Any
|
|
|
|
from ansible.plugins.lookup import LookupBase
|
|
|
|
from utils.roles.validation.invokable import list_invokable_app_ids
|
|
|
|
_STATUS_CACHE: dict[tuple, dict[str, list[str]]] = {}
|
|
|
|
_EPHEMERAL_RUNTIMES = frozenset({"act", "github"})
|
|
|
|
_IMPLICIT_GROUPS = frozenset({"all", "ungrouped"})
|
|
|
|
|
|
def _reset_cache_for_tests() -> None:
|
|
_STATUS_CACHE.clear()
|
|
|
|
|
|
def _coerce_to_list(raw: Any) -> list[str]:
|
|
if raw is None:
|
|
return []
|
|
if isinstance(raw, str):
|
|
return [item.strip() for item in raw.split(",") if item.strip()]
|
|
return [str(item) for item in raw]
|
|
|
|
|
|
class LookupModule(LookupBase):
|
|
def run(
|
|
self,
|
|
terms: list[Any],
|
|
variables: dict[str, Any] | None = None,
|
|
**kwargs: Any,
|
|
) -> list[dict[str, list[str]]]:
|
|
vars_ = variables or getattr(self._templar, "available_variables", {}) or {}
|
|
|
|
whitelist = _coerce_to_list(vars_.get("APPLICATIONS_WHITELIST"))
|
|
groups = _coerce_to_list(vars_.get("group_names"))
|
|
inventory = sorted(
|
|
name
|
|
for name, hosts in (vars_.get("groups") or {}).items()
|
|
if hosts and name not in _IMPLICIT_GROUPS
|
|
)
|
|
runtime = str(vars_.get("RUNTIME", "")).strip().lower()
|
|
key = (tuple(whitelist), tuple(groups), tuple(inventory), runtime)
|
|
|
|
cached = _STATUS_CACHE.get(key)
|
|
if cached is not None:
|
|
return [cached]
|
|
|
|
running = whitelist or groups
|
|
deployed = list(running) if runtime in _EPHEMERAL_RUNTIMES else list(groups)
|
|
result = {
|
|
"whitelist": whitelist,
|
|
"running": list(running),
|
|
"groups": groups,
|
|
"inventory": inventory,
|
|
"deployed": deployed,
|
|
"runtime": runtime,
|
|
"all": list(list_invokable_app_ids()),
|
|
}
|
|
_STATUS_CACHE[key] = result
|
|
return [result]
|