mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-20 17:40:11 +00:00
fix(ci): clear the findings of the first quality-high pass
Four independent findings, each at its root. sys-svc-container: tasks/00_core/gpu.yml included 'nvidia.yml' by bare name, but the role is entered through tasks_from: 00_core.yml, so a relative include resolves against tasks/ instead of next to the including file. Every sibling include in 00_core.yml already carries the 00_core/ prefix. web-app-seaweedfs:c61b29bd16made services.seaweedfs.enabled and .shared literal and stated that the variant pin follows, but never touched meta/variants.yml. Both variants still repeated that literal, which variants-static-override counts as four offenders. They set exactly what the base declares, so they go. The base keeps the literal and regains the dynamic-flag marker the console split dropped ate8e89d293d: the flag's only job is joining the engine's shared_net, and its false branch yields a console container that cannot start, which the lint names as a legitimate exception. docs: the i8-tuner skill landed without its cheatsheet row, which the skills coverage guard reads as a missing skill. The remaining three files are that pass's own formatter output: quote normalisation in nvidia.yml and line wrapping in two test files. Not covered here: the two hallucinated URLs in locale/ko/LC_MESSAGES/docs.po, because a translation run is writing the catalogs. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
1 parent
b2ff696522
commit
bac30b76fa
7 files changed
+11
-15
No files matched your search
@@ -28,6 +28,7 @@ from its procedure file. Run `make install-skills` to (re)install them.
|
||||
| Running the quality gate (`make quality`) to green | `i8-quality` |
|
||||
| Running the full gate (`make quality-high`: quality plus every lint) to green | `i8-quality-high` |
|
||||
| Cleaning up code, docs, or roles after a change | `i8-refactor` |
|
||||
| Making CI, a deploy or a gate faster without giving up coverage | `i8-tuner` |
|
||||
| Checking a branch out into a parallel worktree | `i8-worktree-create` |
|
||||
| Releasing a parallel worktree and its slot | `i8-worktree-down` |
|
||||
| Freeing disk space and `/tmp` that agents filled | `i8-cleanup` |
|
||||
|
||||
@@ -20,4 +20,4 @@
|
||||
msg: "NVIDIA_VISIBLE_DEVICES={{ SYS_SVC_CONTAINER_GPU_DEVICES }}"
|
||||
|
||||
- name: "🎮 Let the container manager hand that GPU to its containers"
|
||||
include_tasks: nvidia.yml
|
||||
include_tasks: 00_core/nvidia.yml
|
||||
@@ -18,7 +18,7 @@
|
||||
- name: "🎮 Skip the cgroup setup nvidia-container-cli cannot own in a container"
|
||||
ansible.builtin.lineinfile:
|
||||
path: /etc/nvidia-container-runtime/config.toml
|
||||
regexp: '^#?\s*no-cgroups\s*='
|
||||
regexp: "^#?\\s*no-cgroups\\s*="
|
||||
line: "no-cgroups = true"
|
||||
owner: root
|
||||
group: root
|
||||
|
||||
@@ -3,6 +3,7 @@
|
||||
# the engine's shared_net (meta/networks.yml consumer key), and files/playwright/test-storage-buckets.js
|
||||
# already asserts every consumer bucket through the filer it serves.
|
||||
# nocheck: playwright-service-flag — engine provider, covered by the web-svc-seaweedfs CLI test
|
||||
# nocheck: dynamic-flag the flag's only job is joining the engine's shared_net, and its false branch yields a console container that cannot start
|
||||
seaweedfs:
|
||||
bond: 1
|
||||
enabled: true
|
||||
|
||||
@@ -1,8 +1,5 @@
|
||||
---
|
||||
- services:
|
||||
seaweedfs:
|
||||
enabled: true
|
||||
shared: true
|
||||
sso:
|
||||
enabled: "{{ 'svc-net-tor' not in group_names }}"
|
||||
shared: "{{ 'svc-net-tor' not in group_names }}"
|
||||
@@ -21,9 +18,6 @@
|
||||
tor:
|
||||
enabled: true
|
||||
- services:
|
||||
seaweedfs:
|
||||
enabled: true
|
||||
shared: true
|
||||
sso:
|
||||
enabled: false
|
||||
shared: false
|
||||
|
||||
@@ -53,13 +53,11 @@ def providers() -> dict[str, str]:
|
||||
|
||||
class TestTranslationBundleCoversEveryBackend(unittest.TestCase):
|
||||
def test_every_gated_backend_role_is_deployed_by_the_bundle(self) -> None:
|
||||
missing = {
|
||||
key: role
|
||||
for key, role in providers().items()
|
||||
if role not in BUNDLE
|
||||
}
|
||||
missing = {key: role for key, role in providers().items() if role not in BUNDLE}
|
||||
|
||||
report = "\n".join(f" - {key}: {role}" for key, role in sorted(missing.items()))
|
||||
report = "\n".join(
|
||||
f" - {key}: {role}" for key, role in sorted(missing.items())
|
||||
)
|
||||
self.assertFalse(
|
||||
missing,
|
||||
f"{len(missing)} backend(s) of {ROLE} are gated on a role that "
|
||||
|
||||
@@ -53,7 +53,9 @@ class FakeDecider:
|
||||
|
||||
|
||||
class FakeHistory:
|
||||
def __init__(self, tally=None, *, wins_raises=None, record_raises=None, speeds=None):
|
||||
def __init__(
|
||||
self, tally=None, *, wins_raises=None, record_raises=None, speeds=None
|
||||
):
|
||||
self._tally = tally or {}
|
||||
self._speeds = speeds or {}
|
||||
self.wins_raises = wins_raises
|
||||
|
||||
Reference in new issue
Block a user