mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-08 11:46:35 +00:00
fix(web-app-seaweedfs): the console always needs the engine network
The flag was a switch whose false branch produces a container that cannot start. run_after declares ordering, not a dependency, so the engine can genuinely be absent from the inventory, and without the flag the role stays out of the shared_net of the engine, nginx cannot resolve the seaweedfs upstream, and the console refuses to boot. Job 119003024087 of run 39530674125 shows it: the nginx config renders in 0.75s, then the play goes fatal on "Start the SeaweedFS console stack" with failed=1 after 796 ok. The flag has no second job. It exists only to join the network of the engine, as the marker above it still states, and nothing in the role reads it: vars/main.yml resolves services.seaweedfs.name and the two ports from the engine role through SEAWEEDFS_ENGINE_ID, and playwright.env.j2 reads the objstore structure instead. A literal true is therefore the honest declaration rather than a convenience. It also retires a lint suppression. With a literal value this is no longer a dynamic flag, so the variants-coverage rule stops demanding a false polarity that could never work, and the marker explaining why that polarity had no home goes with it. The fourteen variant checks pass without it. Variant 1 pinned the flag false and would have contradicted the declaration, so the pin follows. Deploying the console without the engine now fails while the network is being resolved, early and loud, instead of later with a container that will not start. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
1 parent
9569ac951b
commit
c61b29bd16
2 files changed
+4
-4
No files matched your search
@@ -5,8 +5,8 @@
|
||||
# nocheck: playwright-service-flag — engine provider, covered by the web-svc-seaweedfs CLI test
|
||||
seaweedfs:
|
||||
bond: 1
|
||||
enabled: "{{ 'web-svc-seaweedfs' in group_names }}"
|
||||
shared: "{{ 'web-svc-seaweedfs' in group_names }}"
|
||||
enabled: true
|
||||
shared: true
|
||||
# nocheck: variants-coverage the onion gate is a hard invariant; no variant may force this consumer on a tor node.
|
||||
# nocheck: bond-baseline same reason: variant 0 must not pin this consumer on.
|
||||
sso:
|
||||
|
||||
@@ -22,8 +22,8 @@
|
||||
enabled: true
|
||||
- services:
|
||||
seaweedfs:
|
||||
enabled: false
|
||||
shared: false
|
||||
enabled: true
|
||||
shared: true
|
||||
sso:
|
||||
enabled: false
|
||||
shared: false
|
||||
|
||||
Reference in new issue
Block a user