Kevin Veen-Birkenbach
6392131577
ruff 0.16 enables rules that earlier releases did not, so `ruff check .` was already failing on HEAD with 35 findings - the CI job installs ruff unpinned and would have gone red on the next push regardless of this branch. All changes are mechanical and behaviour-neutral: - Optional[X] -> X | None, List[str] -> list[str], dropped the now unused typing imports (every module already carries `from __future__ import annotations`, and requires-python is >= 3.10). - Sorted import blocks, `import automtu.x as x` -> `from automtu import x`. - subprocess.run in pmtu.py and wg.py now passes check=False explicitly. That is the parameter default, so the calls behave exactly as before. - int(round(x)) -> round(x): round() with a single argument already returns int. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
50 lines
1.8 KiB
Python
50 lines
1.8 KiB
Python
import unittest
|
|
from unittest.mock import patch
|
|
|
|
from automtu import docker
|
|
|
|
|
|
class TestDocker(unittest.TestCase):
|
|
def test_detect_docker_ifaces_explicit_dedup_and_drop_unknown(self) -> None:
|
|
# explicit args are repeatable and/or comma-separated
|
|
args = ["docker0,br-abc,unknown0", "br-abc,docker0"]
|
|
|
|
def fake_iface_exists(name: str) -> bool:
|
|
return name in {"docker0", "br-abc"} # unknown0 does not exist
|
|
|
|
with patch("automtu.docker.iface_exists", side_effect=fake_iface_exists):
|
|
got = docker.detect_docker_ifaces(args, include_user_bridges=True)
|
|
|
|
# preserve order, de-dup, drop unknown
|
|
self.assertEqual(got, ["docker0", "br-abc"])
|
|
|
|
def test_detect_docker_ifaces_auto_detect_docker0_only(self) -> None:
|
|
# no explicit args -> auto detect
|
|
def fake_iface_exists(name: str) -> bool:
|
|
return name == "docker0"
|
|
|
|
with patch("automtu.docker.iface_exists", side_effect=fake_iface_exists):
|
|
got = docker.detect_docker_ifaces(None, include_user_bridges=False)
|
|
|
|
self.assertEqual(got, ["docker0"])
|
|
|
|
def test_detect_docker_ifaces_auto_detect_includes_user_bridges(self) -> None:
|
|
# docker0 exists + br-* exists in list_ifaces -> included if include_user_bridges=True
|
|
def fake_iface_exists(name: str) -> bool:
|
|
return name in {"docker0", "br-abc"} # br-abc exists, br-nope does not
|
|
|
|
with (
|
|
patch("automtu.docker.iface_exists", side_effect=fake_iface_exists),
|
|
patch(
|
|
"automtu.docker.list_ifaces",
|
|
return_value=["lo", "eth0", "br-abc", "br-nope", "wg0"],
|
|
),
|
|
):
|
|
got = docker.detect_docker_ifaces(None, include_user_bridges=True)
|
|
|
|
self.assertEqual(got, ["docker0", "br-abc"])
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main(verbosity=2)
|