kevinveenbirkenbach/linux-image-manager
1
0
Fork 0
mirror of https://github.com/kevinveenbirkenbach/linux-image-manager.git synced 2024-11-22 15:11:04 +01:00
Code Issues Packages Projects Releases Wiki Activity

Optimized shellcheck hints

Browse Source
This commit is contained in:
Kevin Veen-Birkenbach 2020-06-12 11:07:57 +02:00
parent f51eaa12e6
commit b1cee3a6e1
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
scripts/base.sh
View File

@ -3,6 +3,10 @@
# This script contains the global program variables and functions # This script contains the global program variables and functions
# #
# shellcheck disable=SC2034 #Deactivate checking of unused variables # shellcheck disable=SC2034 #Deactivate checking of unused variables
# shellcheck disable=SC2003 #Deactivate "expr is antiquated"
# shellcheck disable=SC2015 #Deactivate bool hint
# shellcheck disable=SC2005 #Remove useless echo hint
# shellcheck disable=SC2010 #Deactivate ls | grep hint
REPOSITORY_PATH=$(readlink -f "$(dirname "$(readlink -f "${0}")")/../../") # Propably this can be optimized REPOSITORY_PATH=$(readlink -f "$(dirname "$(readlink -f "${0}")")/../../") # Propably this can be optimized
CONFIGURATION_PATH="$REPOSITORY_PATH""/configuration/" CONFIGURATION_PATH="$REPOSITORY_PATH""/configuration/"
@ -76,7 +80,7 @@ set_device_path(){
error "$device_path is not valid device." error "$device_path is not valid device."
fi fi
# @see https://www.heise.de/ct/hotline/Optimale-Blockgroesse-fuer-dd-2056768.html # @see https://www.heise.de/ct/hotline/Optimale-Blockgroesse-fuer-dd-2056768.html
OPTIMAL_BLOCKSIZE=$(expr 64 \* "$(sudo cat /sys/block/$device/queue/physical_block_size)") && OPTIMAL_BLOCKSIZE=$(expr 64 \* "$(sudo cat /sys/block/"$device"/queue/physical_block_size)") &&
info "Device path set to: $device_path" && info "Device path set to: $device_path" &&
info "Optimal blocksize set to: $OPTIMAL_BLOCKSIZE" || info "Optimal blocksize set to: $OPTIMAL_BLOCKSIZE" ||
error error

1
scripts/image/base.sh
View File

@ -6,6 +6,7 @@
# shellcheck disable=SC2010 # ls | grep allowed # shellcheck disable=SC2010 # ls | grep allowed
# shellcheck source=/dev/null # Deactivate SC1090 # shellcheck source=/dev/null # Deactivate SC1090
# shellcheck disable=SC2015 # Deactivate bools hints # shellcheck disable=SC2015 # Deactivate bools hints
# shellcheck disable=SC2154 # Deactivate referenced but not assigned hints
source "$(dirname "$(readlink -f "${0}")")/../base.sh" || (echo "Loading base.sh failed." && exit 1) source "$(dirname "$(readlink -f "${0}")")/../base.sh" || (echo "Loading base.sh failed." && exit 1)
# Writes the full partition name # Writes the full partition name