Optimized replace logic for oc

This commit is contained in:
2025-06-27 16:26:12 +02:00
parent c04f02e92a
commit 147fbacb93
2 changed files with 33 additions and 13 deletions

30
main.py
View File

@@ -198,20 +198,23 @@ def main():
encoded = ocdef.encode()
try:
result = conn.search_s(schema_dn, ldap.SCOPE_BASE,
attrlist=['olcObjectClasses'])
attrlist=['olcObjectClasses'])
existing = result[0][1].get('olcObjectClasses', [])
if encoded in existing:
print(f" ObjectClass already exists, replacing (DELETE + ADD): {ocdef}")
mods = [
(ldap.MOD_DELETE, 'olcObjectClasses', [encoded]),
(ldap.MOD_ADD, 'olcObjectClasses', [encoded])
]
try:
conn.modify_s(schema_dn, mods)
print(f"🔄 Replaced ObjectClass: {ocdef}")
except ldap.LDAPError as e:
print(f"❌ LDAP error replacing ObjectClass '{ocdef}': {e}")
sys.exit(2)
norm_existing = [normalize(v) for v in existing]
norm_encoded = normalize(encoded)
if norm_encoded in norm_existing:
print(f"✅ ObjectClass already up to date: {ocdef}")
continue
elif any(extract_oid(oc.decode()) == extract_oid(ocdef) for oc in existing):
print(f"⚠️ ObjectClass with same OID exists, replacing...")
to_delete = [oc for oc in existing if extract_oid(oc.decode()) == extract_oid(ocdef)]
for oc in to_delete:
conn.modify_s(schema_dn, [(ldap.MOD_DELETE, 'olcObjectClasses', [oc])])
conn.modify_s(schema_dn, [(ldap.MOD_ADD, 'olcObjectClasses', [encoded])])
print(f"🔄 Replaced ObjectClass: {ocdef}")
else:
conn.modify_s(schema_dn, [
(ldap.MOD_ADD, 'olcObjectClasses', [encoded])
@@ -221,6 +224,7 @@ def main():
print(f"❌ LDAP error for ObjectClass '{ocdef}': {e}", file=sys.stderr)
sys.exit(3)
conn.unbind_s()
if __name__ == '__main__':