Optimized SourceMembershipInformation

This commit is contained in:
Kevin Frantz
2018-12-30 17:09:44 +01:00
parent beb6cb3e90
commit e30145d792
4 changed files with 37 additions and 11 deletions

View File

@@ -32,8 +32,7 @@ final class SourceMemberInformation implements SourceMemberInformationInterface
foreach ($members as $member) {
if (!$this->members->contains($member->getSource())) {
$this->members->add($member->getSource());
$memberMembers = $member->getMembers();
$this->itterateOverMembers($memberMembers);
$this->itterateOverMembers($member->getMembers());
}
}
}

View File

@@ -5,6 +5,7 @@ namespace App\Domain\SourceManagement;
use Doctrine\Common\Collections\Collection;
use App\Entity\Source\SourceInterface;
use Doctrine\Common\Collections\ArrayCollection;
use App\Entity\Meta\Relation\Member\MemberRelationInterface;
final class SourceMembershipInformation implements SourceMembershipInformationInterface
{
@@ -23,16 +24,24 @@ final class SourceMembershipInformation implements SourceMembershipInformationIn
$this->source = $source;
}
/**
* @param Collection|MemberRelationInterface[] $memberships
*/
private function itterateOverMemberships(Collection $memberships): void
{
foreach ($memberships as $membership) {
if (!$this->memberships->contains($membership)) {
$this->memberships->add($membership);
$this->itterateOverMemberships($membership->getMemberRelation()->getMemberships());
if (!$this->memberships->contains($membership->getSource())) {
$this->memberships->add($membership->getSource());
$this->itterateOverMemberships($membership->getMemberships());
}
}
}
/**
* {@inheritdoc}
*
* @see \App\Domain\SourceManagement\SourceMembershipInformationInterface::getAllMemberships()
*/
public function getAllMemberships(): Collection
{
$this->memberships = new ArrayCollection();