Code optimation by PHP-Code Sniffer

This commit is contained in:
2020-04-02 21:13:35 +02:00
parent 725ca5b149
commit ac5a3f1d5a
314 changed files with 665 additions and 1688 deletions

View File

@@ -60,19 +60,11 @@ class AttributIntegrationTest extends TestCase
return $interface->isInterface();
}
/**
* @param \ReflectionClass $interface
*
* @return string
*/
private function getTraitName(\ReflectionClass $interface): string
{
return substr($interface->getName(), 0, -strlen(self::INTERFACE_SUFFIX));
}
/**
* @param \ReflectionClass $interface
*/
private function validateHasTrait(\ReflectionClass $interface): void
{
$interfaceName = $interface->getName();
@@ -80,9 +72,6 @@ class AttributIntegrationTest extends TestCase
$this->assertTrue(trait_exists($trait), "Trait <<$trait>> for interface <<$interfaceName>> MUST exist!");
}
/**
* @param \ReflectionClass $trait
*/
private function validateHasInterface(\ReflectionClass $trait): void
{
$traitName = $trait->getName();
@@ -90,21 +79,11 @@ class AttributIntegrationTest extends TestCase
$this->assertTrue(interface_exists($interface), "Interface <<$interface>> for trait <<$traitName>> does not exist!");
}
/**
* @param \ReflectionClass $interface
*
* @return string
*/
private function getAttributName(\ReflectionClass $interface): string
{
return substr($interface->getShortName(), 0, -strlen(self::CONCAT_INTERFACE_SUFFIX));
}
/**
* @param \ReflectionClass $interface
*
* @return string
*/
private function getConstantName(\ReflectionClass $interface): string
{
$name = strtoupper($this->getAttributName($interface));
@@ -112,9 +91,6 @@ class AttributIntegrationTest extends TestCase
return $name.'_ATTRIBUT_NAME';
}
/**
* @param \ReflectionClass $interface
*/
private function validateConstants(\ReflectionClass $interface): void
{
$constants = $interface->getConstants();
@@ -125,9 +101,6 @@ class AttributIntegrationTest extends TestCase
}
}
/**
* @param \ReflectionClass $interface
*/
private function validateMethods(\ReflectionClass $interface): void
{
$methods = get_class_methods($interface->getName());
@@ -141,11 +114,6 @@ class AttributIntegrationTest extends TestCase
}
}
/**
* @param \ReflectionClass $interface
*
* @return array
*/
private function getNeccessaryMethods(\ReflectionClass $interface): array
{
$possibleMethods = [];
@@ -157,11 +125,6 @@ class AttributIntegrationTest extends TestCase
return $possibleMethods;
}
/**
* @param \ReflectionClass $interface
*
* @return array
*/
private function getPossibleMethods(\ReflectionClass $interface): array
{
$possibleMethods = [];
@@ -173,11 +136,6 @@ class AttributIntegrationTest extends TestCase
return $possibleMethods;
}
/**
* @param string $file
*
* @return \ReflectionClass
*/
private function getReflectionClass(string $file): \ReflectionClass
{
$shortName = substr($file, 0, -strlen('.php'));
@@ -186,9 +144,6 @@ class AttributIntegrationTest extends TestCase
return new \ReflectionClass($name);
}
/**
* @param \ReflectionClass $interface
*/
private function validateTraitSchema(\ReflectionClass $interface): void
{
$trait = $this->getTraitName($interface);

View File

@@ -2,13 +2,13 @@
namespace Tests\Integration\Controller;
use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
use Infinito\DBAL\Types\ActionType;
use Infinito\DBAL\Types\Meta\Right\LayerType;
use Infinito\DBAL\Types\RESTResponseType;
use Symfony\Component\HttpFoundation\Request;
use Infinito\Domain\Layer\LayerActionMap;
use Infinito\DBAL\Types\ActionType;
use Infinito\Domain\Map\ActionHttpMethodMap;
use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
/**
@@ -60,10 +60,6 @@ class RestRoutesReachableIntegrationTest extends KernelTestCase
}
}
/**
* @param string $url
* @param string $method
*/
private function routeAssert(string $url, string $method): void
{
$request = new Request([], [], [], [], [], [
@@ -74,11 +70,6 @@ class RestRoutesReachableIntegrationTest extends KernelTestCase
$this->assertTrue($this->isResponseValid($response), "Route $url with Method $method sends an 404 response and doesn't throw an EntityNotFoundException!");
}
/**
* @param Response $response
*
* @return bool
*/
private function isResponseValid(Response $response): bool
{
$is404 = 404 === $response->getStatusCode();

View File

@@ -2,12 +2,12 @@
namespace Tests\Integration\DataFixtures;
use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
use Doctrine\ORM\EntityManager;
use Infinito\Domain\Fixture\FixtureSource\GuestUserFixtureSource;
use Infinito\Domain\Fixture\FixtureSource\ImpressumFixtureSource;
use Infinito\Entity\Source\AbstractSource;
use Infinito\Entity\Source\Complex\UserSourceInterface;
use Infinito\Domain\Fixture\FixtureSource\ImpressumFixtureSource;
use Infinito\Domain\Fixture\FixtureSource\GuestUserFixtureSource;
use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
class SourceFixturesIntegrationTest extends KernelTestCase
{

View File

@@ -2,18 +2,18 @@
namespace tests\Unit\Domain\AccessDataManagement;
use PHPUnit\Framework\TestCase;
use Infinito\DBAL\Types\ActionType;
use Infinito\Domain\DataAccess\ActionsViewsDAOServiceInterface;
use Infinito\Domain\DataAccess\ActionsResultsDAOService;
use Infinito\Domain\DataAccess\ActionsViewsDAOService;
use Infinito\Entity\EntityInterface;
use Infinito\Logic\Result\ResultInterface;
use Infinito\Domain\DataAccess\ActionsViewsDAOServiceInterface;
use Infinito\Domain\Form\RequestedActionFormBuilderServiceInterface;
use Infinito\Exception\Type\InvalidChoiceTypeException;
use Infinito\Exception\Collection\NotSetElementException;
use Infinito\Entity\EntityInterface;
use Infinito\Exception\Collection\ContainsElementException;
use Infinito\Exception\Collection\NotSetElementException;
use Infinito\Exception\Type\InvalidChoiceTypeException;
use Infinito\Exception\Validation\ValueInvalidException;
use Infinito\Logic\Result\ResultInterface;
use PHPUnit\Framework\TestCase;
/**
* @author kevinfrantz
@@ -89,10 +89,6 @@ class ActionViewsDAOServiceIntegrationTest extends TestCase
/**
* @todo implement test!
*
* @param string $actionType
*
* @return string
*/
private function getActionTypeViewDataMock(string $actionType): string
{

View File

@@ -2,13 +2,13 @@
namespace tests\Integration\Domain\Action;
use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
use Infinito\Domain\Action\ActionHandlerServiceInterface;
use Infinito\Domain\Request\Action\RequestedActionServiceInterface;
use Infinito\Domain\Fixture\FixtureSource\ImpressumFixtureSource;
use Infinito\Entity\Source\SourceInterface;
use Infinito\DBAL\Types\ActionType;
use Infinito\DBAL\Types\Meta\Right\LayerType;
use Infinito\Domain\Action\ActionHandlerServiceInterface;
use Infinito\Domain\Fixture\FixtureSource\ImpressumFixtureSource;
use Infinito\Domain\Request\Action\RequestedActionServiceInterface;
use Infinito\Entity\Source\SourceInterface;
use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
/**
* @author kevinfrantz

View File

@@ -2,9 +2,9 @@
namespace tests\Integration\Domain\Action;
use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
use Infinito\Domain\Action\ActionDependenciesDAOServiceInterface;
use Doctrine\ORM\EntityManagerInterface;
use Infinito\Domain\Action\ActionDependenciesDAOServiceInterface;
use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
/**
* @author kevinfrantz

View File

@@ -2,14 +2,14 @@
namespace tests\Integration\Domain\Fixture;
use PHPUnit\Framework\TestCase;
use Infinito\Entity\Source\AbstractSource;
use Infinito\Domain\Fixture\EntityTemplateFactory;
use Infinito\Entity\Source\Complex\UserSource;
use Infinito\Entity\Meta\Right;
use Infinito\DBAL\Types\Meta\Right\LayerType;
use Infinito\DBAL\Types\ActionType;
use Infinito\DBAL\Types\Meta\Right\LayerType;
use Infinito\Domain\Fixture\EntityTemplateFactory;
use Infinito\Domain\Law\LawPermissionChecker;
use Infinito\Entity\Meta\Right;
use Infinito\Entity\Source\AbstractSource;
use Infinito\Entity\Source\Complex\UserSource;
use PHPUnit\Framework\TestCase;
/**
* @author kevinfrantz

View File

@@ -2,10 +2,10 @@
namespace tests\Integration\Domain\Fixture;
use PHPUnit\Framework\TestCase;
use Infinito\Domain\Fixture\FixtureSourceFactory;
use Infinito\Domain\Fixture\FixtureSource\FixtureSourceInterface;
use Infinito\Domain\Fixture\FixtureSourceFactory;
use Infinito\Entity\Source\SourceInterface;
use PHPUnit\Framework\TestCase;
/**
* @author kevinfrantz

View File

@@ -2,9 +2,9 @@
namespace tests\Integration\Domain\Fixture;
use Infinito\Domain\Fixture\FixtureSource\ImpressumFixtureSource;
use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
use Symfony\Component\HttpFoundation\Request;
use Infinito\Domain\Fixture\FixtureSource\ImpressumFixtureSource;
/**
* @author kevinfrantz

View File

@@ -2,16 +2,16 @@
namespace tests\Integration\Domain\Form;
use Symfony\Component\Form\FormBuilderInterface;
use Infinito\Domain\Request\Entity\RequestedEntityInterface;
use Infinito\Entity\Source\PureSource;
use Infinito\Domain\Form\RequestedActionFormBuilderService;
use Infinito\Domain\Request\Action\RequestedActionServiceInterface;
use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
use Infinito\DBAL\Types\ActionType;
use Symfony\Component\Form\Form;
use Infinito\Domain\Form\RequestedActionFormBuilderService;
use Infinito\Domain\Form\RequestedActionFormBuilderServiceInterface;
use Infinito\Domain\Request\Action\RequestedActionServiceInterface;
use Infinito\Domain\Request\Entity\RequestedEntityInterface;
use Infinito\Domain\Request\Entity\RequestedEntityServiceInterface;
use Infinito\Entity\Source\PureSource;
use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
use Symfony\Component\Form\Form;
use Symfony\Component\Form\FormBuilderInterface;
/**
* @author kevinfrantz

View File

@@ -2,9 +2,9 @@
namespace tests\Integration\Domain\Parameter\Parameter;
use Infinito\Domain\Parameter\Parameter\VersionParameter;
use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
use Symfony\Component\Validator\Validator\ValidatorInterface;
use Infinito\Domain\Parameter\Parameter\VersionParameter;
/**
* @author kevinfrantz

View File

@@ -2,10 +2,10 @@
namespace tests\Integration\Domain\Parameter\Parameter;
use Infinito\DBAL\Types\ActionType;
use Infinito\Domain\Parameter\Parameter\ViewParameter;
use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
use Symfony\Component\Validator\Validator\ValidatorInterface;
use Infinito\Domain\Parameter\Parameter\ViewParameter;
use Infinito\DBAL\Types\ActionType;
/**
* @author kevinfrantz

View File

@@ -2,18 +2,18 @@
namespace tests\Integration\Domain\Parameter;
use Infinito\Domain\Parameter\Parameter\VersionParameter;
use Infinito\Domain\Parameter\ParameterFactory;
use Infinito\Domain\Parameter\ParameterFactoryInterface;
use Infinito\Domain\Parameter\ValidGetParameterServiceInterface;
use Infinito\Domain\Parameter\ValidGetParametersService;
use Infinito\Exception\Collection\NotSetElementException;
use Infinito\Exception\Core\NotImplementedCoreException;
use Infinito\Exception\Validation\GetParameterInvalidException;
use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\RequestStack;
use Symfony\Component\Validator\Validator\ValidatorInterface;
use Infinito\Domain\Parameter\ValidGetParameterServiceInterface;
use Infinito\Domain\Parameter\Parameter\VersionParameter;
use Infinito\Domain\Parameter\ParameterFactoryInterface;
use Infinito\Exception\Validation\GetParameterInvalidException;
use Infinito\Exception\Collection\NotSetElementException;
use Infinito\Exception\Core\NotImplementedCoreException;
/**
* @author kevinfrantz

View File

@@ -2,10 +2,10 @@
namespace tests\Integration\Domain\Request\Right;
use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
use Infinito\Domain\Repository\LayerRepositoryFactoryServiceInterface;
use Infinito\DBAL\Types\Meta\Right\LayerType;
use Infinito\Domain\Repository\LayerRepositoryFactoryServiceInterface;
use Infinito\Repository\Meta\LawRepository;
use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
/**
* @author kevinfrantz

View File

@@ -2,10 +2,10 @@
namespace tests\Integration\Domain\Request\Action;
use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
use Infinito\Domain\Request\Action\RequestedActionServiceInterface;
use Infinito\DBAL\Types\ActionType;
use Infinito\Domain\Request\Action\RequestedActionServiceInterface;
use Infinito\Domain\Request\Entity\LazyRequestedEntity;
use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
/**
* @author kevinfrantz

View File

@@ -2,9 +2,9 @@
namespace tests\Integration\Domain\Request\Entity;
use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
use Infinito\Domain\Request\Entity\RequestedEntityServiceInterface;
use Infinito\Entity\Source\AbstractSource;
use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
/**
* @author kevinfrantz

View File

@@ -2,9 +2,9 @@
namespace tests\Integration\Domain\Request\Right;
use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
use Infinito\Domain\Request\Right\RequestedRightServiceInterface;
use Infinito\DBAL\Types\Meta\Right\CRUDType;
use Infinito\Domain\Request\Right\RequestedRightServiceInterface;
use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
/**
* @author kevinfrantz

View File

@@ -2,9 +2,9 @@
namespace tests\Integration\Domain\Request\Right;
use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
use Infinito\DBAL\Types\Meta\Right\CRUDType;
use Infinito\Domain\Request\User\RequestedUserServiceInterface;
use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
/**
* @author kevinfrantz

View File

@@ -2,14 +2,14 @@
namespace tests\Integration\Domain\Secure;
use Infinito\Entity\Source\AbstractSource;
use Infinito\DBAL\Types\Meta\Right\LayerType;
use Infinito\DBAL\Types\Meta\Right\CRUDType;
use Infinito\Entity\Meta\Right;
use Infinito\Domain\Request\Right\RequestedRight;
use Infinito\DBAL\Types\Meta\Right\LayerType;
use Infinito\Domain\Request\Entity\RequestedEntityInterface;
use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
use Infinito\Domain\Request\Right\RequestedRight;
use Infinito\Domain\Secure\SecureRequestedRightCheckerServiceInterface;
use Infinito\Entity\Meta\Right;
use Infinito\Entity\Source\AbstractSource;
use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
/**
* @author kevinfrantz

View File

@@ -2,13 +2,13 @@
namespace Tests\Integration\Domain\Source;
use PHPUnit\Framework\TestCase;
use Infinito\Entity\Source\SourceInterface;
use Infinito\Domain\Source\SourceMemberManagerInterface;
use Infinito\Domain\Source\SourceMemberManager;
use Infinito\Domain\Source\SourceMemberInformation;
use Infinito\Domain\Source\SourceMemberManager;
use Infinito\Domain\Source\SourceMemberManagerInterface;
use Infinito\Domain\Source\SourceMembershipInformation;
use Infinito\Entity\Source\PureSource;
use Infinito\Entity\Source\SourceInterface;
use PHPUnit\Framework\TestCase;
class SourceMemberManagerIntegrationTest extends TestCase
{

View File

@@ -2,9 +2,9 @@
namespace tests\Integration\Domain\User;
use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
use Infinito\Domain\User\UserSourceDirectorServiceInterface;
use Infinito\Entity\UserInterface;
use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
/**
* @author kevinfrantz

View File

@@ -3,10 +3,10 @@
namespace Integration\Entity\Source;
use Doctrine\ORM\EntityManagerInterface;
use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
use Infinito\Repository\Source\SourceRepository;
use Infinito\Entity\Source\PureSourceInterface;
use Infinito\Entity\Source\PureSource;
use Infinito\Entity\Source\PureSourceInterface;
use Infinito\Repository\Source\SourceRepository;
use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
/**
* @author kevinfrantz

View File

@@ -2,8 +2,8 @@
namespace Tests\Integration\Entity\Source;
use PHPUnit\Framework\TestCase;
use Doctrine\Common\Collections\ArrayCollection;
use PHPUnit\Framework\TestCase;
/**
* This class tests if all needed Depencies for a source are implemented!
@@ -22,9 +22,6 @@ class SourceIntegrationTest extends TestCase
*/
protected $sources;
/**
* @param string $path
*/
private function iterate(string $path): void
{
$directoryIterator = new \DirectoryIterator($path);
@@ -55,11 +52,6 @@ class SourceIntegrationTest extends TestCase
$this->iterate(self::SOURCE_DIRECTORY);
}
/**
* @param string $path
*
* @return string
*/
private function filterSourcePath(string $path): string
{
$path = str_replace('/Abstract', '/', $path);
@@ -68,11 +60,6 @@ class SourceIntegrationTest extends TestCase
return $path;
}
/**
* @param string $path
*
* @return string
*/
private function getInterfacePath(string $path): string
{
return $this->filterSourcePath($path).'Interface.php';

View File

@@ -2,15 +2,15 @@
namespace tests\Integration\Repository\Meta;
use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
use Doctrine\ORM\EntityManagerInterface;
use Doctrine\ORM\EntityRepository;
use Infinito\Entity\Meta\RightInterface;
use Infinito\Entity\Meta\Right;
use Infinito\DBAL\Types\Meta\Right\LayerType;
use Infinito\DBAL\Types\Meta\Right\CRUDType;
use Infinito\DBAL\Types\Meta\Right\LayerType;
use Infinito\Entity\Meta\Law;
use Infinito\Entity\Meta\LawInterface;
use Doctrine\ORM\EntityManagerInterface;
use Infinito\Entity\Meta\Right;
use Infinito\Entity\Meta\RightInterface;
use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
/**
* @todo specify tests for all attributes

View File

@@ -2,19 +2,19 @@
namespace Tests\Integration\Entity\Subscriber;
use Symfony\Component\Translation\Translator;
use Infinito\Domain\Fixture\FixtureSource\GuestUserFixtureSource;
use Infinito\Entity\User;
use Infinito\Event\Menu\MenuEvent;
use Symfony\Component\HttpFoundation\RequestStack;
use Symfony\Component\HttpFoundation\Request;
use Knp\Menu\MenuItem;
use Knp\Menu\MenuFactory;
use Infinito\Subscriber\UserMenuSubscriber;
use Knp\Menu\MenuFactory;
use Knp\Menu\MenuItem;
use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\RequestStack;
use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;
use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
use Symfony\Component\Security\Core\Role\Role;
use Infinito\Domain\Fixture\FixtureSource\GuestUserFixtureSource;
use Infinito\Entity\User;
use Symfony\Component\Translation\Translator;
/**
* @author kevinfrantz