kevinveenbirkenbach/infinito
1
0
Fork 0
mirror of https://github.com/kevinveenbirkenbach/infinito.git synced 2025-10-31 17:29:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

Optimized Actions, Tests and renamed LIST to THREAD out of php incompatibility reasons

Browse Source
This commit is contained in:
Kevin Frantz
2019-01-27 20:28:31 +01:00
parent c2d0c5f60d
commit 81dd63c152
12 changed files with 95 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
application/symfony/src/DBAL/Types/ActionType.php
View File

@@ -11,13 +11,13 @@ use App\DBAL\Types\Meta\Right\CRUDType;
*/
final class ActionType extends CRUDType
{
const LIST = 'list';
const THREAD = 'thread';
protected static $choices = [
parent::CREATE => 'create',
parent::READ => 'read',
parent::UPDATE => 'update',
parent::DELETE => 'delete',
self::LIST => 'list',
self::THREAD => 'thread',
];
}

11
application/symfony/src/Domain/ActionManagement/Create/AbstractCreateAction.php
View File

@@ -7,6 +7,15 @@ use App\Domain\ActionManagement\AbstractAction;
/**
* @author kevinfrantz
*/
abstract class AbstractCreateAction extends AbstractAction
abstract class AbstractCreateAction extends AbstractAction implements CreateActionInterface
{
/**
* {@inheritdoc}
*
* @see \App\Domain\ActionManagement\AbstractAction::isSecure()
*/
protected function isSecure(): bool
{
return $this->actionService->isRequestedActionSecure();
}
}

12
application/symfony/src/Domain/ActionManagement/Create/CreateActionInterface.php Normal file
View File

@@ -0,0 +1,12 @@
<?php
namespace App\Domain\ActionManagement\Create;
use App\Domain\ActionManagement\ActionInterface;
/**
* @author kevinfrantz
*/
interface CreateActionInterface extends ActionInterface
{
}

4
application/symfony/src/Domain/ActionManagement/Create/CreateSourceAction.php
View File

@@ -7,10 +7,6 @@ namespace App\Domain\ActionManagement\Create;
*/
final class CreateSourceAction extends AbstractCreateAction
{
protected function isSecure(): bool
{
}
protected function isValidByForm(): bool
{
}

12
application/symfony/src/Domain/ActionManagement/Thread/AbstractThreadAction.php Normal file
View File

@@ -0,0 +1,12 @@
<?php
namespace App\Domain\ActionManagement\Thread;
use App\Domain\ActionManagement\AbstractAction;
/**
* @author kevinfrantz
*/
abstract class AbstractThreadAction extends AbstractAction
{
}

26
application/symfony/src/Domain/ActionManagement/Thread/ThreadSourceAction.php Normal file
View File

@@ -0,0 +1,26 @@
<?php
namespace App\Domain\ActionManagement\Thread;
/**
* @author kevinfrantz
*/
final class ThreadSourceAction extends AbstractThreadAction
{
/**
* {@inheritdoc}
*
* @see \App\Domain\ActionManagement\AbstractAction::isSecure()
*/
protected function isSecure(): bool
{
}
protected function isValidByForm(): bool
{
}
protected function proccess()
{
}
}

12
application/symfony/src/Domain/ActionManagement/Update/AbstractUpdateAction.php Normal file
View File

@@ -0,0 +1,12 @@
<?php
namespace App\Domain\ActionManagement\Update;
use App\Domain\ActionManagement\AbstractAction;
/**
* @author kevinfrantz
*/
abstract class AbstractUpdateAction extends AbstractAction
{
}

16
application/symfony/src/Domain/ActionManagement/Update/UpdateSourceAction.php
View File

@@ -2,6 +2,20 @@
namespace App\Domain\ActionManagement\Update;
class UpdateSourceAction
/**
* @author kevinfrantz
*/
final class UpdateSourceAction extends AbstractUpdateAction
{
protected function isSecure(): bool
{
}
protected function isValidByForm(): bool
{
}
protected function proccess()
{
}
}

2
application/symfony/src/Domain/LayerManagement/LayerActionMap.php
View File

@@ -19,7 +19,7 @@ final class LayerActionMap implements LayerActionMapInterface
ActionType::CREATE,
ActionType::UPDATE,
ActionType::DELETE,
ActionType::LIST,
ActionType::THREAD,
],
];

2
application/symfony/src/Domain/RequestManagement/Action/RequestedAction.php
View File

@@ -23,7 +23,7 @@ class RequestedAction extends RequestedUser implements RequestedActionInterface
* @var array Containes the mapping of non standard actions to a crud
*/
const ACTION_CRUD_MAP = [
ActionType::LIST => CRUDType::READ,
ActionType::THREAD => CRUDType::READ,
];
/**

7
application/symfony/tests/Unit/Domain/ActionManagement/ActionFactoryServiceTest.php
View File

@@ -2,16 +2,15 @@
namespace tests\Unit\Domain\SecureCRUDManagement\Factory;
use App\DBAL\Types\Meta\Right\LayerType;
use PHPUnit\Framework\TestCase;
use App\Domain\ActionManagement\ActionFactoryServiceInterface;
use App\Domain\ActionManagement\ActionFactoryService;
use App\Domain\ActionManagement\ActionServiceInterface;
use App\DBAL\Types\ActionType;
use App\Domain\ActionManagement\ActionInterface;
use App\Domain\RequestManagement\Action\RequestedActionInterface;
use App\Domain\RequestManagement\Action\RequestedAction;
use App\Domain\RequestManagement\Right\RequestedRight;
use App\Domain\LayerManagement\LayerActionMap;
/**
* @author kevinfrantz
@@ -44,8 +43,8 @@ class ActionFactoryServiceTest extends TestCase
public function testCreate(): void
{
foreach (ActionType::getChoices() as $action) {
foreach (LayerType::getChoices() as $layer) {
foreach (LayerActionMap::LAYER_ACTION_MAP as $layer => $actions) {
foreach ($actions as $action) {
$this->requestedAction->setLayer($layer);
$this->requestedAction->setActionType($action);
$result = $this->actionFactoryService->create();

2
application/symfony/tests/Unit/Domain/RequestManagement/Action/RequestedActionTest.php
View File

@@ -41,7 +41,7 @@ class RequestedActionTest extends TestCase
public function testList(): void
{
$list = ActionType::LIST;
$list = ActionType::THREAD;
$this->action->setActionType($list);
$this->assertEquals($list, $this->action->getActionType());
$this->assertEquals(CRUDType::READ, $this->requestedRight->getCrud());