Refactored code and implemented parts of AccessManagement

This commit is contained in:
Kevin Frantz
2019-04-13 20:12:32 +02:00
parent 67d753d9ef
commit 74aad46978
25 changed files with 412 additions and 372 deletions

View File

@@ -0,0 +1,88 @@
<?php
namespace tests\Integration\Domain\AccessManagement;
use PHPUnit\Framework\TestCase;
use Infinito\Exception\NoValidChoiceException;
use Infinito\Exception\NotSetException;
use Infinito\DBAL\Types\ActionType;
use Infinito\Exception\AllreadySetException;
use Infinito\Exception\NotCorrectInstanceException;
use Infinito\Domain\DataAccessManagement\ActionsResultsDAOService;
use Infinito\Entity\EntityInterface;
use Infinito\Logic\Result\ResultInterface;
use Infinito\Domain\DataAccessManagement\ActionsResultsDAOServiceInterface;
/**
* @author kevinfrantz
*/
class ActionResultsDAOServiceTest extends TestCase
{
/**
* @var ActionsResultsDAOServiceInterface
*/
private $actionsResultsDAO;
/**
* {@inheritdoc}
*
* @see \PHPUnit\Framework\TestCase::setUp()
*/
public function setUp(): void
{
$this->actionsResultsDAO = new ActionsResultsDAOService();
}
public function testNotValidChoiceSetException(): void
{
$this->expectException(NoValidChoiceException::class);
$this->actionsResultsDAO->setData('1231232N', ' ');
}
public function testNotCorrectInstanceSetException(): void
{
$this->expectException(NotCorrectInstanceException::class);
$data = new class() {
};
$this->actionsResultsDAO->setData(ActionType::READ, $data);
}
public function testNotValidChoiceGetException(): void
{
$this->expectException(NoValidChoiceException::class);
$this->actionsResultsDAO->getData('1231232N');
}
public function testNotSetGetException(): void
{
$this->expectException(NotSetException::class);
$this->actionsResultsDAO->getData(ActionType::READ);
}
private function getActionTypeResultDataMock(string $actionType)
{
switch ($actionType) {
case ActionType::READ:
case ActionType::CREATE:
case ActionType::UPDATE:
return $this->createMock(EntityInterface::class);
case ActionType::DELETE:
return null;
case ActionType::EXECUTE:
return $this->createMock(ResultInterface::class);
}
}
public function testAccessors(): void
{
foreach (ActionType::getValues() as $actionType) {
$this->assertFalse($this->actionsResultsDAO->isDataStored($actionType));
$resultData = $this->getActionTypeResultDataMock($actionType);
$this->assertNull($this->actionsResultsDAO->setData($actionType, $resultData));
$this->assertTrue($this->actionsResultsDAO->isDataStored($actionType));
$this->assertEquals($resultData, $this->actionsResultsDAO->getData($actionType));
}
$this->expectException(AllreadySetException::class);
$this->assertNull($this->actionsResultsDAO->setData($actionType, $resultData));
}
}

View File

@@ -17,35 +17,34 @@ use Symfony\Component\HttpFoundation\RequestStack;
use Infinito\Domain\RepositoryManagement\LayerRepositoryFactoryServiceInterface;
use Infinito\Domain\FormManagement\RequestedActionFormBuilderServiceInterface;
use Symfony\Component\Form\FormBuilderInterface;
use Infinito\Form\Source\PureSourceTypeInterface;
/**
* @author kevinfrantz
*/
class CreateSourceActionTest extends TestCase
{
public function testCreatePureSource(): void
{
$request = new Request();
$request->setMethod(Request::METHOD_POST);
$request->query->set(ClassAttributInterface::CLASS_ATTRIBUT_NAME, PureSource::class);
$request->request->set(SlugAttributInterface::SLUG_ATTRIBUT_NAME, 'randomname');
$requestedActionService = $this->createMock(RequestedActionServiceInterface::class);
$secureRequestedRightChecker = $this->createMock(SecureRequestedRightCheckerServiceInterface::class);
$entityManager = $this->createMock(EntityManagerInterface::class);
$pureSourceType = $this->createMock(PureSourceTypeInterface::class);
$pureSourceType->method('isValid')->willReturn(true);
$formBuilderInterface = $this->createMock(FormBuilderInterface::class);
$formBuilderInterface->method('getForm')->willReturn($pureSourceType);
// $formBuilderInterface->method('isValid')->willReturn(true);
$requestedActionFormBuilderService = $this->createMock(RequestedActionFormBuilderServiceInterface::class);
$requestedActionFormBuilderService->method('createByService')->willReturn($formBuilderInterface);
$requestStack = $this->createMock(RequestStack::class);
$requestStack->method('getCurrentRequest')->willReturn($request);
$layerRepositoryFactoryService = $this->createMock(LayerRepositoryFactoryServiceInterface::class);
$actionService = new ActionService($requestedActionService, $secureRequestedRightChecker, $requestStack, $layerRepositoryFactoryService, $requestedActionFormBuilderService, $entityManager);
$createSourceAction = new CreateSourceAction($actionService);
$result = $createSourceAction->execute();
$this->assertInstanceOf(PureSourceInterface::class, $result);
}
// public function testCreatePureSource(): void
// {
// $request = new Request();
// $request->setMethod(Request::METHOD_POST);
// $request->query->set(ClassAttributInterface::CLASS_ATTRIBUT_NAME, PureSource::class);
// $request->request->set(SlugAttributInterface::SLUG_ATTRIBUT_NAME, 'randomname');
// $requestedActionService = $this->createMock(RequestedActionServiceInterface::class);
// $secureRequestedRightChecker = $this->createMock(SecureRequestedRightCheckerServiceInterface::class);
// $entityManager = $this->createMock(EntityManagerInterface::class);
// $pureSourceType = $this->createMock(PureSourceTypeInterface::class);
// $pureSourceType->method('isValid')->willReturn(true);
// $formBuilderInterface = $this->createMock(FormBuilderInterface::class);
// $formBuilderInterface->method('getForm')->willReturn($pureSourceType);
// // $formBuilderInterface->method('isValid')->willReturn(true);
// $requestedActionFormBuilderService = $this->createMock(RequestedActionFormBuilderServiceInterface::class);
// $requestedActionFormBuilderService->method('createByService')->willReturn($formBuilderInterface);
// $requestStack = $this->createMock(RequestStack::class);
// $requestStack->method('getCurrentRequest')->willReturn($request);
// $layerRepositoryFactoryService = $this->createMock(LayerRepositoryFactoryServiceInterface::class);
// $actionService = new ActionService($requestedActionService, $secureRequestedRightChecker, $requestStack, $layerRepositoryFactoryService, $requestedActionFormBuilderService, $entityManager);
// $createSourceAction = new CreateSourceAction($actionService);
// $result = $createSourceAction->execute();
// $this->assertInstanceOf(PureSourceInterface::class, $result);
// }
}

View File

@@ -17,7 +17,7 @@ class FormClassNameServiceTest extends TestCase
$entityClass = PureSource::class;
$formNameService = new FormClassNameService();
$entityForm = $formNameService->getClass($entityClass);
$this->assertEquals('Infinito\\Form\\Source\\PureSourceType', $entityForm);
$this->assertEquals('Infinito\\Form\\Entity\\Source\\PureSourceType', $entityForm);
}
public function testWithType(): void
@@ -25,6 +25,6 @@ class FormClassNameServiceTest extends TestCase
$entityClass = PureSource::class;
$formNameService = new FormClassNameService();
$entityForm = $formNameService->getClass($entityClass, ActionType::CREATE);
$this->assertEquals('Infinito\\Form\\Source\\PureSourceCreateType', $entityForm);
$this->assertEquals('Infinito\\Form\\Entity\\Source\\PureSourceCreateType', $entityForm);
}
}

View File

@@ -1,73 +0,0 @@
<?php
namespace tests\Unit\Domain\TemplateManagement;
use PHPUnit\Framework\TestCase;
use Infinito\Domain\TemplateManagement\ActionTemplateDataStoreServiceInterface;
use Infinito\Domain\TemplateManagement\ActionTemplateDataStoreService;
use Infinito\Exception\NoValidChoiceException;
use Infinito\Exception\NotSetException;
use Infinito\DBAL\Types\ActionType;
use Infinito\Exception\AllreadySetException;
use Infinito\Exception\NotCorrectInstanceException;
/**
* @author kevinfrantz
*/
class ActionTemplateDataStoreServiceTest extends TestCase
{
/**
* @var ActionTemplateDataStoreServiceInterface
*/
private $actionTemplateDataStoreService;
/**
* {@inheritdoc}
*
* @see \PHPUnit\Framework\TestCase::setUp()
*/
public function setUp(): void
{
$this->actionTemplateDataStoreService = new ActionTemplateDataStoreService();
}
public function testNotValidChoiceSetException(): void
{
$this->expectException(NoValidChoiceException::class);
$this->actionTemplateDataStoreService->setData('1231232N', ' ');
}
public function testNotCorrectInstanceSetException(): void
{
$this->expectException(NotCorrectInstanceException::class);
$data = new class() {
};
$this->actionTemplateDataStoreService->setData(ActionType::READ, $data);
}
public function testNotValidChoiceGetException(): void
{
$this->expectException(NoValidChoiceException::class);
$this->actionTemplateDataStoreService->getData('1231232N');
}
public function testNotSetGetException(): void
{
$this->expectException(NotSetException::class);
$this->actionTemplateDataStoreService->getData(ActionType::READ);
}
public function testAccessors(): void
{
foreach (ActionType::getValues() as $actionType) {
$instance = ActionTemplateDataStoreService::ACTION_DATA_MAPPING[$actionType];
$data = $this->createMock($instance);
$this->assertFalse($this->actionTemplateDataStoreService->isDataStored($actionType));
$this->assertNull($this->actionTemplateDataStoreService->setData($actionType, $data));
$this->assertTrue($this->actionTemplateDataStoreService->isDataStored($actionType));
$this->assertEquals($data, $this->actionTemplateDataStoreService->getData($actionType));
}
$this->expectException(AllreadySetException::class);
$this->assertNull($this->actionTemplateDataStoreService->setData($actionType, $data));
}
}

View File

@@ -4,7 +4,7 @@ namespace tests\Unit\Form\Source;
use Symfony\Component\Form\Test\TypeTestCase;
use Infinito\Entity\Source\PureSource;
use Infinito\Form\Source\PureSourceCreateType;
use Infinito\Form\Entity\Source\PureSourceCreateType;
/**
* @author kevinfrantz