Formated code

This commit is contained in:
Kevin Frantz 2019-03-28 19:15:24 +01:00
parent a931d7aebc
commit 6fb99c2f1a
3 changed files with 37 additions and 38 deletions

View File

@ -1,24 +1,20 @@
<?php <?php
namespace Infinito\Domain\ParameterManagement; namespace Infinito\Domain\ParameterManagement;
use Infinito\Domain\ParameterManagement\Parameter\ParameterInterface; use Infinito\Domain\ParameterManagement\Parameter\ParameterInterface;
use HaydenPierce\ClassFinder\ClassFinder; use HaydenPierce\ClassFinder\ClassFinder;
use Doctrine\Common\Collections\ArrayCollection; use Doctrine\Common\Collections\ArrayCollection;
use PhpCollection\CollectionInterface; use PhpCollection\CollectionInterface;
use Doctrine\Migrations\Configuration\Exception\ParameterIncompatibleWithFinder;
use PhpParser\ErrorHandler\Collecting;
use Doctrine\Common\Collections\Collection; use Doctrine\Common\Collections\Collection;
use Infinito\Domain\ParameterManagement\Parameter\AbstractParameter; use Infinito\Domain\ParameterManagement\Parameter\AbstractParameter;
/** /**
*
* @author kevinfrantz * @author kevinfrantz
*
*/ */
final class ParameterFactory implements ParameterFactoryInterface final class ParameterFactory implements ParameterFactoryInterface
{ {
/** /**
*
* @var string Namespace under which the parameters are stored * @var string Namespace under which the parameters are stored
*/ */
const PARAMETER_NAMESPACE = 'Infinito\Domain\ParameterManagement\Parameter'; const PARAMETER_NAMESPACE = 'Infinito\Domain\ParameterManagement\Parameter';
@ -28,17 +24,21 @@ final class ParameterFactory implements ParameterFactoryInterface
*/ */
private $parameters; private $parameters;
private function initPossible(string $class){ private function initPossible(string $class)
if($class === AbstractParameter::class){ {
if (AbstractParameter::class === $class) {
return false; return false;
} }
$reflectionClass = new \ReflectionClass($class); $reflectionClass = new \ReflectionClass($class);
if ($reflectionClass->isInterface()) { if ($reflectionClass->isInterface()) {
return false; return false;
} }
return true; return true;
} }
private function initParameters():void{
private function initParameters(): void
{
$this->parameters = new ArrayCollection(); $this->parameters = new ArrayCollection();
$classFinder = new ClassFinder(); $classFinder = new ClassFinder();
$parameterClasses = $classFinder->getClassesInNamespace(self::PARAMETER_NAMESPACE); $parameterClasses = $classFinder->getClassesInNamespace(self::PARAMETER_NAMESPACE);
@ -50,13 +50,14 @@ final class ParameterFactory implements ParameterFactoryInterface
} }
} }
public function __construct(){ public function __construct()
{
$this->initParameters(); $this->initParameters();
} }
/** /**
* {@inheritdoc}
* *
* {@inheritDoc}
* @see \Infinito\Domain\ParameterManagement\ParameterFactoryInterface::getParameter() * @see \Infinito\Domain\ParameterManagement\ParameterFactoryInterface::getParameter()
*/ */
public function getParameter(string $key): ParameterInterface public function getParameter(string $key): ParameterInterface
@ -65,11 +66,12 @@ final class ParameterFactory implements ParameterFactoryInterface
} }
/** /**
* {@inheritDoc} * {@inheritdoc}
*
* @see \Infinito\Domain\ParameterManagement\ParameterFactoryInterface::getAllParameters() * @see \Infinito\Domain\ParameterManagement\ParameterFactoryInterface::getAllParameters()
*/ */
public function getAllParameters():Collection{ public function getAllParameters(): Collection
{
return $this->parameters; return $this->parameters;
} }
} }

View File

@ -1,4 +1,5 @@
<?php <?php
namespace Infinito\Domain\ParameterManagement; namespace Infinito\Domain\ParameterManagement;
use Infinito\Domain\ParameterManagement\Parameter\ParameterInterface; use Infinito\Domain\ParameterManagement\Parameter\ParameterInterface;
@ -6,10 +7,9 @@ use Doctrine\Common\Collections\Collection;
interface ParameterFactoryInterface interface ParameterFactoryInterface
{ {
/** /**
*
* @param string $key * @param string $key
*
* @return ParameterInterface * @return ParameterInterface
*/ */
public function getParameter(string $key): ParameterInterface; public function getParameter(string $key): ParameterInterface;
@ -19,4 +19,3 @@ interface ParameterFactoryInterface
*/ */
public function getAllParameters(): Collection; public function getAllParameters(): Collection;
} }

View File

@ -1,19 +1,18 @@
<?php <?php
namespace tests\Unit\Domain\ParameterManagement;
namespace tests\Unit\Domain\ParameterManagement;
use PHPUnit\Framework\TestCase; use PHPUnit\Framework\TestCase;
use Infinito\Domain\ParameterManagement\ParameterFactory; use Infinito\Domain\ParameterManagement\ParameterFactory;
use Infinito\Domain\ParameterManagement\Parameter\VersionParameter; use Infinito\Domain\ParameterManagement\Parameter\VersionParameter;
/** /**
*
* @author kevinfrantz * @author kevinfrantz
*
*/ */
class ParameterFactoryTest extends TestCase class ParameterFactoryTest extends TestCase
{ {
public function testAllParameters():void{ public function testAllParameters(): void
{
$parameterFactory = new ParameterFactory(); $parameterFactory = new ParameterFactory();
$allParameters = $parameterFactory->getAllParameters(); $allParameters = $parameterFactory->getAllParameters();
var_dump($allParameters); var_dump($allParameters);
@ -22,4 +21,3 @@ class ParameterFactoryTest extends TestCase
$this->assertEquals($versionParameter, $parameterFactory->getParameter('version')); $this->assertEquals($versionParameter, $parameterFactory->getParameter('version'));
} }
} }