Optimized ParameterManagement

application/symfony/tests/Unit/Domain/ParameterManagement/OptionalGetParameterServiceTest.php

@@ -1,65 +0,0 @@
-<?php
-
-namespace tests\Unit\Domain\ParameterManagement;
-
-use PHPUnit\Framework\TestCase;
-use Symfony\Component\HttpFoundation\Request;
-use Symfony\Component\HttpFoundation\RequestStack;
-use Infinito\Domain\ParameterManagement\OptionalGetParameterServiceInterface;
-use Infinito\Domain\ParameterManagement\OptionalGetParameterService;
-use Infinito\Exception\UnvalidParameterException;
-use Infinito\Exception\NotDefinedException;
-
-/**
- * @author kevinfrantz
- */
-class OptionalGetParameterServiceTest extends TestCase
-{
-    /**
-     * @var Request
-     */
-    private $currentRequest;
-
-    /**
-     * @var RequestStack
-     */
-    private $requestStack;
-
-    /**
-     * @var OptionalGetParameterServiceInterface
-     */
-    private $optionalGetParameterService;
-
-    public function setUp(): void
-    {
-        $this->currentRequest = new Request();
-        $this->requestStack = $this->createMock(RequestStack::class);
-        $this->requestStack->method('getCurrentRequest')->willReturn($this->currentRequest);
-        $this->optionalGetParameterService = new OptionalGetParameterService($this->requestStack);
-    }
-
-    public function testConstructor(): void
-    {
-        $this->expectException(UnvalidParameterException::class);
-        $this->currentRequest->query->set('asdwgwe', 'adasa');
-        new OptionalGetParameterService($this->requestStack);
-    }
-
-    public function testHasAndGetParameter(): void
-    {
-        foreach (OptionalGetParameterServiceInterface::OPTIONAL_PARAMETERS as $key) {
-            $this->assertFalse($this->optionalGetParameterService->hasParameter($key));
-            $this->currentRequest->query->set($key, 'adasa');
-            $this->assertTrue($this->optionalGetParameterService->hasParameter($key));
-            $this->assertEquals('adasa', $this->optionalGetParameterService->getParameter($key));
-        }
-        $this->expectException(UnvalidParameterException::class);
-        $this->optionalGetParameterService->getParameter('12312312asdas');
-    }
-
-    public function testSetParameterException(): void
-    {
-        $this->expectException(NotDefinedException::class);
-        $this->optionalGetParameterService->getParameter(OptionalGetParameterServiceInterface::VERSION_PARAMETER);
-    }
-}

application/symfony/tests/Unit/Domain/ParameterManagement/ValidGetParameterServiceTest.php

@@ -0,0 +1,73 @@
+<?php
+
+namespace tests\Unit\Domain\ParameterManagement;
+
+use Symfony\Component\HttpFoundation\Request;
+use Symfony\Component\HttpFoundation\RequestStack;
+use Infinito\Domain\ParameterManagement\OptionalGetParameterServiceInterface;
+use Infinito\Exception\NotDefinedException;
+use Infinito\Domain\ParameterManagement\Parameter\VersionParameter;
+use Infinito\Domain\ParameterManagement\ParameterFactory;
+use Infinito\Domain\ParameterManagement\ValidGetParametersService;
+use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
+use Symfony\Component\Validator\Validator\ValidatorInterface;
+
+/**
+ * This class is a bit messed up because it is an recycled class of an other unit.
+ *
+ * @author kevinfrantz
+ */
+class ValidGetParameterServiceTest extends KernelTestCase
+{
+    /**
+     * @var Request
+     */
+    private $currentRequest;
+
+    /**
+     * @var RequestStack
+     */
+    private $requestStack;
+
+    /**
+     * @var OptionalGetParameterServiceInterface
+     */
+    private $validGetParameterService;
+
+    public function setUp(): void
+    {
+        $this->currentRequest = new Request();
+        $this->requestStack = $this->createMock(RequestStack::class);
+        $this->requestStack->method('getCurrentRequest')->willReturn($this->currentRequest);
+        $parameterFactory = new ParameterFactory();
+        self::bootKernel();
+        $validator = self::$container->get(ValidatorInterface::class);
+        $this->validGetParameterService = new ValidGetParametersService($this->requestStack, $parameterFactory, $validator);
+    }
+
+    public function testHasAndGetParameter(): void
+    {
+        $parameterFactory = new ParameterFactory();
+        foreach ($parameterFactory->getAllParameters()->getKeys() as $key) {
+            $this->assertFalse($this->validGetParameterService->hasParameter($key));
+            switch ($key) {
+                case VersionParameter::getKey():
+                    $value = 1;
+                    break;
+                default:
+                    $value = true;
+            }
+            $this->currentRequest->query->set($key, $value);
+            $this->assertTrue($this->validGetParameterService->hasParameter($key));
+            $this->assertEquals($value, $this->validGetParameterService->getParameter($key));
+        }
+        $this->expectException(NotDefinedException::class);
+        $this->validGetParameterService->getParameter('12312312asdas');
+    }
+
+    public function testSetParameterException(): void
+    {
+        $this->expectException(NotDefinedException::class);
+        $this->validGetParameterService->getParameter(VersionParameter::getKey());
+    }
+}