kevinveenbirkenbach/infinito
1
0
Fork 0
mirror of https://github.com/kevinveenbirkenbach/infinito.git synced 2025-09-13 05:47:11 +02:00
Code Issues Packages Projects Releases Wiki Activity

Optimized ParameterManagement

Browse Source
This commit is contained in:
Kevin Frantz
2019-03-28 23:51:24 +01:00
parent d2baca0822
commit 62f953c706
10 changed files with 111 additions and 93 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
application/symfony/tests/Integration/Domain/ParameterManagement/ValidGetParameterServiceTest.php
View File

@@ -1,6 +1,6 @@
<?php
namespace tests\Unit\Domain\ParameterManagement;
namespace tests\Integration\Domain\ParameterManagement;
use Infinito\Domain\ParameterManagement\ParameterFactory;
use Infinito\Domain\ParameterManagement\ValidGetParametersService;
@@ -74,7 +74,7 @@ class ValidGetParameterServiceTest extends KernelTestCase
public function testConstructor(): void
{
$this->expectException(UnvalidParameterException::class);
$this->expectException(NotDefinedException::class);
$this->currentRequest->query->set('asdwgwe', 'adasa');
new ValidGetParametersService($this->requestStack, $this->parameterFactory, $this->validator);
}

65
application/symfony/tests/Unit/Domain/ParameterManagement/OptionalGetParameterServiceTest.php
View File

@@ -1,65 +0,0 @@
<?php
namespace tests\Unit\Domain\ParameterManagement;
use PHPUnit\Framework\TestCase;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\RequestStack;
use Infinito\Domain\ParameterManagement\OptionalGetParameterServiceInterface;
use Infinito\Domain\ParameterManagement\OptionalGetParameterService;
use Infinito\Exception\UnvalidParameterException;
use Infinito\Exception\NotDefinedException;
/**
* @author kevinfrantz
*/
class OptionalGetParameterServiceTest extends TestCase
{
/**
* @var Request
*/
private $currentRequest;
/**
* @var RequestStack
*/
private $requestStack;
/**
* @var OptionalGetParameterServiceInterface
*/
private $optionalGetParameterService;
public function setUp(): void
{
$this->currentRequest = new Request();
$this->requestStack = $this->createMock(RequestStack::class);
$this->requestStack->method('getCurrentRequest')->willReturn($this->currentRequest);
$this->optionalGetParameterService = new OptionalGetParameterService($this->requestStack);
}
public function testConstructor(): void
{
$this->expectException(UnvalidParameterException::class);
$this->currentRequest->query->set('asdwgwe', 'adasa');
new OptionalGetParameterService($this->requestStack);
}
public function testHasAndGetParameter(): void
{
foreach (OptionalGetParameterServiceInterface::OPTIONAL_PARAMETERS as $key) {
$this->assertFalse($this->optionalGetParameterService->hasParameter($key));
$this->currentRequest->query->set($key, 'adasa');
$this->assertTrue($this->optionalGetParameterService->hasParameter($key));
$this->assertEquals('adasa', $this->optionalGetParameterService->getParameter($key));
}
$this->expectException(UnvalidParameterException::class);
$this->optionalGetParameterService->getParameter('12312312asdas');
}
public function testSetParameterException(): void
{
$this->expectException(NotDefinedException::class);
$this->optionalGetParameterService->getParameter(OptionalGetParameterServiceInterface::VERSION_PARAMETER);
}
}

73
application/symfony/tests/Unit/Domain/ParameterManagement/ValidGetParameterServiceTest.php Normal file
View File

@@ -0,0 +1,73 @@
<?php
namespace tests\Unit\Domain\ParameterManagement;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\RequestStack;
use Infinito\Domain\ParameterManagement\OptionalGetParameterServiceInterface;
use Infinito\Exception\NotDefinedException;
use Infinito\Domain\ParameterManagement\Parameter\VersionParameter;
use Infinito\Domain\ParameterManagement\ParameterFactory;
use Infinito\Domain\ParameterManagement\ValidGetParametersService;
use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
use Symfony\Component\Validator\Validator\ValidatorInterface;
/**
* This class is a bit messed up because it is an recycled class of an other unit.
*
* @author kevinfrantz
*/
class ValidGetParameterServiceTest extends KernelTestCase
{
/**
* @var Request
*/
private $currentRequest;
/**
* @var RequestStack
*/
private $requestStack;
/**
* @var OptionalGetParameterServiceInterface
*/
private $validGetParameterService;
public function setUp(): void
{
$this->currentRequest = new Request();
$this->requestStack = $this->createMock(RequestStack::class);
$this->requestStack->method('getCurrentRequest')->willReturn($this->currentRequest);
$parameterFactory = new ParameterFactory();
self::bootKernel();
$validator = self::$container->get(ValidatorInterface::class);
$this->validGetParameterService = new ValidGetParametersService($this->requestStack, $parameterFactory, $validator);
}
public function testHasAndGetParameter(): void
{
$parameterFactory = new ParameterFactory();
foreach ($parameterFactory->getAllParameters()->getKeys() as $key) {
$this->assertFalse($this->validGetParameterService->hasParameter($key));
switch ($key) {
case VersionParameter::getKey():
$value = 1;
break;
default:
$value = true;
}
$this->currentRequest->query->set($key, $value);
$this->assertTrue($this->validGetParameterService->hasParameter($key));
$this->assertEquals($value, $this->validGetParameterService->getParameter($key));
}
$this->expectException(NotDefinedException::class);
$this->validGetParameterService->getParameter('12312312asdas');
}
public function testSetParameterException(): void
{
$this->expectException(NotDefinedException::class);
$this->validGetParameterService->getParameter(VersionParameter::getKey());
}
}