Reduced complexity of constructor

This commit is contained in:
Kevin Frantz
2019-02-13 15:29:29 +01:00
parent 0ab4cee064
commit 54b0d98ef3
9 changed files with 22 additions and 23 deletions

View File

@@ -52,7 +52,7 @@ class CreateSourceActionIntegrationTest extends KernelTestCase
$userSourceDirectorService = new UserSourceDirectorService($entityManager, $security);
$requestedRightService = new RequestedRightService();
$requestedUserService = new RequestedUserService($userSourceDirectorService, $requestedRightService);
$this->requestedActionService = new RequestedActionService($userSourceDirectorService, $requestedUserService);
$this->requestedActionService = new RequestedActionService($requestedUserService);
$this->requestedActionService->setActionType(ActionType::CREATE);
$entityFormBuilderService = $this->createMock(RequestedActionFormBuilderServiceInterface::class);
$requestStack = $this->createMock(RequestStack::class);

View File

@@ -57,7 +57,7 @@ class RequestedActionFormBuilderServiceIntegrationTest extends KernelTestCase
$requestedRightService = new RequestedRightService();
$requestedRightService->setRequestedEntity($this->requestedEntity);
$requestedUserService = new RequestedUserService($userSourceDirectorService, $requestedRightService);
$this->requestedActionService = new RequestedActionService($userSourceDirectorService, $requestedUserService);
$this->requestedActionService = new RequestedActionService($requestedUserService);
$this->requestedActionService->setActionType(ActionType::CREATE);
$this->requestedActionFormBuilderService = new RequestedActionFormBuilderService($formFactory, $formClassNameService, $this->requestedActionService);
}

View File

@@ -39,7 +39,7 @@ class ActionFactoryServiceTest extends TestCase
$requestedRight = new RequestedRight();
$userSourceDirector = $this->createMock(UserSourceDirectorInterface::class);
$requestedUser = new RequestedUser($userSourceDirector, $requestedRight);
$this->requestedAction = new RequestedAction($userSourceDirector, $requestedUser);
$this->requestedAction = new RequestedAction($requestedUser);
$this->actionService = $this->createMock(ActionServiceInterface::class);
$this->actionService->method('getRequestedAction')->willReturn($this->requestedAction);
$this->actionFactoryService = new ActionFactoryService($this->actionService);

View File

@@ -17,7 +17,8 @@ class RequestedActionServiceTest extends TestCase
{
$userSourceDirector = $this->createMock(UserSourceDirectorInterface::class);
$requestedUserService = $this->createMock(RequestedUserServiceInterface::class);
$service = new RequestedActionService($userSourceDirector, $requestedUserService);
$requestedUserService->method('getUserSourceDirector')->willReturn($userSourceDirector);
$service = new RequestedActionService($requestedUserService);
$this->assertInstanceOf(RequestedActionServiceInterface::class, $service);
}
}

View File

@@ -44,7 +44,7 @@ class RequestedActionTest extends TestCase
$userSourceDirector = new UserSourceDirector($sourceRepository, $user);
$requestedRight = new RequestedRight();
$this->requestedRight = new RequestedUser($userSourceDirector, $requestedRight);
$this->action = new RequestedAction($userSourceDirector, $this->requestedRight);
$this->action = new RequestedAction($this->requestedRight);
}
public function testList(): void