Optimized documentation and class naming

This commit is contained in:
Kevin Frantz
2019-01-19 22:52:49 +01:00
parent 71c7a7f080
commit 4b86acb372
24 changed files with 195 additions and 41 deletions

View File

@@ -3,8 +3,8 @@
namespace Unit\Domain\LawManagement;
use PHPUnit\Framework\TestCase;
use App\Domain\LawManagement\LawPermissionCheckerService;
use App\Domain\LawManagement\LawPermissionCheckerServiceInterface;
use App\Domain\LawManagement\LawPermissionChecker;
use App\Domain\LawManagement\LawPermissionCheckerInterface;
use App\Entity\Source\SourceInterface;
use App\Entity\Meta\Right;
use App\DBAL\Types\Meta\Right\LayerType;
@@ -22,7 +22,7 @@ use App\Entity\Source\PureSource;
class LawPermissionCheckerTest extends TestCase
{
/**
* @var LawPermissionCheckerServiceInterface The service which checks the law
* @var LawPermissionCheckerInterface The service which checks the law
*/
private $lawPermissionChecker;
@@ -62,7 +62,7 @@ class LawPermissionCheckerTest extends TestCase
private function setLawPermissionChecker(): void
{
$this->lawPermissionChecker = new LawPermissionCheckerService($this->law);
$this->lawPermissionChecker = new LawPermissionChecker($this->law);
}
private function setLawDummy(): void

View File

@@ -6,13 +6,13 @@ use PHPUnit\Framework\TestCase;
use App\Entity\Source\Complex\Collection\TreeCollectionSource;
use App\Entity\Source\SourceInterface;
use Doctrine\Common\Collections\ArrayCollection;
use App\Domain\SourceManagement\TreeSourceServiceInterface;
use App\Domain\SourceManagement\TreeSourceService;
use App\Domain\SourceManagement\TreeSourceInformationInterface;
use App\Domain\SourceManagement\TreeSourceInformation;
class TreeSourceServiceTest extends TestCase
class TreeSourceInformationTest extends TestCase
{
/**
* @var TreeSourceServiceInterface
* @var TreeSourceInformationInterface
*/
protected $treeService;
@@ -31,7 +31,7 @@ class TreeSourceServiceTest extends TestCase
$tree2->setCollection(new ArrayCollection([$leave3, $leave4, $tree5, $leave5]));
$collection = new ArrayCollection([$tree2, $tree3, $leave1, $leave2, $tree4, $tree1]);
$tree1->setCollection($collection);
$this->treeService = new TreeSourceService($tree1);
$this->treeService = new TreeSourceInformation($tree1);
}
public function testGetLeaves(): void