Optimized ParameterManagement

This commit is contained in:
Kevin Frantz
2019-03-28 21:20:21 +01:00
parent 2d7ef06ef6
commit 481cc327cd
6 changed files with 53 additions and 9 deletions

View File

@@ -2,8 +2,6 @@
namespace tests\Unit\Domain\ParameterManagement;
use Infinito\Domain\ParameterManagement\OptionalGetParameterService;
use Infinito\Domain\ParameterManagement\OptionalGetParameterServiceInterface;
use Infinito\Domain\ParameterManagement\ParameterFactory;
use Infinito\Domain\ParameterManagement\ValidGetParametersService;
use Infinito\Exception\NotDefinedException;
@@ -37,16 +35,15 @@ class ValidGetParameterServiceTest extends KernelTestCase
private $validGetParameterService;
/**
*
* @var ParameterFactoryInterface
*/
private $parameterFactory;
/**
* @var ValidatorInterface
*/
private $validator;
public function setUp(): void
{
self::bootKernel();
@@ -58,6 +55,23 @@ class ValidGetParameterServiceTest extends KernelTestCase
$this->validGetParameterService = new ValidGetParametersService($this->requestStack, $this->parameterFactory, $this->validator);
}
public function testVersionCorrectType(): void
{
$key = VersionParameter::getKey();
$value = 123;
$this->currentRequest->query->set($key, $value);
$result = $this->validGetParameterService->getParameter($key);
$this->assertEquals($value, $result);
}
public function testVersionWrongType(): void
{
$key = VersionParameter::getKey();
$this->currentRequest->query->set($key, 'adasdas');
$this->expectException(UnvalidParameterException::class);
$this->validGetParameterService->getParameter($key);
}
public function testConstructor(): void
{
$this->expectException(UnvalidParameterException::class);