kevinveenbirkenbach/infinito
1
0
Fork 0
mirror of https://github.com/kevinveenbirkenbach/infinito.git synced 2025-09-13 13:57:10 +02:00
Code Issues Packages Projects Releases Wiki Activity

Optimized ParameterManagement

Browse Source
This commit is contained in:
Kevin Frantz
2019-03-28 21:20:21 +01:00
parent 2d7ef06ef6
commit 481cc327cd
6 changed files with 53 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
application/symfony/tests/Integration/Domain/ParameterManagement/Parameter/VersionParameterIntegrationTest.php
View File

@@ -2,6 +2,28 @@
namespace tests\Integration\Domain\ParameterManagement\Parameter;
class VersionParameterIntegrationTest
use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
use Symfony\Component\Validator\Validator\ValidatorInterface;
use Infinito\Domain\ParameterManagement\Parameter\VersionParameter;
/**
* @author kevinfrantz
*/
class VersionParameterIntegrationTest extends KernelTestCase
{
public function testValidation()
{
self::bootKernel();
$validator = self::$container->get(ValidatorInterface::class);
$versionParameter = new VersionParameter();
$versionParameter->setValue(123);
$errors = $validator->validate($versionParameter)->count();
$this->assertEquals(0, $errors);
$versionParameter->setValue(null);
$errors = $validator->validate($versionParameter)->count();
$this->assertEquals(0, $errors);
$versionParameter->setValue('abc');
$errors = $validator->validate($versionParameter)->count();
$this->assertGreaterThan(0, $errors);
}
}

24
application/symfony/tests/Integration/Domain/ParameterManagement/ValidGetParameterServiceTest.php
View File

@@ -2,8 +2,6 @@
namespace tests\Unit\Domain\ParameterManagement;
use Infinito\Domain\ParameterManagement\OptionalGetParameterService;
use Infinito\Domain\ParameterManagement\OptionalGetParameterServiceInterface;
use Infinito\Domain\ParameterManagement\ParameterFactory;
use Infinito\Domain\ParameterManagement\ValidGetParametersService;
use Infinito\Exception\NotDefinedException;
@@ -37,16 +35,15 @@ class ValidGetParameterServiceTest extends KernelTestCase
private $validGetParameterService;
/**
*
* @var ParameterFactoryInterface
*/
private $parameterFactory;
/**
* @var ValidatorInterface
*/
private $validator;
public function setUp(): void
{
self::bootKernel();
@@ -58,6 +55,23 @@ class ValidGetParameterServiceTest extends KernelTestCase
$this->validGetParameterService = new ValidGetParametersService($this->requestStack, $this->parameterFactory, $this->validator);
}
public function testVersionCorrectType(): void
{
$key = VersionParameter::getKey();
$value = 123;
$this->currentRequest->query->set($key, $value);
$result = $this->validGetParameterService->getParameter($key);
$this->assertEquals($value, $result);
}
public function testVersionWrongType(): void
{
$key = VersionParameter::getKey();
$this->currentRequest->query->set($key, 'adasdas');
$this->expectException(UnvalidParameterException::class);
$this->validGetParameterService->getParameter($key);
}
public function testConstructor(): void
{
$this->expectException(UnvalidParameterException::class);