Optimized ParameterManagement

application/symfony/src/Domain/ParameterManagement/OptionalGetParameterService.php

@@ -9,6 +9,7 @@ use Infinito\Exception\NotDefinedException;
 
 /**
  * @todo Rename class!
+ * deprecated use ValidGetParameterService instead
  *
  * @author kevinfrantz
  */
@@ -17,7 +18,7 @@ class OptionalGetParameterService implements OptionalGetParameterServiceInterfac
     /**
      * @var Request
      */
-    private $currentRequest;
+    protected $currentRequest;
 
     /**
      * @param string $key

application/symfony/src/Domain/ParameterManagement/Parameter/VersionParameter.php

@@ -7,11 +7,12 @@ use Symfony\Component\Validator\Constraints as Assert;
 /**
  * @author kevinfrantz
  */
-final class VersionParameter extends AbstractParameter
+class VersionParameter extends AbstractParameter
 {
     /**
      * @var int|null
      * @Assert\GreaterThan(0)
+     * @Assert\Type("integer")
      */
     protected $value;
 }

application/symfony/src/Domain/ParameterManagement/ParameterFactory.php

@@ -64,7 +64,7 @@ final class ParameterFactory implements ParameterFactoryInterface
     public function getParameter(string $key): ParameterInterface
     {
         $parameter = $this->parameters->get($key);
-        if($parameter){
+        if ($parameter) {
             return $parameter;
         }
         throw new NoValidChoiceException("The parameter for key <<$key>> doesn't exist!");

application/symfony/src/Domain/ParameterManagement/ValidGetParametersService.php

@@ -21,6 +21,11 @@ final class ValidGetParametersService extends OptionalGetParameterService implem
      */
     private $validator;
 
+    /**
+     * @param RequestStack              $requestStack
+     * @param ParameterFactoryInterface $parameterFactory
+     * @param ValidatorInterface        $validator
+     */
     public function __construct(RequestStack $requestStack, ParameterFactoryInterface $parameterFactory, ValidatorInterface $validator)
     {
         $this->parameterFactory = $parameterFactory;
@@ -37,6 +42,7 @@ final class ValidGetParametersService extends OptionalGetParameterService implem
     {
         parent::validateParameter($key);
         $parameter = $this->parameterFactory->getParameter($key);
+        $parameter->setValue($this->currentRequest->get($key));
         $errors = $this->validator->validate($parameter);
         if (count($errors) > 0) {
             throw new UnvalidParameterException("Parameter <<$key>> didn't pass the validation");