kevinveenbirkenbach/infinito
1
0
Fork 0
mirror of https://github.com/kevinveenbirkenbach/infinito.git synced 2025-11-04 11:17:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Expanded rights to also manage actions instead of just a cruds

Browse Source
This commit is contained in:
Kevin Frantz
2019-02-21 18:46:57 +01:00
parent 465d6d6d01
commit 3e91aed050
27 changed files with 91 additions and 98 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
application/symfony/tests/Integration/Domain/RequestManagement/Right/RequestedRightServiceIntegrationTest.php
View File

@@ -30,7 +30,7 @@ class RequestedRightServiceIntegrationTest extends KernelTestCase
public function testClassAccessors(): void
{
$crud = CRUDType::READ;
$this->assertNull($this->requestedRightService->setCrud($crud));
$this->assertEquals($crud, $this->requestedRightService->getCrud());
$this->assertNull($this->requestedRightService->setActionType($crud));
$this->assertEquals($crud, $this->requestedRightService->getActionType());
}
}

4
application/symfony/tests/Integration/Domain/RequestManagement/User/RequestedUserServiceIntegrationTest.php
View File

@@ -30,7 +30,7 @@ class RequestedUserServiceIntegrationTest extends KernelTestCase
public function testCrudAccessors(): void
{
$crud = CRUDType::READ;
$this->assertNull($this->requestedUserService->setCrud($crud));
$this->assertEquals($crud, $this->requestedUserService->getCrud());
$this->assertNull($this->requestedUserService->setActionType($crud));
$this->assertEquals($crud, $this->requestedUserService->getActionType());
}
}

8
application/symfony/tests/Integration/Domain/SecureManagement/SecureRequestedRightCheckerIntegrationTest.php
View File

@@ -38,11 +38,11 @@ class SecureRequestedRightCheckerServiceIntegrationTest extends KernelTestCase
$right = new Right();
$right->setSource($source);
$right->setLayer($layer);
$right->setCrud($crud);
$right->setActionType($crud);
$right->setReciever($reciever);
$source->getLaw()->getRights()->add($right);
$requestedRight = new RequestedRight();
$requestedRight->setCrud($crud);
$requestedRight->setActionType($crud);
$requestedRight->setLayer($layer);
$requestedRight->setReciever($reciever);
$requestedEntity = $this->createMock(RequestedEntityInterface::class);
@@ -64,11 +64,11 @@ class SecureRequestedRightCheckerServiceIntegrationTest extends KernelTestCase
$right = new Right();
$right->setSource($source);
$right->setLayer($layer);
$right->setCrud(CRUDType::CREATE);
$right->setActionType(CRUDType::CREATE);
$right->setReciever($reciever);
$source->getLaw()->getRights()->add($right);
$requestedRight = new RequestedRight();
$requestedRight->setCrud($crud);
$requestedRight->setActionType($crud);
$requestedRight->setLayer($layer);
$requestedRight->setReciever($reciever);
$requestedEntity = $this->createMock(RequestedEntityInterface::class);

2
application/symfony/tests/Integration/Repository/Meta/RightRepositoryIntegrationTest.php
View File

@@ -59,7 +59,7 @@ class RightRepositoryIntegrationTest extends KernelTestCase
$this->right = new Right();
$this->right->setPriority(self::PRIORITY);
$this->right->setLayer(LayerType::SOURCE);
$this->right->setCrud(CRUDType::READ);
$this->right->setActionType(CRUDType::READ);
$this->law = new Law();
$this->entityManager->persist($this->law);
}

9
application/symfony/tests/Unit/Controller/DefaultControllerTest.php
View File

@@ -4,6 +4,7 @@ namespace Infinito\Tests\Unit\Controller;
use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
use Infinito\Controller\DefaultController;
use Infinito\DBAL\Types\RESTResponseType;
/**
* @author kevinfrantz
@@ -30,7 +31,11 @@ class DefaultControllerTest extends WebTestCase
public function testImprint(): void
{
$client = static::createClient();
$client->request('GET', '/imprint');
$this->assertEquals(200, $client->getResponse()->getStatusCode());
// foreach(RESTResponseType::getChoices() as $format){
$format = 'html';
$url = 'api/rest/source/imprint.'.$format;
$client->request('GET', $url);
$this->assertEquals(200, $client->getResponse()->getStatusCode(), "Route $url is not reachable.");
// }
}
}

12
application/symfony/tests/Unit/Domain/LawManagement/LawPermissionCheckerTest.php
View File

@@ -87,7 +87,7 @@ class LawPermissionCheckerTest extends TestCase
{
$this->clientRight = new Right();
$this->clientRight->setLayer(LayerType::SOURCE);
$this->clientRight->setCrud(CRUDType::READ);
$this->clientRight->setActionType(CRUDType::READ);
$this->clientRight->setReciever($this->clientSource);
$this->clientRight->setSource($this->source);
}
@@ -107,7 +107,7 @@ class LawPermissionCheckerTest extends TestCase
{
$this->law->getRights()->add($this->getClonedClientRight());
$this->assertTrue($this->checkClientPermission());
$this->clientRight->setCrud(CRUDType::UPDATE);
$this->clientRight->setActionType(CRUDType::UPDATE);
$this->assertFalse($this->checkClientPermission());
}
@@ -142,10 +142,10 @@ class LawPermissionCheckerTest extends TestCase
public function testGetRightsByType(): void
{
$right = $this->getClonedClientRight();
$right->setCrud(CRUDType::UPDATE);
$right->setActionType(CRUDType::UPDATE);
$this->law->getRights()->add($right);
$this->assertFalse($this->checkClientPermission());
$right->setCrud(CRUDType::READ);
$right->setActionType(CRUDType::READ);
$this->assertTrue($this->checkClientPermission());
}
@@ -209,13 +209,13 @@ class LawPermissionCheckerTest extends TestCase
$clientSource = new PureSource();
$clientRight = new Right();
$clientRight->setLayer(LayerType::SOURCE);
$clientRight->setCrud(CRUDType::READ);
$clientRight->setActionType(CRUDType::READ);
$clientRight->setSource($this->source);
$clientRight->setReciever($clientSource);
$this->assertFalse($this->lawPermissionChecker->hasPermission($clientRight));
$right = new Right();
$right->setLayer(LayerType::SOURCE);
$right->setCrud(CRUDType::READ);
$right->setActionType(CRUDType::READ);
$right->setSource($this->source);
$this->law->getRights()->add($right);
$this->assertTrue($this->lawPermissionChecker->hasPermission($clientRight));

4
application/symfony/tests/Unit/Domain/RequestManagement/Action/RequestedActionTest.php
View File

@@ -52,7 +52,7 @@ class RequestedActionTest extends TestCase
$list = ActionType::EXECUTE;
$this->action->setActionType($list);
$this->assertEquals($list, $this->action->getActionType());
$this->assertEquals(CRUDType::READ, $this->requestedRight->getCrud());
$this->assertEquals(CRUDType::READ, $this->requestedRight->getActionType());
}
public function testCrud(): void
@@ -60,7 +60,7 @@ class RequestedActionTest extends TestCase
foreach (CRUDType::getChoices() as $crud) {
$this->action->setActionType($crud);
$this->assertEquals($crud, $this->action->getActionType());
$this->assertEquals($crud, $this->requestedRight->getCrud());
$this->assertEquals($crud, $this->requestedRight->getActionType());
}
}

8
application/symfony/tests/Unit/Domain/RequestManagement/Right/AbstractRequestedRightFacadeTest.php
View File

@@ -43,7 +43,7 @@ class AbstractRequestedRightFacadeTest extends TestCase
$reciever = $this->createMock(AbstractSource::class);
$requestedRight = $this->createMock(RequestedRightInterface::class);
$requestedRight->method('getLayer')->willReturn($layer);
$requestedRight->method('getCrud')->willReturn($type);
$requestedRight->method('getActionType')->willReturn($type);
$requestedRight->method('getSource')->willReturn($source);
$requestedRight->method('getReciever')->willReturn($reciever);
$requestedRight->method('getRequestedEntity')->willReturn($requestedEntity);
@@ -51,7 +51,7 @@ class AbstractRequestedRightFacadeTest extends TestCase
$requestedRight->method('hasReciever')->willReturn(true);
$requestedRightFacade = $this->getRequestedRightFacade($requestedRight);
$this->assertEquals($layer, $requestedRightFacade->getLayer());
$this->assertEquals($type, $requestedRightFacade->getCrud());
$this->assertEquals($type, $requestedRightFacade->getActionType());
$this->assertEquals($source, $requestedRightFacade->getSource());
$this->assertEquals($reciever, $requestedRightFacade->getReciever());
$this->assertEquals($requestedEntity, $requestedRightFacade->getRequestedEntity());
@@ -70,11 +70,11 @@ class AbstractRequestedRightFacadeTest extends TestCase
$requestedRight = new RequestedRight();
$requestedRightFacade = $this->getRequestedRightFacade($requestedRight);
$this->assertNull($requestedRightFacade->setLayer($layer));
$this->assertNull($requestedRightFacade->setCrud($type));
$this->assertNull($requestedRightFacade->setActionType($type));
$this->assertNull($requestedRightFacade->setRequestedEntity($requestedEntity));
$this->assertNull($requestedRightFacade->setReciever($reciever));
$this->assertEquals($layer, $requestedRight->getLayer());
$this->assertEquals($type, $requestedRight->getCrud());
$this->assertEquals($type, $requestedRight->getActionType());
$this->assertEquals($requestedEntity, $requestedRight->getRequestedEntity());
$this->assertEquals($reciever, $requestedRight->getReciever());
$this->assertTrue($requestedRight->hasReciever());

8
application/symfony/tests/Unit/Domain/RequestManagement/User/RequestedUserRightTest.php
View File

@@ -44,11 +44,11 @@ class RequestedUserTest extends TestCase
$userSourceDirector->method('getUser')->willReturn($user);
$requestedRight = $this->createMock(RequestedRightInterface::class);
$requestedRight->method('getLayer')->willReturn($layer);
$requestedRight->method('getCrud')->willReturn($type);
$requestedRight->method('getActionType')->willReturn($type);
$requestedRight->method('getSource')->willReturn($source);
$requestedUserRightFacade = new RequestedUser($userSourceDirector, $requestedRight);
$this->assertEquals($layer, $requestedUserRightFacade->getLayer());
$this->assertEquals($type, $requestedUserRightFacade->getCrud());
$this->assertEquals($type, $requestedUserRightFacade->getActionType());
$this->assertEquals($source, $requestedUserRightFacade->getSource());
$this->assertEquals($reciever, $requestedUserRightFacade->getReciever());
}
@@ -66,10 +66,10 @@ class RequestedUserTest extends TestCase
$userSourceDirector = new UserSourceDirector($sourceRepository, $user);
$requestedUserRightFacade = new RequestedUser($userSourceDirector, $requestedRight);
$this->assertNull($requestedUserRightFacade->setLayer($layer));
$this->assertNull($requestedUserRightFacade->setCrud($type));
$this->assertNull($requestedUserRightFacade->setActionType($type));
$this->assertNull($requestedUserRightFacade->setRequestedEntity($requestedSource));
$this->assertEquals($layer, $requestedRight->getLayer());
$this->assertEquals($type, $requestedRight->getCrud());
$this->assertEquals($type, $requestedRight->getActionType());
$this->expectException(NotCorrectInstanceException::class);
$this->assertNotInstanceOf(RequestedEntityInterface::class, $requestedRight->getSource());
}

2
application/symfony/tests/Unit/Domain/RightManagement/RightCheckerTest.php
View File

@@ -49,7 +49,7 @@ class RightCheckerTest extends TestCase
$this->source = new PureSource();
$this->right = new Right();
$this->right->setReciever($this->source);
$this->right->setCrud($this->type);
$this->right->setActionType($this->type);
$this->right->setLayer($this->layer);
$this->rightManager = new RightChecker($this->right);
}

4
application/symfony/tests/Unit/Domain/RightManagement/RightTransformerServiceTest.php
View File

@@ -26,13 +26,13 @@ class RightTransformerServiceTest extends TestCase
$requestedEntity->method('getEntity')->willReturn($source);
$requestedEntity->method('hasRequestedRight')->willReturn(true);
$requestedRight = new RequestedRight();
$requestedRight->setCrud($crud);
$requestedRight->setActionType($crud);
$requestedRight->setLayer($layer);
$requestedRight->setRequestedEntity($requestedEntity);
$requestedRight->setReciever($reciever);
$transformer = new RightTransformerService();
$right = $transformer->transform($requestedRight);
$this->assertEquals($crud, $right->getCrud());
$this->assertEquals($crud, $right->getActionType());
$this->assertEquals($layer, $right->getLayer());
$this->assertEquals($reciever, $right->getReciever());
$this->assertEquals($source, $right->getSource());

12
application/symfony/tests/Unit/Domain/SecureManagement/SecureRequestedRightCheckerTest.php
View File

@@ -29,11 +29,11 @@ class SecureRequestedRightCheckerServiceTest extends TestCase
$right = new Right();
$right->setSource($source);
$right->setLayer($layer);
$right->setCrud($crud);
$right->setActionType($crud);
$right->setReciever($reciever);
$source->getLaw()->getRights()->add($right);
$requestedRight = new RequestedRight();
$requestedRight->setCrud($crud);
$requestedRight->setActionType($crud);
$requestedRight->setLayer($layer);
$requestedRight->setReciever($reciever);
$requestedEntity = $this->createMock(RequestedEntityInterface::class);
@@ -57,11 +57,11 @@ class SecureRequestedRightCheckerServiceTest extends TestCase
$right = new Right();
$right->setSource($source);
$right->setLayer($layer);
$right->setCrud(CRUDType::CREATE);
$right->setActionType(CRUDType::CREATE);
$right->setReciever($reciever);
$source->getLaw()->getRights()->add($right);
$requestedRight = new RequestedRight();
$requestedRight->setCrud($crud);
$requestedRight->setActionType($crud);
$requestedRight->setLayer($layer);
$requestedRight->setReciever($reciever);
$requestedEntity = $this->createMock(RequestedEntityInterface::class);
@@ -83,7 +83,7 @@ class SecureRequestedRightCheckerServiceTest extends TestCase
$source = new class() extends AbstractSource {
};
$requestedRight = $this->createMock(RequestedRightInterface::class);
$requestedRight->method('getCrud')->willReturn($crud);
$requestedRight->method('getActionType')->willReturn($crud);
$requestedRight->method('getLayer')->willReturn($layer);
$requestedRight->method('getReciever')->willReturn($reciever);
$requestedRight->method('getSource')->willReturn($source);
@@ -91,7 +91,7 @@ class SecureRequestedRightCheckerServiceTest extends TestCase
$secureEntityChecker = new SecureRequestedRightCheckerService($rightTransformerService);
$this->assertFalse($secureEntityChecker->check($requestedRight));
$right = new Right();
$right->setCrud($crud);
$right->setActionType($crud);
$right->setLayer($layer);
$right->setSource($source);
$source->getLaw()->getRights()->add($right);

19
application/symfony/tests/Unit/Domain/SecureManagement/SecureSourceCheckerTest.php
View File

@@ -34,6 +34,9 @@ class SecureSourceCheckerTest extends TestCase
*/
private $securerSourceChecker;
/**
* @return SourceInterface
*/
private function createSourceMock(): SourceInterface
{
return new class() extends AbstractSource implements SourceAttributInterface {
@@ -52,13 +55,13 @@ class SecureSourceCheckerTest extends TestCase
{
$right = new Right();
$right->setLayer(LayerType::SOURCE);
$right->setCrud(CRUDType::UPDATE);
$right->setActionType(CRUDType::UPDATE);
$right->setReciever($this->recieverSource);
$right->setSource($this->source);
$this->source->getLaw()->getRights()->add($right);
$requestedRight = clone $right;
$this->assertTrue($this->securerSourceChecker->hasPermission($requestedRight));
$requestedRight->setCrud(CRUDType::READ);
$requestedRight->setActionType(CRUDType::READ);
$this->assertFalse($this->securerSourceChecker->hasPermission($requestedRight));
}
@@ -66,7 +69,7 @@ class SecureSourceCheckerTest extends TestCase
{
$right = new Right();
$right->setLayer(LayerType::SOURCE);
$right->setCrud(CRUDType::UPDATE);
$right->setActionType(CRUDType::UPDATE);
$right->setReciever($this->recieverSource);
$right->setSource($this->source);
$this->source->getLaw()->getRights()->add($right);
@@ -76,7 +79,7 @@ class SecureSourceCheckerTest extends TestCase
$this->source->setSource($attributSource);
$requestedRight = clone $right;
$this->assertTrue($this->securerSourceChecker->hasPermission($requestedRight));
$childRight->setCrud(CRUDType::READ);
$childRight->setActionType(CRUDType::READ);
$this->expectException(SourceAccessDenied::class);
$this->securerSourceChecker->hasPermission($requestedRight);
}
@@ -85,7 +88,7 @@ class SecureSourceCheckerTest extends TestCase
{
$right = new Right();
$right->setLayer(LayerType::SOURCE);
$right->setCrud(CRUDType::UPDATE);
$right->setActionType(CRUDType::UPDATE);
$right->setReciever($this->recieverSource);
$right->setSource($this->source);
$this->source->getLaw()->getRights()->add($right);
@@ -98,7 +101,7 @@ class SecureSourceCheckerTest extends TestCase
$attribut1Source->setSource($attribut2Source);
$requestedRight = clone $right;
$this->assertTrue($this->securerSourceChecker->hasPermission($requestedRight));
$childRight->setCrud(CRUDType::READ);
$childRight->setActionType(CRUDType::READ);
$this->expectException(SourceAccessDenied::class);
$this->securerSourceChecker->hasPermission($requestedRight);
}
@@ -107,13 +110,13 @@ class SecureSourceCheckerTest extends TestCase
{
$right = new Right();
$right->setLayer(LayerType::SOURCE);
$right->setCrud(CRUDType::READ);
$right->setActionType(CRUDType::READ);
$right->setReciever($this->recieverSource);
$right->setSource($this->source);
$this->assertFalse($this->securerSourceChecker->hasPermission($right));
$requestedRight = new Right();
$requestedRight->setLayer(LayerType::SOURCE);
$requestedRight->setCrud(CRUDType::READ);
$requestedRight->setActionType(CRUDType::READ);
$requestedRight->setSource($this->source);
$this->source->getLaw()->getRights()->add($requestedRight);
$this->assertTrue($this->securerSourceChecker->hasPermission($right));

12
application/symfony/tests/Unit/Entity/Meta/RightTest.php
View File

@@ -61,7 +61,7 @@ class RightTest extends TestCase
public function testConstructorType(): void
{
$this->expectException(\TypeError::class);
$this->assertNull($this->right->getCrud());
$this->assertNull($this->right->getActionType());
}
public function testLaw(): void
@@ -74,11 +74,11 @@ class RightTest extends TestCase
public function testRight(): void
{
foreach (CRUDType::getChoices() as $enum) {
$this->assertNull($this->right->setCrud($enum));
$this->assertEquals($enum, $this->right->getCrud());
$this->assertNull($this->right->setActionType($enum));
$this->assertEquals($enum, $this->right->getActionType());
}
$this->expectException(NoValidChoiceException::class);
$this->right->setCrud('NoneValidType');
$this->right->setActionType('NoneValidType');
}
public function testLayer(): void
@@ -104,13 +104,13 @@ class RightTest extends TestCase
$this->right->setSource($source);
$this->right->setReciever($reciever);
$this->right->setGrant($grant);
$this->right->setCrud($type);
$this->right->setActionType($type);
$this->right->setLayer($layer);
$rightClone = clone $this->right;
$this->assertEquals($source, $rightClone->getSource());
$this->assertEquals($reciever, $rightClone->getReciever());
$this->assertEquals($grant, $rightClone->getGrant());
$this->assertEquals($type, $rightClone->getCrud());
$this->assertEquals($type, $rightClone->getActionType());
$this->assertEquals($layer, $rightClone->getLayer());
}
}