kevinveenbirkenbach/infinito
1
0
Fork 0
mirror of https://github.com/kevinveenbirkenbach/infinito.git synced 2025-10-31 17:29:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

Renamed SecureRequestedRightChecker and implemented integration tests for it

Browse Source
This commit is contained in:
Kevin Frantz
2019-02-16 09:19:49 +01:00
parent 8f0b806719
commit 2aebdd603c
10 changed files with 109 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
application/symfony/tests/Unit/Domain/ActionManagement/ActionServiceTest.php
View File

@@ -5,7 +5,6 @@ namespace tests\Unit\Domain\ActionManagement;
use PHPUnit\Framework\TestCase;
use App\Domain\ActionManagement\ActionService;
use App\Domain\RequestManagement\Action\RequestedActionInterface;
use App\Domain\SecureManagement\SecureRequestedRightCheckerInterface;
use Doctrine\ORM\EntityManagerInterface;
use Symfony\Component\HttpFoundation\RequestStack;
use App\Domain\RepositoryManagement\LayerRepositoryFactoryServiceInterface;
@@ -18,6 +17,7 @@ use App\Entity\EntityInterface;
use Symfony\Component\Form\FormBuilderInterface;
use App\Domain\FormManagement\RequestedActionFormBuilderServiceInterface;
use App\Domain\RequestManagement\Action\RequestedActionServiceInterface;
use App\Domain\SecureManagement\SecureRequestedRightCheckerServiceInterface;
/**
* @author kevinfrantz
@@ -30,9 +30,9 @@ class ActionServiceTest extends TestCase
private $requestedActionService;
/**
* @var SecureRequestedRightCheckerInterface|MockObject
* @var SecureRequestedRightCheckerServiceInterface
*/
private $secureRequestedRightChecker;
private $secureRequestedRightCheckerService;
/**
* @var RequestedActionFormBuilderServiceInterface|MockObject
@@ -79,17 +79,17 @@ class ActionServiceTest extends TestCase
$this->requestedActionService = $this->createMock(RequestedActionServiceInterface::class);
$this->requestedActionService->method('getRequestedEntity')->willReturn($this->requestedEntity);
$this->secureRequestedRightChecker = $this->createMock(SecureRequestedRightCheckerInterface::class);
$this->secureRequestedRightCheckerService = $this->createMock(SecureRequestedRightCheckerServiceInterface::class);
$this->requestedActionFormBuilderService = $this->createMock(RequestedActionFormBuilderServiceInterface::class);
$this->requestStack = $this->createMock(RequestStack::class);
$this->layerRepositoryFactoryService = $this->createMock(LayerRepositoryFactoryServiceInterface::class);
$this->entityManager = $this->createMock(EntityManagerInterface::class);
$this->actionService = new ActionService($this->requestedActionService, $this->secureRequestedRightChecker, $this->requestStack, $this->layerRepositoryFactoryService, $this->requestedActionFormBuilderService, $this->entityManager);
$this->actionService = new ActionService($this->requestedActionService, $this->secureRequestedRightCheckerService, $this->requestStack, $this->layerRepositoryFactoryService, $this->requestedActionFormBuilderService, $this->entityManager);
}
public function testIsRequestedActionSecure(): void
{
$this->secureRequestedRightChecker->method('check')->willReturn(true);
$this->secureRequestedRightCheckerService->method('check')->willReturn(true);
$this->assertTrue($this->actionService->isRequestedActionSecure());
}

4
application/symfony/tests/Unit/Domain/ActionManagement/Create/CreateSourceActionTest.php
View File

@@ -12,7 +12,7 @@ use App\Entity\Source\PureSourceInterface;
use App\Domain\ActionManagement\ActionService;
use Doctrine\ORM\EntityManagerInterface;
use App\Domain\RequestManagement\Action\RequestedActionServiceInterface;
use App\Domain\SecureManagement\SecureRequestedRightCheckerInterface;
use App\Domain\SecureManagement\SecureRequestedRightCheckerServiceInterface;
use Symfony\Component\HttpFoundation\RequestStack;
use App\Domain\RepositoryManagement\LayerRepositoryFactoryServiceInterface;
use App\Domain\FormManagement\RequestedActionFormBuilderServiceInterface;
@@ -31,7 +31,7 @@ class CreateSourceActionTest extends TestCase
$request->query->set(ClassAttributInterface::CLASS_ATTRIBUT_NAME, PureSource::class);
$request->request->set(SlugAttributInterface::SLUG_ATTRIBUT_NAME, 'randomname');
$requestedActionService = $this->createMock(RequestedActionServiceInterface::class);
$secureRequestedRightChecker = $this->createMock(SecureRequestedRightCheckerInterface::class);
$secureRequestedRightChecker = $this->createMock(SecureRequestedRightCheckerServiceInterface::class);
$entityManager = $this->createMock(EntityManagerInterface::class);
$pureSourceType = $this->createMock(PureSourceTypeInterface::class);
$pureSourceType->method('isValid')->willReturn(true);

8
application/symfony/tests/Unit/Domain/SecureManagement/SecureRequestedRightCheckerTest.php
View File

@@ -9,13 +9,13 @@ use App\DBAL\Types\Meta\Right\CRUDType;
use App\Entity\Meta\Right;
use App\Domain\RequestManagement\Right\RequestedRight;
use App\Domain\RequestManagement\Entity\RequestedEntityInterface;
use App\Domain\SecureManagement\SecureRequestedRightChecker;
use App\Domain\SecureManagement\SecureRequestedRightCheckerService;
use App\Domain\RightManagement\RightTransformerService;
/**
* @author kevinfrantz
*/
class SecureRequestedRightCheckerTest extends TestCase
class SecureRequestedRightCheckerServiceTest extends TestCase
{
public function testGranted(): void
{
@@ -40,7 +40,7 @@ class SecureRequestedRightCheckerTest extends TestCase
$requestedEntity->method('getEntity')->willReturn($source);
$requestedRight->setRequestedEntity($requestedEntity);
$rightTransformerService = new RightTransformerService();
$secureEntityChecker = new SecureRequestedRightChecker($rightTransformerService);
$secureEntityChecker = new SecureRequestedRightCheckerService($rightTransformerService);
$result = $secureEntityChecker->check($requestedRight);
$this->assertTrue($result);
}
@@ -68,7 +68,7 @@ class SecureRequestedRightCheckerTest extends TestCase
$requestedEntity->method('getEntity')->willReturn($source);
$requestedRight->setRequestedEntity($requestedEntity);
$rightTransformerService = new RightTransformerService();
$secureEntityChecker = new SecureRequestedRightChecker($rightTransformerService);
$secureEntityChecker = new SecureRequestedRightCheckerService($rightTransformerService);
$result = $secureEntityChecker->check($requestedRight);
$this->assertFalse($result);
}