mirror of
https://github.com/kevinveenbirkenbach/infinito.git
synced 2025-09-13 13:57:10 +02:00
Optimized REST API and tests
This commit is contained in:
@@ -0,0 +1,4 @@
|
||||
# API
|
||||
This folder contains the different API controllers.
|
||||
Right now just an REST API is implemented.
|
||||
In the future it would also make sense to implement an [GraphQL](https://graphql.org/) API.
|
@@ -0,0 +1,20 @@
|
||||
<?php
|
||||
|
||||
namespace tests\Integration\Controller\API\Rest;
|
||||
|
||||
use PHPUnit\Framework\TestCase;
|
||||
use Infinito\DBAL\Types\Meta\Right\LayerType;
|
||||
|
||||
/**
|
||||
* @author kevinfrantz
|
||||
*/
|
||||
class ControllerLayerIntegrationTest extends TestCase
|
||||
{
|
||||
public function testThatControllerForEachLayerExist(): void
|
||||
{
|
||||
foreach (LayerType::getChoices() as $layer) {
|
||||
$className = 'Infinito\\Controller\\API\\Rest\\'.ucfirst($layer).'Controller';
|
||||
$this->assertTrue(class_exists($className));
|
||||
}
|
||||
}
|
||||
}
|
@@ -0,0 +1,89 @@
|
||||
<?php
|
||||
|
||||
namespace Tests\Integration\Controller;
|
||||
|
||||
use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
|
||||
use Infinito\DBAL\Types\Meta\Right\LayerType;
|
||||
use Infinito\DBAL\Types\RESTResponseType;
|
||||
use Symfony\Component\HttpFoundation\Request;
|
||||
use Infinito\Domain\LayerManagement\LayerActionMap;
|
||||
use Infinito\DBAL\Types\ActionType;
|
||||
use Infinito\Domain\MapManagement\ActionHttpMethodMap;
|
||||
use Symfony\Component\HttpFoundation\Response;
|
||||
|
||||
/**
|
||||
* @author kevinfrantz
|
||||
*
|
||||
* @todo Implement more tests for success etc.
|
||||
*/
|
||||
class RestRoutesReachableIntegrationTest extends KernelTestCase
|
||||
{
|
||||
/**
|
||||
* {@inheritdoc}
|
||||
*
|
||||
* @see \PHPUnit\Framework\TestCase::setUp()
|
||||
*/
|
||||
public function setUp(): void
|
||||
{
|
||||
self::bootKernel();
|
||||
}
|
||||
|
||||
public function testAllRoutePossibilities(): void
|
||||
{
|
||||
foreach ([
|
||||
'12314123',
|
||||
'testslug',
|
||||
] as $uri) {
|
||||
foreach (RESTResponseType::getChoices() as $format) {
|
||||
foreach (LayerType::getChoices() as $layer) {
|
||||
$actions = LayerActionMap::getActions($layer);
|
||||
foreach ($actions as $action) {
|
||||
foreach (ActionHttpMethodMap::getHttpMethods($action) as $method) {
|
||||
$baseUrl = "api/rest/$layer";
|
||||
switch ($action) {
|
||||
case ActionType::CREATE:
|
||||
$url = "$baseUrl.$format";
|
||||
$this->routeAssert($url, $method);
|
||||
break;
|
||||
case ActionType::EXECUTE:
|
||||
$url = "$baseUrl/$uri/action/execute.$format";
|
||||
$this->routeAssert($url, $method);
|
||||
break;
|
||||
default:
|
||||
$url = "$baseUrl/$uri.$format";
|
||||
$this->routeAssert($url, $method);
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* @param string $url
|
||||
* @param string $method
|
||||
*/
|
||||
private function routeAssert(string $url, string $method): void
|
||||
{
|
||||
$request = new Request([], [], [], [], [], [
|
||||
'REQUEST_URI' => $url,
|
||||
]);
|
||||
$request->setMethod($method);
|
||||
$response = static::$kernel->handle($request);
|
||||
$this->assertTrue($this->isResponseValid($response), "Route $url with Method $method sends an 404 response and doesn't throw an EntityNotFoundHttpException!");
|
||||
}
|
||||
|
||||
/**
|
||||
* @param Response $response
|
||||
*
|
||||
* @return bool
|
||||
*/
|
||||
private function isResponseValid(Response $response): bool
|
||||
{
|
||||
$is404 = 404 === $response->getStatusCode();
|
||||
$isEntityNotFoundHttpException = strpos($response->getContent(), 'EntityNotFoundHttpException');
|
||||
|
||||
return !$is404 || $isEntityNotFoundHttpException;
|
||||
}
|
||||
}
|
Reference in New Issue
Block a user