Optimized AbstractSource entity for members

This commit is contained in:
Kevin Frantz 2018-11-24 22:17:03 +01:00
parent 5be4b7df3c
commit 1845e0cdba
3 changed files with 39 additions and 56 deletions

View File

@ -62,7 +62,7 @@ class Relation extends AbstractMeta implements RelationInterface
/**
* @ORM\OneToOne(targetEntity="Law",cascade={"persist", "remove"})
* @ORM\JoinColumn(name="law_id", referencedColumnName="id")
* @ORM\JoinColumn(name="law_id", referencedColumnName="id",onDelete="CASCADE")
*
* @var LawInterface
*/

View File

@ -72,17 +72,17 @@ abstract class AbstractSource extends AbstractEntity implements SourceInterface
* Many Sources have many Source Members.
*
* @var Collection|SourceInterface[]
* @ORM\ManyToMany(targetEntity="AbstractSource", inversedBy="memberships",cascade={"persist"})
* @ORM\ManyToMany(targetEntity="AbstractSource", inversedBy="memberships",cascade={"persist", "remove"})
* @ORM\JoinTable(name="source_members",
* joinColumns={@ORM\JoinColumn(name="source_id", referencedColumnName="id")},
* inverseJoinColumns={@ORM\JoinColumn(name="member_id", referencedColumnName="id")}
* joinColumns={@ORM\JoinColumn(name="source_id", referencedColumnName="id",onDelete="CASCADE")},
* inverseJoinColumns={@ORM\JoinColumn(name="member_id", referencedColumnName="id",onDelete="CASCADE")}
* )
*/
protected $members;
/**
* @var Collection|SourceInterface[]
* @ORM\ManyToMany(targetEntity="AbstractSource",mappedBy="members",cascade={"persist"})
* @ORM\ManyToMany(targetEntity="AbstractSource",mappedBy="members")
*/
protected $memberships;

View File

@ -4,11 +4,13 @@ namespace tests\Unit\Repository;
use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
use Doctrine\ORM\EntityManager;
use App\Entity\UserInterface;
use App\Repository\UserSourceRepository;
use App\Entity\Source\Complex\UserSourceInterface;
use App\Entity\Source\Complex\UserSource;
/**
* @todo refactor this to an integration test!
*
* @author kevinfrantz
*/
class UserSourceRepositoryTest extends KernelTestCase
{
/**
@ -16,70 +18,51 @@ class UserSourceRepositoryTest extends KernelTestCase
*/
protected $entityManager;
/**
* @var UserSourceRepository
*/
protected $userSourceRepository;
/**
* @var UserSourceInterface
*/
protected $loadedUserSource;
/**
* @var UserInterface
*/
protected $user;
/**
* @var UserSourceInterface
*/
protected $userSource;
public function setUp(): void
{
$kernel = self::bootKernel();
$this->entityManager = $kernel->getContainer()
->get('doctrine')
->getManager();
$this->userSourceRepository = $this->entityManager->getRepository(UserSource::class);
$this->userSource = new UserSource();
}
public function testMemberships(): void
public function testAddAndRemoveMember(): void
{
$userSource2 = new UserSource();
$this->userSource->getMemberships()->add($userSource2);
$this->entityManager->persist($this->userSource);
$insertSource = new UserSource();
$origineSource = new UserSource();
$origineSource->addMember($insertSource);
$this->entityManager->persist($insertSource);
$this->entityManager->persist($origineSource);
$this->entityManager->flush();
$userSource2Id = $userSource2->getId();
$userSourceId = $this->userSource->getId();
$this->loadedUserSource = $this->userSourceRepository->find($userSourceId);
$this->assertGreaterThan(0, $userSource2Id);
$this->assertEquals($userSource2, $this->loadedUserSource->getMemberships()->get(0));
$this->deleteUserSource();
$this->assertGreaterThan(0, $userSource2Id);
$this->entityManager->remove($userSource2);
$this->assertGreaterThan(0, $insertSource->getId());
$this->assertGreaterThan(0, $origineSource->getId());
$this->assertEquals($insertSource, $origineSource->getMembers()
->get(0));
$this->assertEquals($origineSource, $insertSource->getMemberships()
->get(0));
$this->assertNull($origineSource->removeMember($insertSource));
$this->assertEquals(0, $origineSource->getMembers()
->count());
$this->assertEquals(0, $insertSource->getMemberships()
->count());
$this->entityManager->remove($origineSource);
$this->entityManager->flush();
$this->assertNull($this->userSourceRepository->find($userSource2Id));
$this->assertGreaterThan(0, $insertSource->getId());
$this->entityManager->remove($insertSource);
$this->entityManager->flush();
$this->expectException(\TypeError::class);
$insertSource->getId();
}
public function testCreation(): void
{
$this->entityManager->persist($this->userSource);
$userSource = new UserSource();
$this->entityManager->persist($userSource);
$this->entityManager->flush();
$userSourceId = $this->userSource->getId();
/*
* @var UserSourceInterface
*/
$this->loadedUserSource = $this->userSourceRepository->find($userSourceId);
$this->assertEquals($userSourceId, $this->loadedUserSource->getId());
$this->deleteUserSource();
}
private function deleteUserSource(): void
{
$this->entityManager->remove($this->loadedUserSource);
$userSourceId = $userSource->getId();
$loadedUserSource = $this->entityManager->getRepository(UserSource::class)->find($userSourceId);
$this->assertEquals($userSourceId, $loadedUserSource->getId());
$this->entityManager->remove($loadedUserSource);
$this->entityManager->flush();
}