Optimized Tests and attributes

application/symfony/src/Attribut/LawAttribut.php

@@ -6,6 +6,8 @@ use App\Entity\Meta\LawInterface;
 
 /**
  * @author kevinfrantz
+ *
+ * @see LawAttributInterface
  */
 trait LawAttribut
 {
@@ -14,11 +16,17 @@ trait LawAttribut
      */
     protected $law;
 
+    /**
+     * @param LawInterface $law
+     */
     public function setLaw(LawInterface $law): void
     {
         $this->law = $law;
     }
 
+    /**
+     * @return LawInterface
+     */
     public function getLaw(): LawInterface
     {
         return $this->law;

application/symfony/src/Attribut/LayerAttribut.php

@@ -7,6 +7,8 @@ use App\Exception\NoValidChoiceException;
 
 /**
  * @author kevinfrantz
+ *
+ * @see LayerAttributInterface
  */
 trait LayerAttribut
 {
@@ -25,7 +27,7 @@ trait LayerAttribut
     public function setLayer(string $layer): void
     {
         if (!array_key_exists($layer, LayerType::getChoices())) {
-            throw new NoValidChoiceException();
+            throw new NoValidChoiceException("'$layer' is not a correct layer type.");
         }
         $this->layer = $layer;
     }

application/symfony/src/Attribut/LayerAttributInterface.php

@@ -7,7 +7,13 @@ namespace App\Attribut;
  */
 interface LayerAttributInterface
 {
+    /**
+     * @param string $layer
+     */
     public function setLayer(string $layer): void;
 
+    /**
+     * @return string
+     */
     public function getLayer(): string;
 }

application/symfony/src/Domain/ActionManagement/ActionFactoryService.php

@@ -2,6 +2,8 @@
 
 namespace App\Domain\ActionManagement;
 
+use App\Exception\NoDefaultClassException;
+
 /**
  * @author kevinfrantz
  */
@@ -56,8 +58,10 @@ final class ActionFactoryService extends AbstractActionConstructor implements Ac
             return $class;
         }
         $defaultClass = $this->getActionNamespace($action);
-
+        if (class_exists($defaultClass)) {
-        return $defaultClass;
+            return $defaultClass;
+        }
+        throw new NoDefaultClassException("There is no default substitution class for $class with attributes {layer:\"$layer\",action:\"$action\"}");
     }
 
     /**

application/symfony/src/Exception/NoDefaultClassException.php

@@ -0,0 +1,10 @@
+<?php
+
+namespace App\Exception;
+
+/**
+ * @author kevinfrantz
+ */
+final class NoDefaultClassException extends \Exception
+{
+}

application/symfony/tests/Unit/Domain/ActionManagement/ActionFactoryServiceTest.php

@@ -11,7 +11,7 @@ use App\DBAL\Types\ActionType;
 use App\Domain\ActionManagement\ActionInterface;
 use App\Domain\RequestManagement\Action\RequestedActionInterface;
 use App\Domain\RequestManagement\Action\RequestedAction;
-use App\Domain\RequestManagement\Right\RequestedRightInterface;
+use App\Domain\RequestManagement\Right\RequestedRight;
 
 /**
  * @author kevinfrantz
@@ -35,14 +35,13 @@ class ActionFactoryServiceTest extends TestCase
 
     public function setUp(): void
     {
-        $requestedRight = $this->createMock(RequestedRightInterface::class);
+        $requestedRight = new RequestedRight();
         $this->requestedAction = new RequestedAction($requestedRight);
         $this->actionService = $this->createMock(ActionServiceInterface::class);
         $this->actionService->method('getRequestedAction')->willReturn($this->requestedAction);
         $this->actionFactoryService = new ActionFactoryService($this->actionService);
     }
 
-    
     public function testCreate(): void
     {
         foreach (ActionType::getChoices() as $action) {

application/symfony/tests/Unit/Domain/RequestManagement/Action/RequestedActionTest.php

@@ -10,6 +10,7 @@ use App\Domain\RequestManagement\Action\RequestedAction;
 use App\DBAL\Types\ActionType;
 use App\DBAL\Types\Meta\Right\CRUDType;
 use App\Repository\Source\SourceRepositoryInterface;
+use App\DBAL\Types\Meta\Right\LayerType;
 
 /**
  * @author kevinfrantz
@@ -54,4 +55,13 @@ class RequestedActionTest extends TestCase
             $this->assertEquals($crud, $this->requestedRight->getCrud());
         }
     }
+
+    public function testLayer(): void
+    {
+        foreach (LayerType::getChoices() as $LayerType) {
+            $this->action->setLayer($LayerType);
+            $this->assertEquals($LayerType, $this->action->getLayer());
+            $this->assertEquals($LayerType, $this->requestedRight->getLayer());
+        }
+    }
 }