Solved Unit tests

This commit is contained in:
Kevin Frantz 2018-11-18 11:34:38 +01:00
parent 00c6ba1f9d
commit 0d0fa68094
2 changed files with 6 additions and 6 deletions

View File

@ -103,15 +103,14 @@ final class TreeSourceService extends AbstractSourceService implements TreeSourc
public function getAllLeaves(): Collection public function getAllLeaves(): Collection
{ {
$leaves = new ArrayCollection(); $leaves = new ArrayCollection($this->getLeaves()->toArray());
foreach ($this->getAllBranches()->toArray() as $branch) { foreach ($this->getAllBranches() as $branch) {
foreach ((new self($branch))->getLeaves() as $leave) { foreach ((new self($branch))->getAllLeaves() as $leave) {
if (! $leaves->contains($leave)) { if (! $leaves->contains($leave)) {
$leaves->add($leave); $leaves->add($leave);
} }
} }
} }
return $leaves; return $leaves;
} }
} }

View File

@ -27,7 +27,8 @@ class TreeSourceServiceTest extends TestCase
$leave2 = $this->createMock(SourceInterface::class); $leave2 = $this->createMock(SourceInterface::class);
$leave3 = $this->createMock(SourceInterface::class); $leave3 = $this->createMock(SourceInterface::class);
$leave4 = $this->createMock(SourceInterface::class); $leave4 = $this->createMock(SourceInterface::class);
$tree2->setCollection(new ArrayCollection([$leave3,$leave4,$tree5])); $leave5 = $this->createMock(SourceInterface::class);
$tree2->setCollection(new ArrayCollection([$leave3,$leave4,$tree5,$leave5]));
$collection = new ArrayCollection([$tree2,$tree3,$leave1,$leave2,$tree4]); $collection = new ArrayCollection([$tree2,$tree3,$leave1,$leave2,$tree4]);
$tree1->setCollection($collection); $tree1->setCollection($collection);
$this->treeService = new TreeSourceService($tree1); $this->treeService = new TreeSourceService($tree1);
@ -46,7 +47,7 @@ class TreeSourceServiceTest extends TestCase
} }
public function testGetAllLeaves():void{ public function testGetAllLeaves():void{
$this->assertEquals(4, $this->treeService->getAllLeaves()->count()); $this->assertEquals(5, $this->treeService->getAllLeaves()->count());
} }
} }