mirror of
https://github.com/kevinveenbirkenbach/docker-volume-backup.git
synced 2026-08-20 21:22:54 +00:00
Kevin Veen-Birkenbach
df1c65ccac
Two defaults could not be right. --repo-name fell back to the literal 'backup-docker-to-local' while its help promised the git repo folder name, which nothing ever derived. --databases-csv pointed inside the installed package directory, where credentials must not live; when it applied, load_databases_df read a missing file as empty and the run finished without a single dump and without an error. Both are required now, --repo-name in the restore CLI too. The file itself may still be absent - babadcb's tolerance is untouched, only the path must be named. --everything is withdrawn. Its one effect was to ignore --images-no-stop-required, which is what leaving that list empty already does, and its branch was the default path minus the requires_stop check. No caller, no test, and help and README described it differently. --dump-only-sql becomes --only-sql, and --only-files joins it as the opposite half: no dumps at all, every volume as files. They form a mutually exclusive group. A host that only copies files has no business holding database passwords, so --databases-csv is not required there and is never read. The smallest valid argv turned out to be written four times across the test tree; it now lives once. Withdrawn flags are listed in one place and proven to exit 2. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
119 lines
3.4 KiB
Python
119 lines
3.4 KiB
Python
import unittest
|
|
|
|
from .helpers import (
|
|
backup_path,
|
|
backup_run,
|
|
cleanup_docker,
|
|
create_minimal_compose_dir,
|
|
ensure_empty_dir,
|
|
latest_version_dir,
|
|
require_docker,
|
|
run,
|
|
unique,
|
|
write_databases_csv,
|
|
)
|
|
|
|
|
|
class TestE2EFilesNoCopy(unittest.TestCase):
|
|
@classmethod
|
|
def setUpClass(cls) -> None:
|
|
require_docker()
|
|
cls.prefix = unique("baudolo-e2e-files-nocopy")
|
|
cls.backups_dir = f"/tmp/{cls.prefix}/Backups"
|
|
ensure_empty_dir(cls.backups_dir)
|
|
|
|
cls.compose_dir = create_minimal_compose_dir(f"/tmp/{cls.prefix}")
|
|
cls.repo_name = cls.prefix
|
|
|
|
cls.volume_src = f"{cls.prefix}-vol-src"
|
|
cls.containers: list[str] = []
|
|
cls.volumes = [cls.volume_src]
|
|
|
|
run(["docker", "volume", "create", cls.volume_src])
|
|
run(
|
|
[
|
|
"docker",
|
|
"run",
|
|
"--rm",
|
|
"-v",
|
|
f"{cls.volume_src}:/data",
|
|
"alpine:3.20",
|
|
"sh",
|
|
"-lc",
|
|
"echo 'hello' > /data/hello.txt",
|
|
]
|
|
)
|
|
|
|
cls.databases_csv = f"/tmp/{cls.prefix}/databases.csv"
|
|
write_databases_csv(cls.databases_csv, [])
|
|
|
|
# only-sql => non-DB volumes are STILL backed up as files
|
|
backup_run(
|
|
backups_dir=cls.backups_dir,
|
|
repo_name=cls.repo_name,
|
|
compose_dir=cls.compose_dir,
|
|
databases_csv=cls.databases_csv,
|
|
database_containers=["dummy-db"],
|
|
images_no_stop_required=["alpine:3.20"],
|
|
only_sql=True,
|
|
)
|
|
|
|
cls.hash, cls.version = latest_version_dir(cls.backups_dir, cls.repo_name)
|
|
|
|
# Wipe the volume to ensure restore actually restores something
|
|
run(["docker", "volume", "rm", "-f", cls.volume_src])
|
|
run(["docker", "volume", "create", cls.volume_src])
|
|
|
|
@classmethod
|
|
def tearDownClass(cls) -> None:
|
|
cleanup_docker(containers=cls.containers, volumes=cls.volumes)
|
|
|
|
def test_files_backup_present_for_non_db_volume(self) -> None:
|
|
p = (
|
|
backup_path(self.backups_dir, self.repo_name, self.version, self.volume_src)
|
|
/ "files"
|
|
)
|
|
self.assertTrue(p.exists(), f"Expected files backup dir at: {p}")
|
|
|
|
def test_restore_files_succeeds_and_restores_content(self) -> None:
|
|
p = run(
|
|
[
|
|
"baudolo-restore",
|
|
"files",
|
|
self.volume_src,
|
|
self.hash,
|
|
self.version,
|
|
"--backups-dir",
|
|
self.backups_dir,
|
|
"--repo-name",
|
|
self.repo_name,
|
|
],
|
|
check=False,
|
|
)
|
|
self.assertEqual(
|
|
p.returncode,
|
|
0,
|
|
f"Expected exitcode 0, got {p.returncode}\nSTDOUT={p.stdout}\nSTDERR={p.stderr}",
|
|
)
|
|
|
|
cp = run(
|
|
[
|
|
"docker",
|
|
"run",
|
|
"--rm",
|
|
"-v",
|
|
f"{self.volume_src}:/data",
|
|
"alpine:3.20",
|
|
"sh",
|
|
"-lc",
|
|
"cat /data/hello.txt",
|
|
],
|
|
capture=True,
|
|
check=True,
|
|
)
|
|
self.assertEqual(
|
|
cp.stdout.strip(),
|
|
"hello",
|
|
f"Unexpected restored content. STDOUT={cp.stdout}\nSTDERR={cp.stderr}",
|
|
)
|