mirror of
https://github.com/kevinveenbirkenbach/docker-volume-backup.git
synced 2026-08-20 13:12:48 +00:00
ruff was never wired into this repository: no target, no CI step, no pin. It reported 45 findings across sources and tests, so nothing enforced what the codebase already mostly followed. Adds `make ruff` (check + format --check), `make ruff-fix`, and `make lint` as its alias, and makes `make test` run lint as a fourth parallel spur. The CI workflow calls `make test`, so it is covered there too. The linter is pinned in a `lint` extra: a ruff minor bump changes which rules fire, and with the suite gating on a clean run an unpinned linter would fail it on an unrelated day. The 45 findings are fixed rather than configured away. Three needed a decision instead of the mechanical fix: - The generation timestamp keeps its local wall clock (DTZ005 waived). Generations sort by that name, and UTC would order new ones before the existing ones wherever the offset is positive - "newest generation" is what every restore path selects on. - The per-volume `copy` closure now binds volume_name and vol_dir as default arguments (B023). It only worked because it is called inside the same iteration. - The two CLI top-level handlers keep their blind except (BLE001 waived): turning any failure into exit 1 is what a CLI boundary is for. The two in run.py did not need it and were narrowed to what they actually catch. Also drops the comments that restate the code: the section banners in restore/__main__.py, the filename repeated as line 1 of nine test files, step narration above the statement it narrates, and a block in app.py documenting parameters that had moved to another module. What names a trip-wire stays - the snapshot destination rule, the mysql-binary absence in MariaDB 11 images, the session-scoped FOREIGN_KEY_CHECKS, the spooled temp file for multi-GB dumps, and the negative control that loses its discriminating power if it ever passes. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
103 lines
3.7 KiB
Python
103 lines
3.7 KiB
Python
from __future__ import annotations
|
|
|
|
from .shell import BackupException, execute_shell_command
|
|
|
|
|
|
def get_image_info(container: str) -> str:
|
|
return execute_shell_command(
|
|
f"docker inspect --format '{{{{.Config.Image}}}}' {container}"
|
|
)[0]
|
|
|
|
|
|
def image_name(container: str) -> str:
|
|
"""The image's repository path, without registry host, tag or digest.
|
|
|
|
A swarm node that hosts the local registry puts its own hostname in front
|
|
of every pull, so the raw reference of a Postgres container can read
|
|
`svc-db-mariadb-swarm-mgr-01:5000/postgres_custom:17-3.5`. Matching the
|
|
whole reference finds "mariadb" there and dumps the database with
|
|
mariadb-dump, which the Postgres image does not ship (exit 127). Tags bite
|
|
the same way: `xwiki_custom:lts-postgres-tomcat`.
|
|
"""
|
|
reference = get_image_info(container).strip().split("@", 1)[0]
|
|
head, _, tail = reference.rpartition("/")
|
|
tail = tail.split(":", 1)[0]
|
|
if head:
|
|
registry = head.split("/", 1)[0]
|
|
if "." in registry or ":" in registry or registry == "localhost":
|
|
head = head.partition("/")[2]
|
|
return f"{head}/{tail}" if head else tail
|
|
|
|
|
|
def has_image(container: str, pattern: str) -> bool:
|
|
"""Return True if the container's image name contains the pattern."""
|
|
return pattern in image_name(container)
|
|
|
|
|
|
def docker_volume_names() -> list[str]:
|
|
return execute_shell_command("docker volume ls --format '{{.Name}}'")
|
|
|
|
|
|
def containers_using_volume(volume_name: str) -> list[str]:
|
|
return execute_shell_command(
|
|
f"docker ps --filter volume=\"{volume_name}\" --format '{{{{.Names}}}}'"
|
|
)
|
|
|
|
|
|
def is_swarm_task(container: str) -> bool:
|
|
"""Swarm-managed task containers must never be stopped or started
|
|
manually: the orchestrator replaces the stopped task and a later
|
|
`docker start` fails on the detached overlay network. A container that
|
|
vanished between listing and inspect (--rm one-shots, task-history GC)
|
|
counts as not stoppable instead of aborting the whole backup run; if the
|
|
container still exists the inspect failure re-raises, so a broken daemon
|
|
keeps failing the run loudly instead of silently skipping the stop."""
|
|
try:
|
|
out = execute_shell_command(
|
|
"docker inspect --format "
|
|
f"'{{{{index .Config.Labels \"com.docker.swarm.task.id\"}}}}' {container}"
|
|
)
|
|
except BackupException:
|
|
still_listed = execute_shell_command(
|
|
f"docker ps -a --filter name=^{container}$ --format '{{{{.Names}}}}'"
|
|
)
|
|
if still_listed and still_listed[0].strip():
|
|
raise
|
|
return True
|
|
return bool(out and out[0].strip())
|
|
|
|
|
|
def filter_stoppable(containers: list[str]) -> list[str]:
|
|
"""Containers baudolo may stop/start itself (everything but swarm tasks)."""
|
|
stoppable = []
|
|
for container in containers:
|
|
if is_swarm_task(container):
|
|
print(
|
|
f"Skipping stop/start for swarm task container '{container}'.",
|
|
flush=True,
|
|
)
|
|
continue
|
|
stoppable.append(container)
|
|
return stoppable
|
|
|
|
|
|
def change_containers_status(containers: list[str], status: str) -> None:
|
|
"""Stop or start a list of containers."""
|
|
if not containers:
|
|
print(f"No containers to {status}.", flush=True)
|
|
return
|
|
names = " ".join(containers)
|
|
print(f"{status.capitalize()} containers: {names}...", flush=True)
|
|
execute_shell_command(f"docker {status} {names}")
|
|
|
|
|
|
def docker_volume_exists(volume: str) -> bool:
|
|
# Avoid throwing exceptions for exists checks.
|
|
try:
|
|
execute_shell_command(
|
|
f"docker volume inspect {volume} >/dev/null 2>&1 && echo OK"
|
|
)
|
|
return True
|
|
except BackupException:
|
|
return False
|