mirror of
https://github.com/kevinveenbirkenbach/docker-volume-backup.git
synced 2026-08-20 13:12:48 +00:00
ruff was never wired into this repository: no target, no CI step, no pin. It reported 45 findings across sources and tests, so nothing enforced what the codebase already mostly followed. Adds `make ruff` (check + format --check), `make ruff-fix`, and `make lint` as its alias, and makes `make test` run lint as a fourth parallel spur. The CI workflow calls `make test`, so it is covered there too. The linter is pinned in a `lint` extra: a ruff minor bump changes which rules fire, and with the suite gating on a clean run an unpinned linter would fail it on an unrelated day. The 45 findings are fixed rather than configured away. Three needed a decision instead of the mechanical fix: - The generation timestamp keeps its local wall clock (DTZ005 waived). Generations sort by that name, and UTC would order new ones before the existing ones wherever the offset is positive - "newest generation" is what every restore path selects on. - The per-volume `copy` closure now binds volume_name and vol_dir as default arguments (B023). It only worked because it is called inside the same iteration. - The two CLI top-level handlers keep their blind except (BLE001 waived): turning any failure into exit 1 is what a CLI boundary is for. The two in run.py did not need it and were narrowed to what they actually catch. Also drops the comments that restate the code: the section banners in restore/__main__.py, the filename repeated as line 1 of nine test files, step narration above the statement it narrates, and a block in app.py documenting parameters that had moved to another module. What names a trip-wire stays - the snapshot destination rule, the mysql-binary absence in MariaDB 11 images, the session-scoped FOREIGN_KEY_CHECKS, the spooled temp file for multi-GB dumps, and the negative control that loses its discriminating power if it ever passes. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
143 lines
4.9 KiB
Python
143 lines
4.9 KiB
Python
"""Back up every Docker volume of a host into a timestamped generation."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import os
|
|
from contextlib import ExitStack
|
|
from datetime import datetime
|
|
|
|
from .cli import parse_args
|
|
from .compose import handle_docker_compose_services
|
|
from .docker import (
|
|
change_containers_status,
|
|
containers_using_volume,
|
|
docker_volume_names,
|
|
filter_stoppable,
|
|
)
|
|
from .dumps import backup_dumps_for_volume, load_databases_df
|
|
from .layout import (
|
|
create_version_directory,
|
|
create_volume_directory,
|
|
get_machine_id,
|
|
stamp_directory,
|
|
)
|
|
from .policy import requires_stop, volume_is_fully_ignored
|
|
from .snapshot import volume_snapshot
|
|
from .volume import backup_volume, get_storage_path
|
|
|
|
|
|
def main() -> int:
|
|
args = parse_args()
|
|
|
|
machine_id = get_machine_id()
|
|
# Local wall clock on purpose: generations sort by this name, and UTC would
|
|
# order new ones before the existing ones wherever the offset is positive.
|
|
backup_time = datetime.now().strftime("%Y%m%d%H%M%S") # noqa: DTZ005
|
|
|
|
versions_dir = os.path.join(args.backups_dir, machine_id, args.repo_name)
|
|
version_dir = create_version_directory(versions_dir, backup_time)
|
|
|
|
databases_df = load_databases_df(args.databases_csv)
|
|
|
|
print("💾 Start volume backups...", flush=True)
|
|
|
|
with ExitStack() as stack:
|
|
resolve_source = None
|
|
if args.snapshot:
|
|
resolve_source = stack.enter_context(
|
|
volume_snapshot(args.snapshot, args.snapshot_subject, backup_time)
|
|
)
|
|
|
|
for volume_name in docker_volume_names():
|
|
print(f"Start backup routine for volume: {volume_name}", flush=True)
|
|
|
|
if volume_name in args.volumes_no_backup_required:
|
|
print(
|
|
f"Skipping volume '{volume_name}' entirely (declared no-backup).",
|
|
flush=True,
|
|
)
|
|
continue
|
|
|
|
containers = containers_using_volume(volume_name)
|
|
|
|
if volume_is_fully_ignored(containers, args.images_no_backup_required):
|
|
print(
|
|
f"Skipping volume '{volume_name}' entirely (all linked containers are ignored).",
|
|
flush=True,
|
|
)
|
|
continue
|
|
|
|
vol_dir = create_volume_directory(version_dir, volume_name)
|
|
|
|
found_db, dumped_any = backup_dumps_for_volume(
|
|
containers=containers,
|
|
vol_dir=vol_dir,
|
|
databases_df=databases_df,
|
|
database_containers=args.database_containers,
|
|
)
|
|
|
|
if args.dump_only_sql and found_db:
|
|
if not dumped_any:
|
|
print(
|
|
f"WARNING: dump-only-sql requested but no DB dump was produced for DB volume '{volume_name}'. "
|
|
"Falling back to file backup.",
|
|
flush=True,
|
|
)
|
|
else:
|
|
continue
|
|
|
|
live_source = get_storage_path(volume_name)
|
|
|
|
def copy(
|
|
*,
|
|
authoritative: bool,
|
|
source: str = live_source,
|
|
volume: str = volume_name,
|
|
target: str = vol_dir,
|
|
) -> None:
|
|
backup_volume(
|
|
versions_dir,
|
|
volume,
|
|
target,
|
|
authoritative=authoritative,
|
|
source=source,
|
|
)
|
|
|
|
if resolve_source is not None:
|
|
snapshot_source = resolve_source(live_source)
|
|
if os.path.isdir(snapshot_source):
|
|
copy(authoritative=True, source=snapshot_source)
|
|
else:
|
|
print(
|
|
f"WARNING: volume '{volume_name}' is not in the snapshot "
|
|
"(created after it was taken); copying it live instead.",
|
|
flush=True,
|
|
)
|
|
copy(authoritative=False)
|
|
continue
|
|
|
|
if args.everything:
|
|
stoppable = filter_stoppable(containers)
|
|
copy(authoritative=False)
|
|
change_containers_status(stoppable, "stop")
|
|
copy(authoritative=True)
|
|
if not args.shutdown:
|
|
change_containers_status(stoppable, "start")
|
|
continue
|
|
|
|
copy(authoritative=False)
|
|
if requires_stop(containers, args.images_no_stop_required):
|
|
stoppable = filter_stoppable(containers)
|
|
change_containers_status(stoppable, "stop")
|
|
copy(authoritative=True)
|
|
if not args.shutdown:
|
|
change_containers_status(stoppable, "start")
|
|
|
|
stamp_directory(version_dir)
|
|
print("Finished volume backups.", flush=True)
|
|
|
|
print("Handling Docker Compose services...", flush=True)
|
|
handle_docker_compose_services(args.compose_dir, args.hard_restart_projects)
|
|
|
|
return 0
|