mirror of
https://github.com/kevinveenbirkenbach/docker-volume-backup.git
synced 2026-08-20 21:22:54 +00:00
Kevin Veen-Birkenbach
df1c65ccac
Two defaults could not be right. --repo-name fell back to the literal 'backup-docker-to-local' while its help promised the git repo folder name, which nothing ever derived. --databases-csv pointed inside the installed package directory, where credentials must not live; when it applied, load_databases_df read a missing file as empty and the run finished without a single dump and without an error. Both are required now, --repo-name in the restore CLI too. The file itself may still be absent - babadcb's tolerance is untouched, only the path must be named. --everything is withdrawn. Its one effect was to ignore --images-no-stop-required, which is what leaving that list empty already does, and its branch was the default path minus the requires_stop check. No caller, no test, and help and README described it differently. --dump-only-sql becomes --only-sql, and --only-files joins it as the opposite half: no dumps at all, every volume as files. They form a mutually exclusive group. A host that only copies files has no business holding database passwords, so --databases-csv is not required there and is never read. The smallest valid argv turned out to be written four times across the test tree; it now lives once. Withdrawn flags are listed in one place and proven to exit 2. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
82 lines
2.9 KiB
Python
82 lines
2.9 KiB
Python
"""Contract of --volumes-no-backup-required: exclusion is per volume name,
|
|
independent of which containers use it."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import unittest
|
|
from unittest import mock
|
|
|
|
from baudolo.backup import app
|
|
from baudolo.backup.volume import Backing
|
|
|
|
from . import BASE_ARGV
|
|
|
|
ARGV = [
|
|
*BASE_ARGV,
|
|
"--volumes-no-backup-required",
|
|
"derived",
|
|
]
|
|
|
|
|
|
def drive() -> tuple[list[str], list[str], list[str]]:
|
|
backed_up: list[str] = []
|
|
created: list[str] = []
|
|
inspected: list[str] = []
|
|
|
|
def record_backup(versions_dir, volume_name, volume_dir, *, authoritative, source):
|
|
backed_up.append(volume_name)
|
|
|
|
with (
|
|
mock.patch("sys.argv", ARGV),
|
|
mock.patch.object(app, "get_machine_id", return_value="machine"),
|
|
mock.patch.object(app, "create_version_directory", return_value="/gen"),
|
|
mock.patch.object(
|
|
app,
|
|
"create_volume_directory",
|
|
side_effect=lambda _version_dir, name: created.append(name) or "/gen/vol",
|
|
),
|
|
mock.patch.object(app, "load_databases_df", return_value=None),
|
|
mock.patch.object(
|
|
app, "docker_volume_names", return_value=["derived", "state"]
|
|
),
|
|
mock.patch.object(
|
|
app,
|
|
"containers_using_volume",
|
|
side_effect=lambda name: inspected.append(name) or ["app"],
|
|
),
|
|
mock.patch.object(app, "volume_is_fully_ignored", return_value=False),
|
|
mock.patch.object(app, "backup_dumps_for_volume", return_value=(False, False)),
|
|
mock.patch.object(app, "inspect_backing", return_value=Backing("/data")),
|
|
mock.patch.object(app, "stamp_directory"),
|
|
mock.patch.object(app, "handle_docker_compose_services"),
|
|
mock.patch.object(app.os.path, "isdir", return_value=True),
|
|
mock.patch.object(app, "backup_volume", side_effect=record_backup),
|
|
mock.patch.object(app, "filter_stoppable", return_value=[]),
|
|
mock.patch.object(app, "requires_stop", return_value=False),
|
|
mock.patch.object(app, "change_containers_status"),
|
|
):
|
|
app.main()
|
|
return backed_up, created, inspected
|
|
|
|
|
|
class TestVolumesNoBackupRequired(unittest.TestCase):
|
|
def test_the_named_volume_is_never_backed_up(self) -> None:
|
|
backed_up, _created, _inspected = drive()
|
|
self.assertNotIn("derived", backed_up)
|
|
|
|
def test_a_sibling_volume_of_the_same_container_survives(self) -> None:
|
|
backed_up, _created, _inspected = drive()
|
|
self.assertEqual(backed_up, ["state"])
|
|
|
|
def test_no_generation_directory_is_created_for_it(self) -> None:
|
|
_backed_up, created, _inspected = drive()
|
|
self.assertEqual(created, ["state"])
|
|
|
|
def test_the_skip_precedes_the_container_inspection(self) -> None:
|
|
_backed_up, _created, inspected = drive()
|
|
self.assertEqual(inspected, ["state"])
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|