kevinveenbirkenbach/docker-volume-backup
1
0
Fork 0
mirror of https://github.com/kevinveenbirkenbach/docker-volume-backup.git synced 2026-07-17 06:05:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(unit): mock is_swarm_task in the requires_stop tests

Browse Source 
requires_stop now probes is_swarm_task per container, which runs a real
docker inspect; the unit CI container has no docker socket, so the three
whitelist tests died with BackupException. Mock the probe to False so
they assert the unchanged whitelist logic, and add a swarm case proving
a task container never triggers a stop and skips the image check
entirely.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Kevin Veen-Birkenbach
2026-07-11 08:34:36 +02:00
parent e9030e8443
commit 79214e64e8
1 changed files with 17 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
tests/unit/test_backup.py
View File

@@ -4,10 +4,11 @@ from unittest.mock import patch
from baudolo.backup.app import requires_stop from baudolo.backup.app import requires_stop
@patch("baudolo.backup.app.is_swarm_task", return_value=False)
class TestRequiresStop(unittest.TestCase): class TestRequiresStop(unittest.TestCase):
@patch("baudolo.backup.app.get_image_info") @patch("baudolo.backup.app.get_image_info")
def test_requires_stop_false_when_all_images_are_whitelisted( def test_requires_stop_false_when_all_images_are_whitelisted(
self, mock_get_image_info self, mock_get_image_info, _mock_is_swarm_task
): ):
# All containers use images containing allowed substrings # All containers use images containing allowed substrings
mock_get_image_info.side_effect = [ mock_get_image_info.side_effect = [
@@ -20,7 +21,7 @@ class TestRequiresStop(unittest.TestCase):
@patch("baudolo.backup.app.get_image_info") @patch("baudolo.backup.app.get_image_info")
def test_requires_stop_true_when_any_image_is_not_whitelisted( def test_requires_stop_true_when_any_image_is_not_whitelisted(
self, mock_get_image_info self, mock_get_image_info, _mock_is_swarm_task
): ):
mock_get_image_info.side_effect = [ mock_get_image_info.side_effect = [
"repo/mastodon:v4", "repo/mastodon:v4",
@@ -31,10 +32,23 @@ class TestRequiresStop(unittest.TestCase):
self.assertTrue(requires_stop(containers, whitelist)) self.assertTrue(requires_stop(containers, whitelist))
@patch("baudolo.backup.app.get_image_info") @patch("baudolo.backup.app.get_image_info")
def test_requires_stop_true_when_whitelist_empty(self, mock_get_image_info): def test_requires_stop_true_when_whitelist_empty(
self, mock_get_image_info, _mock_is_swarm_task
):
mock_get_image_info.return_value = "repo/anything:latest" mock_get_image_info.return_value = "repo/anything:latest"
self.assertTrue(requires_stop(["c1"], [])) self.assertTrue(requires_stop(["c1"], []))
class TestRequiresStopSwarm(unittest.TestCase):
@patch("baudolo.backup.app.get_image_info")
@patch("baudolo.backup.app.is_swarm_task", return_value=True)
def test_swarm_tasks_never_require_stop(
self, _mock_is_swarm_task, mock_get_image_info
):
mock_get_image_info.return_value = "repo/not-whitelisted:latest"
self.assertFalse(requires_stop(["c1"], []))
mock_get_image_info.assert_not_called()
if __name__ == "__main__": if __name__ == "__main__":
unittest.main() unittest.main()